From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH 08/16] i2c: Convert dev_printk(KERN_<LEVEL> to
 dev_<level>(
Date: Sun, 28 Oct 2012 12:45:10 +0100
Message-ID: <20121028124510.76e23bd5@endymion.delvare>
References: <cover.1351411047.git.joe@perches.com>
	<3e4988b083a8b5d03a458aabc18042cedb3dbd8a.1351411047.git.joe@perches.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <3e4988b083a8b5d03a458aabc18042cedb3dbd8a.1351411047.git.joe@perches.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, "Ben Dooks (embedded platforms)" <ben-linux@fluff.org>, "Wolfram Sang (embedded platforms)" <w.sang@pengutronix.de>, linux-i2c@vger.kernel.org
List-Id: linux-i2c@vger.kernel.org

Hi Joe,

On Sun, 28 Oct 2012 01:05:46 -0700, Joe Perches wrote:
> dev_<level> calls take less code than dev_printk(KERN_<LEVEL>
> and reducing object size is good.
> Coalesce formats for easier grep.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/i2c/busses/i2c-piix4.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 8bbd6ec..f7216ed 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -204,9 +204,8 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev,
>  			 */
>  			pci_write_config_byte(PIIX4_dev, SMBHSTCFG,
>  					      temp | 1);
> -			dev_printk(KERN_NOTICE, &PIIX4_dev->dev,
> -				"WARNING: SMBus interface has been "
> -				"FORCEFULLY ENABLED!\n");
> +			dev_notice(&PIIX4_dev->dev,
> +				   "WARNING: SMBus interface has been FORCEFULLY ENABLED!\n");
>  		} else {
>  			dev_err(&PIIX4_dev->dev,
>  				"Host SMBus controller not enabled!\n");

Applied, thanks.

-- 
Jean Delvare