Re: [PATCH RFC] i2c: omap: Fix the revision register read

Felipe Balbi
2012-10-31T11:52:54Z

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Hi,

On Wed, Oct 31, 2012 at 04:28:38PM +0530, Shubhrajyoti wrote:
> On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:
> >>
> >> > + if (!_dev->regs)
> >> > + return 0;
> > this is wrong, you need to make sure dev->regs is set early enough.
>
>
> to set the dev->regs I use the value read from revision register.
>
> to read the revision register I do a get_sync first. This in turn leads
> to the call to resume handler.
> At this point the regs is NULL and so the check.
>
> After reading the register and checking the scheme bit.
> the reg map is populated.
>
> How can this issue be solved?

aaa good point, missed that. Nevermind that comment ;-)

cheers