From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
b-cousson-l0cyMroinI0@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH RFC] i2c: omap: Fix the revision register read
Date: Wed, 31 Oct 2012 13:52:54 +0200 [thread overview]
Message-ID: <20121031115254.GB10733@arwen.pp.htv.fi> (raw)
In-Reply-To: <5091045E.8040407-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Hi,
On Wed, Oct 31, 2012 at 04:28:38PM +0530, Shubhrajyoti wrote:
> On Wednesday 31 October 2012 03:42 PM, Felipe Balbi wrote:
> >>
> >> > + if (!_dev->regs)
> >> > + return 0;
> > this is wrong, you need to make sure dev->regs is set early enough.
>
>
> to set the dev->regs I use the value read from revision register.
>
> to read the revision register I do a get_sync first. This in turn leads
> to the call to resume handler.
> At this point the regs is NULL and so the check.
>
> After reading the register and checking the scheme bit.
> the reg map is populated.
>
> How can this issue be solved?
aaa good point, missed that. Nevermind that comment ;-)
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-10-31 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 8:59 [PATCH RFC] i2c: omap: Fix the revision register read Shubhrajyoti D
[not found] ` <1351673959-5918-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-10-31 9:32 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cssHRYFJprozOSJqXNgeCub27jyVXkhvvMaxz-Z44d_EA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-31 10:12 ` Felipe Balbi
2012-10-31 10:12 ` Felipe Balbi
[not found] ` <20121031101201.GB10094-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-31 10:48 ` Shubhrajyoti
2012-10-31 11:52 ` Felipe Balbi
2012-10-31 10:58 ` Shubhrajyoti
[not found] ` <5091045E.8040407-l0cyMroinI0@public.gmane.org>
2012-10-31 11:52 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031115254.GB10733@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox