From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
b-cousson-l0cyMroinI0@public.gmane.org,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCHv2 3/7] i2c: omap: remove the dtrev
Date: Mon, 5 Nov 2012 09:53:20 +0200 [thread overview]
Message-ID: <20121105075320.GD32468@arwen.pp.htv.fi> (raw)
In-Reply-To: <1352025873-27492-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
Hi,
On Sun, Nov 04, 2012 at 04:14:29PM +0530, Shubhrajyoti D wrote:
> The dtrev is used only for the comments. Remove the same and use
> the scheme instead to know if it is version2.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
I would drop dtrev completely and not use scheme to "emulate" it. dtrev
is wrong and unnecessary; it was only created due to the wrong
assumption that HW revision register was wrong. Looks like that
assumption was made based on the driver which is clearly wrong wrt
revision detection.
Also, when dropping dtrev, also drop it from platform_data and
omap_hwmod database (could be done on a separate patch).
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-05 7:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 10:44 [PATCHv2 0/7] i2c: omap: updates Shubhrajyoti D
[not found] ` <1352025873-27492-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-04 10:44 ` [PATCHv2 1/7] i2c: omap: Fix the revision register read Shubhrajyoti D
[not found] ` <1352025873-27492-2-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:50 ` Felipe Balbi
2012-11-05 8:34 ` Shubhrajyoti
[not found] ` <50977A30.6040907-l0cyMroinI0@public.gmane.org>
2012-11-05 9:04 ` Felipe Balbi
2012-11-05 9:24 ` Shubhrajyoti Datta
2012-11-05 10:01 ` Felipe Balbi
[not found] ` <20121105100105.GC3327-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05 10:45 ` Felipe Balbi
2012-11-05 9:40 ` Shubhrajyoti Datta
2012-11-04 10:44 ` [PATCHv2 2/7] i2c: omap: use revision check for OMAP_I2C_FLAG_APPLY_ERRATA_I207 Shubhrajyoti D
[not found] ` <1352025873-27492-3-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:51 ` Felipe Balbi
2012-11-04 10:44 ` [PATCHv2 3/7] i2c: omap: remove the dtrev Shubhrajyoti D
[not found] ` <1352025873-27492-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:53 ` Felipe Balbi [this message]
[not found] ` <20121105075320.GD32468-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05 8:44 ` Shubhrajyoti
2012-11-05 9:05 ` Felipe Balbi
[not found] ` <20121105090517.GB2913-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-05 9:26 ` Shubhrajyoti
2012-11-04 10:44 ` [PATCHv2 4/7] ARM: i2c: omap: Remove the i207 errata flag Shubhrajyoti D
[not found] ` <1352025873-27492-5-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:53 ` Felipe Balbi
2012-11-04 10:44 ` [PATCHv2 7/7] i2c: omap: Restore i2c context always Shubhrajyoti D
[not found] ` <1352025873-27492-8-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:56 ` Felipe Balbi
2012-11-04 10:44 ` [PATCHv2 5/7] i2c: omap: re-factor omap_i2c_init function Shubhrajyoti D
[not found] ` <1352025873-27492-6-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-05 7:54 ` Felipe Balbi
2012-11-04 10:44 ` [PATCHv2 6/7] i2c: omap: make reset a seperate function Shubhrajyoti D
2012-11-05 7:55 ` Felipe Balbi
2012-11-05 7:46 ` [PATCHv2 0/7] i2c: omap: updates Felipe Balbi
2012-11-05 8:34 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121105075320.GD32468@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).