From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 1/2] i2c: Add possibility for user-defined (i2c-)devices for bus-drivers. Date: Tue, 13 Nov 2012 19:55:33 +0100 Message-ID: <20121113195533.6db71716@endymion.delvare> References: <1352829968-4908-1-git-send-email-holler@ahsoftware.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1352829968-4908-1-git-send-email-holler-SXC+2es9fhnfWeYVQQPykw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Holler Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Till Harbaum List-Id: linux-i2c@vger.kernel.org On Tue, 13 Nov 2012 19:06:07 +0100, Alexander Holler wrote: > This makes it possible to define i2c-devices at the kernel command line > or as a module parameter for bus-drivers which want to offer such > an functionality. > > Drivers which are using it will have the a parameter named > devices with format devname1@addr1,devname2@addr2,... > e.g. devices=ds1307@0x68,pcf8563@0x51 No, no, no. We did that 10 years ago, killed all the code 3 years ago [1], let's not do the same mistake again, please. We have a sysfs interface for instantiating clients dynamically from user-space, it's way more powerful and flexible than your proposal. Just try plugging two different i2c-tiny-usb adapters on the same system and see the new code instantiate the wrong devices... [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=7f508118b1c1f9856a1c899a2bd4867a962b0225 > The devices will be probed using the standard probe mechanism, > the definition of up to 8 devices is allowed. > > Cc: Jean Delvare > Cc: Till Harbaum > Signed-off-by: Alexander Holler > --- > Documentation/i2c/instantiating-devices | 37 ++++++++++++++++++++++++++++++ > drivers/i2c/i2c-core.c | 40 +++++++++++++++++++++++++++++++++ > include/linux/i2c.h | 14 ++++++++++++ > 3 files changed, 91 insertions(+) > (...) -- Jean Delvare