From: Wolfram Sang <w.sang@pengutronix.de>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: Shubhrajyoti D <shubhrajyoti@ti.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
tony@atomide.com, b-cousson@ti.com
Subject: Re: [PATCH] i2c: omap: Move the remove constraint
Date: Wed, 14 Nov 2012 11:57:34 +0100 [thread overview]
Message-ID: <20121114105734.GE5954@pengutronix.de> (raw)
In-Reply-To: <CAORVsuW_VAiemnauUs-yW+GcQpv+qpESP4kzyQm=Unmofa4k_Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
> > Currently we just queue the transfer and release the
> > qos constraints, however we donot wait for the transfer
> > to complete to release the constraint. Move the remove
> > constraint after the bus busy as we are sure that the
> > transfers are completed by then.
> >
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>
> Good catch, the change definitely makes sense. Feel free to add:
>
> Acked-by: Jean Pihet <j-pihet@ti.com>
Since I just reverted the QoS patch, I suppose this gets merged into the
original patch when resent?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-14 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 9:54 [PATCH] i2c: omap: Move the remove constraint Shubhrajyoti D
[not found] ` <1352195673-31559-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-11-06 16:24 ` Jean Pihet
2012-11-14 10:57 ` Wolfram Sang [this message]
[not found] ` <20121114105734.GE5954-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-14 11:03 ` Jean Pihet
[not found] ` <CAORVsuUxA=AhPowWqTWx5AfzU6R2Ny6OEhvDmtwUh8poh=UnGg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-14 11:25 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114105734.GE5954@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=b-cousson@ti.com \
--cc=ben-linux@fluff.org \
--cc=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox