From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Date: Thu, 15 Nov 2012 10:29:53 +0100 Message-ID: <20121115092953.GA418@pengutronix.de> References: <1352222317.15558.1584.camel@cliu38-desktop-build> <20121115084858.GA29668@bnru10> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Return-path: Content-Disposition: inline In-Reply-To: <20121115084858.GA29668@bnru10> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinidhi Kasagar Cc: chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > - if (timeout < 0) { > > - dev_err(&dev->adev->dev, > > - "wait_for_completion_timeout " > > - "returned %d waiting for event\n", timeout); > > - status =3D timeout; > > - } > > - > No, it is wrong. You need to update the status variable in the case of ti= meout. Looking at the patch context, such code comes later. --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEUEARECAAYFAlCkthEACgkQD27XaX1/VRue5QCfeckXfQePz2lemPalqV4qdR8/ DQQAmOsTqsnFfVP3gXBDLmUN05gVmqE= =ayxD -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--