From: Srinidhi Kasagar <srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
<chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
Date: Thu, 15 Nov 2012 15:27:42 +0530 [thread overview]
Message-ID: <20121115095741.GA6280@bnru10> (raw)
In-Reply-To: <20121115092953.GA418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
>
> > > - if (timeout < 0) {
> > > - dev_err(&dev->adev->dev,
> > > - "wait_for_completion_timeout "
> > > - "returned %d waiting for event\n", timeout);
> > > - status = timeout;
> > > - }
> > > -
> > No, it is wrong. You need to update the status variable in the case of timeout.
>
> Looking at the patch context, such code comes later.
But it causes regressions; without looking at the "later" code, we can't afford merging
this code now.
regards/srinidhi
next prev parent reply other threads:[~2012-11-15 9:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1352222317.15558.1584.camel@cliu38-desktop-build>
2012-11-12 17:26 ` [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Wolfram Sang
2012-11-13 1:21 ` Liu, Chuansheng
2012-11-13 7:58 ` Wolfram Sang
[not found] ` <20121113075813.GA23119-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-13 8:00 ` Liu, Chuansheng
[not found] ` <CACRpkdYekQF5111NSNSPeaHdxgS_gpXkCjqT1n-n1_iAdDXbSg@mail.gmail.com>
2012-11-15 8:49 ` Fwd: " Srinidhi Kasagar
2012-11-15 9:29 ` Wolfram Sang
[not found] ` <20121115092953.GA418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 9:57 ` Srinidhi Kasagar [this message]
2012-11-15 10:18 ` Wolfram Sang
[not found] ` <20121115101820.GC418-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 11:18 ` Srinidhi Kasagar
2012-11-15 10:52 ` Chuansheng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115095741.GA6280@bnru10 \
--to=srinidhi.kasagar-0is4wlfg1ojsueelwk9/pw@public.gmane.org \
--cc=chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).