From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout Date: Thu, 15 Nov 2012 11:18:20 +0100 Message-ID: <20121115101820.GC418@pengutronix.de> References: <1352222317.15558.1584.camel@cliu38-desktop-build> <20121115084858.GA29668@bnru10> <20121115092953.GA418@pengutronix.de> <20121115095741.GA6280@bnru10> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C94crkcyjafcjHxo" Return-path: Content-Disposition: inline In-Reply-To: <20121115095741.GA6280@bnru10> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Srinidhi Kasagar Cc: "chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org --C94crkcyjafcjHxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: > On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: > >=20 > > > > - if (timeout < 0) { > > > > - dev_err(&dev->adev->dev, > > > > - "wait_for_completion_timeout " > > > > - "returned %d waiting for event\n", timeout); > > > > - status =3D timeout; > > > > - } > > > > - > > > No, it is wrong. You need to update the status variable in the case o= f timeout. > >=20 > > Looking at the patch context, such code comes later. > But it causes regressions; without looking at the "later" code, we can't = afford merging > this code now. Later as in "a few lines later" not "some time later". Or am I missing something else? --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --C94crkcyjafcjHxo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlCkwWwACgkQD27XaX1/VRukewCdHgxxIEsKSngw5LopT7WAECRa CxwAn1GR0ahWKqSoV/fJeL4ncyKPFKf2 =/CFu -----END PGP SIGNATURE----- --C94crkcyjafcjHxo--