From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Shubhrajyoti Datta
<omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Wolfram Sang <wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] i2c: omap: don't save a value only needed for read-clearing
Date: Thu, 15 Nov 2012 14:51:46 +0200 [thread overview]
Message-ID: <20121115124956.GA7390@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAM=Q2cuRBK4SG9HfcV+L7Yfwv4kv8rTOXzrnUbjfE+-c7JNoNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Hi,
On Thu, Nov 15, 2012 at 03:34:10PM +0530, Shubhrajyoti Datta wrote:
> On Thu, Nov 15, 2012 at 12:20 AM, Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> >
> >> > This makes one of my code analyzers happy and makes me a part of the
> >>
> >> anything open source which we could all be using ? :-)
> >
> > 'my' as in 'one of those I am using'. It was cppcheck which found that
> > flaw. Its use for kernel code is limited, but it does find one or the
> > other thing.
>
> sparse did not complain though.
> So it seems it helps to run multiple static tools:-)
or sending a patch to sparse ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-11-15 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 17:21 [PATCH] i2c: omap: don't save a value only needed for read-clearing Wolfram Sang
[not found] ` <1352913666-11022-1-git-send-email-wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2012-11-14 18:37 ` Felipe Balbi
[not found] ` <20121114183739.GA30212-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-11-14 18:50 ` Wolfram Sang
[not found] ` <20121114185033.GB26955-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-15 10:04 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2cuRBK4SG9HfcV+L7Yfwv4kv8rTOXzrnUbjfE+-c7JNoNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-15 12:51 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115124956.GA7390@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=omaplinuxkernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=shubhrajyoti-l0cyMroinI0@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox