From: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Abhilash Kesavan
<kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume
Date: Fri, 16 Nov 2012 13:07:03 +0100 [thread overview]
Message-ID: <20121116120703.GH19028@pengutronix.de> (raw)
In-Reply-To: <20121116114617.GE19028-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Fri, Nov 16, 2012 at 12:46:17PM +0100, Wolfram Sang wrote:
> On Wed, Nov 14, 2012 at 09:10:33AM +0530, Abhilash Kesavan wrote:
> > Hi,
> >
> > Any comments on this fix ?
>
> Yes, I agree with Shubhrajyoti here and the code should be refactored so
> that gpio initialization is only done once at probe-time unless there is
> a real reason to do at suspend/resume.
Note that I just applied a few patches to s3c2410 also touching this
area. Would be nice if you could wait a bit until I pushed out my
for-next branch later today and base on that. Or wait for 3.8-rc1.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-11-16 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 6:10 [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume Abhilash Kesavan
[not found] ` <1352182259-28903-1-git-send-email-a.kesavan-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-11-06 6:12 ` Shubhrajyoti Datta
[not found] ` <CAM=Q2ctBMmg32-Dd6V5pwEEzxCnATs1se4RD_+zgLLOGohgSzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-06 7:38 ` Abhilash Kesavan
[not found] ` <CAM4voa=hnKR_ovUu_uzy8o5wQ2WXazKceLTWh=tj02YWRgRbYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-14 3:40 ` Abhilash Kesavan
[not found] ` <CAM4voa==f81W-pC80Q43NzvF6uXXVZmLH2_Ta4A3x3EuboQWVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-16 11:46 ` Wolfram Sang
[not found] ` <20121116114617.GE19028-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-16 12:07 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116120703.GH19028@pengutronix.de \
--to=w.sang-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=kesavan.abhilash-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).