From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: s3c2410: Add fix for i2c suspend/resume Date: Fri, 16 Nov 2012 13:07:03 +0100 Message-ID: <20121116120703.GH19028@pengutronix.de> References: <1352182259-28903-1-git-send-email-a.kesavan@samsung.com> <20121116114617.GE19028@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ISKrrfpKsPiF35CV" Return-path: Content-Disposition: inline In-Reply-To: <20121116114617.GE19028-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Abhilash Kesavan Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org List-Id: linux-i2c@vger.kernel.org --ISKrrfpKsPiF35CV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 16, 2012 at 12:46:17PM +0100, Wolfram Sang wrote: > On Wed, Nov 14, 2012 at 09:10:33AM +0530, Abhilash Kesavan wrote: > > Hi, > >=20 > > Any comments on this fix ? >=20 > Yes, I agree with Shubhrajyoti here and the code should be refactored so > that gpio initialization is only done once at probe-time unless there is > a real reason to do at suspend/resume. Note that I just applied a few patches to s3c2410 also touching this area. Would be nice if you could wait a bit until I pushed out my for-next branch later today and base on that. Or wait for 3.8-rc1. Thanks, Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --ISKrrfpKsPiF35CV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlCmLGcACgkQD27XaX1/VRv+owCeOVGnPDWTS5uNMu0Ej3rt0+Iu cjMAoLk8iyHlF8Pvw+k16uUwt53ftF2V =L+ix -----END PGP SIGNATURE----- --ISKrrfpKsPiF35CV--