linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Tim Michals <tcmichals-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH 2/2] i2c: mxs: Do not disable the I2C SMBus quick mode
Date: Mon, 19 Nov 2012 19:13:20 +0100	[thread overview]
Message-ID: <201211191913.20938.marex@denx.de> (raw)
In-Reply-To: <CANqk_c92YYzCKjT7ehfXpmGhJC8p0BDSNoW3vC71J9q89=XUaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Dear Tim Michals,

[...]

> > ~ # /i2cdetect.static -r 0 20 30
> > WARNING! This program can confuse your I2C bus, cause data loss and
> > worse! I will probe file /dev/i2c-0 using read byte commands.
> > I will probe address range 0x14-0x1e.
> > Continue? [Y/n]
> > 
> >      0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
> > 
> > 00:
> > 10:             -- -- -- -- -- -- -- -- -- -- --
> > 20:
> > 30:
> > 40:
> > 50:
> > 60:
> > 70:
> > 
> > Best regards,
> > Marek Vasut
> 
> I'm using a imx233, I don't know what would be different or cause this
> issue.

The register layout differs. You might want to check if all the register 
programing is correct. Make sure the placement of various bits is correct. Also 
see how the DMA operates with the transfer length on MX23 and MX28 ... there are 
quite a few differences and I didn't test the driver on MX23 like that. I recall 
someone testing it on a different MX23 board but only by some "standard" usage.

  parent reply	other threads:[~2012-11-19 18:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-18  5:25 [PATCH 1/2] i2c: mxs: Handle i2c DMA failure properly Marek Vasut
     [not found] ` <1353216308-7338-1-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-11-18  5:25   ` [PATCH 2/2] i2c: mxs: Do not disable the I2C SMBus quick mode Marek Vasut
     [not found]     ` <CANqk_c-3t2Kn3cQjwzoSzMrKMD-W_0JByD4U=Bp_ZA3_seyuig@mail.gmail.com>
     [not found]       ` <CANqk_c-3t2Kn3cQjwzoSzMrKMD-W_0JByD4U=Bp_ZA3_seyuig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-19 15:19         ` Marek Vasut
     [not found]           ` <CANqk_c92YYzCKjT7ehfXpmGhJC8p0BDSNoW3vC71J9q89=XUaQ@mail.gmail.com>
     [not found]             ` <CANqk_c92YYzCKjT7ehfXpmGhJC8p0BDSNoW3vC71J9q89=XUaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-19 18:13               ` Marek Vasut [this message]
     [not found]                 ` <CANqk_c9xk6mtiA5NpvoLy3bSdKPhF7yAUWfe_rRefZLMeOeHNQ@mail.gmail.com>
     [not found]                   ` <CANqk_c9xk6mtiA5NpvoLy3bSdKPhF7yAUWfe_rRefZLMeOeHNQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-19 20:02                     ` Marek Vasut
2012-11-20 11:36         ` Fabio Estevam
     [not found]     ` <1353216308-7338-2-git-send-email-marex-ynQEQJNshbs@public.gmane.org>
2012-11-22 22:05       ` Wolfram Sang
2012-11-19  9:25   ` [PATCH 1/2] i2c: mxs: Handle i2c DMA failure properly Wolfram Sang
     [not found]     ` <20121119092531.GE7775-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-19 14:00       ` Marek Vasut
     [not found]         ` <201211191500.32205.marex-ynQEQJNshbs@public.gmane.org>
2012-11-20  8:39           ` Wolfram Sang
     [not found]             ` <20121120083946.GB14722-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-11-20  8:47               ` Marek Vasut
     [not found]                 ` <201211200947.36430.marex-ynQEQJNshbs@public.gmane.org>
2012-11-20  8:54                   ` Wolfram Sang
2012-11-22 22:04   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211191913.20938.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tcmichals-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).