From: Samuel Ortiz <sameo@linux.intel.com>
To: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Cc: tony@atomide.com, khilman@deeprootsystems.com,
omaplinuxkernel@gmail.com, linux-i2c@vger.kernel.org,
w.sang@pengutronix.de, linux-omap@vger.kernel.org,
grygorii.strashko@ti.com, shubhrajyoti@ti.com, huzefank@ti.com,
nm@ti.com
Subject: Re: [PATCH 1/1] twl4030: Fix chained irq handling on resume from suspend
Date: Wed, 21 Nov 2012 17:47:29 +0100 [thread overview]
Message-ID: <20121121164729.GC18738@sortiz-mobl> (raw)
In-Reply-To: <1350399575-13240-1-git-send-email-kalle.jokiniemi@jollamobile.com>
Hi Kalle,
On Tue, Oct 16, 2012 at 05:59:35PM +0300, Kalle Jokiniemi wrote:
> The irqs are enabled one-by-one in pm core resume_noirq phase.
> This leads to situation where the twl4030 primary interrupt
> handler (PIH) is enabled before the chained secondary handlers
> (SIH). As the PIH cannot clear the pending interrupt, and
> SIHs have not been enabled yet, a flood of interrupts hangs
> the device.
>
> Fixed the issue by setting the SIH irqs with IRQF_EARLY_RESUME
> flags, so they get enabled before the PIH.
>
> Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
> ---
> drivers/mfd/twl4030-irq.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks, patch applied to my for-linus branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-11-21 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 14:59 [PATCH 1/1] twl4030: Fix chained irq handling on resume from suspend Kalle Jokiniemi
2012-10-16 15:04 ` Kalle Jokiniemi
2012-10-16 23:52 ` Kevin Hilman
2012-11-21 16:47 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121164729.GC18738@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=grygorii.strashko@ti.com \
--cc=huzefank@ti.com \
--cc=kalle.jokiniemi@jollamobile.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=omaplinuxkernel@gmail.com \
--cc=shubhrajyoti@ti.com \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).