From: Felipe Balbi <balbi@ti.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
balbi@ti.com, w.sang@pengutronix.de
Subject: Re: [PATCH] i2c: omap: Remove the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE flag
Date: Mon, 26 Nov 2012 11:14:00 +0200 [thread overview]
Message-ID: <20121126091400.GD15766@arwen.pp.htv.fi> (raw)
In-Reply-To: <1353921235-22408-1-git-send-email-shubhrajyoti@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Mon, Nov 26, 2012 at 02:43:55PM +0530, Shubhrajyoti D wrote:
> The OMAP_I2C_FLAG_RESET_REGS_POSTIDLE is not used anymore
> in the i2c driver. Remove the flag.
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> Has dependency on the below patch
> http://git.pengutronix.de/?p=wsa/linux.git;a=commitdiff;h=554c96744afd169886bd6fc2736fb0d9aaf634e8
>
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +--
> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 +--
> drivers/i2c/busses/i2c-omap.c | 3 +--
> 3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 943222c4..3dd9e69 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -791,8 +791,7 @@ static struct omap_hwmod omap3xxx_dss_venc_hwmod = {
> /* I2C1 */
> static struct omap_i2c_dev_attr i2c1_dev_attr = {
> .fifo_depth = 8, /* bytes */
> - .flags = OMAP_I2C_FLAG_RESET_REGS_POSTIDLE |
> - OMAP_I2C_FLAG_BUS_SHIFT_2,
> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_2,
if it's not used anymore, how about removing its definition too ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-26 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 9:13 [PATCH] i2c: omap: Remove the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE flag Shubhrajyoti D
2012-11-26 9:14 ` Felipe Balbi [this message]
2012-11-26 9:55 ` Shubhrajyoti Datta
2012-11-26 9:56 ` Shubhrajyoti Datta
-- strict thread matches above, loose matches on Subject: below --
2012-11-26 9:54 Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121126091400.GD15766@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox