* [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG @ 2012-11-27 20:59 Bill Pemberton 2012-11-27 20:59 ` [PATCH 05/16] i2c: i2c-cpm: remove __dev* attributes Bill Pemberton [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 0 siblings, 2 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r This is a respin of the patches to remove the __dev* attributes in the i2c subsystem. The attributes __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit are no longer needed since CONFIG_HOTPLUG is being removed as an option. Bill Pemberton (16): i2c/busses: remove __dev* attributes i2c: mux-gpio: remove __dev* attributes i2c: pnx: remove __dev* attributes i2c: scx200_acb: remove __dev* attributes i2c: i2c-cpm: remove __dev* attributes i2c: i2c-gpio: remove __dev* attributes i2c: i2c-parport-light: remove __dev* attributes i2c: ocores: remove __dev* attributes i2c: omap: remove __dev* attributes i2c: pca: remove __dev* attributes i2c: puv3: remove __dev* attributes i2c: i2c-pasemi: remove __dev* attributes i2c: sirf: remove __dev* attributes i2c-ali1563: remove __dev* attributes i2c-sis96x: remove __dev* attributes i2c: SMBus: remove __dev* attributes drivers/i2c/busses/i2c-ali1535.c | 8 +++--- drivers/i2c/busses/i2c-ali1563.c | 8 +++--- drivers/i2c/busses/i2c-ali15x3.c | 8 +++--- drivers/i2c/busses/i2c-amd756.c | 6 ++--- drivers/i2c/busses/i2c-amd8111.c | 6 ++--- drivers/i2c/busses/i2c-at91.c | 14 +++++------ drivers/i2c/busses/i2c-au1550.c | 6 ++--- drivers/i2c/busses/i2c-cpm.c | 8 +++--- drivers/i2c/busses/i2c-designware-pcidrv.c | 6 ++--- drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++--- drivers/i2c/busses/i2c-eg20t.c | 6 ++--- drivers/i2c/busses/i2c-elektor.c | 8 +++--- drivers/i2c/busses/i2c-gpio.c | 8 +++--- drivers/i2c/busses/i2c-highlander.c | 6 ++--- drivers/i2c/busses/i2c-hydra.c | 6 ++--- drivers/i2c/busses/i2c-i801.c | 24 +++++++++--------- drivers/i2c/busses/i2c-ibm_iic.c | 8 +++--- drivers/i2c/busses/i2c-intel-mid.c | 6 ++--- drivers/i2c/busses/i2c-isch.c | 6 ++--- drivers/i2c/busses/i2c-mpc.c | 38 ++++++++++++++--------------- drivers/i2c/busses/i2c-mv64xxx.c | 18 +++++++------- drivers/i2c/busses/i2c-mxs.c | 6 ++--- drivers/i2c/busses/i2c-nforce2.c | 10 ++++---- drivers/i2c/busses/i2c-nuc900.c | 6 ++--- drivers/i2c/busses/i2c-ocores.c | 6 ++--- drivers/i2c/busses/i2c-octeon.c | 10 ++++---- drivers/i2c/busses/i2c-omap.c | 6 ++--- drivers/i2c/busses/i2c-parport-light.c | 6 ++--- drivers/i2c/busses/i2c-pasemi.c | 6 ++--- drivers/i2c/busses/i2c-pca-isa.c | 8 +++--- drivers/i2c/busses/i2c-pca-platform.c | 6 ++--- drivers/i2c/busses/i2c-piix4.c | 20 +++++++-------- drivers/i2c/busses/i2c-pmcmsp.c | 6 ++--- drivers/i2c/busses/i2c-pnx.c | 6 ++--- drivers/i2c/busses/i2c-powermac.c | 16 ++++++------ drivers/i2c/busses/i2c-puv3.c | 6 ++--- drivers/i2c/busses/i2c-pxa-pci.c | 6 ++--- drivers/i2c/busses/i2c-rcar.c | 6 ++--- drivers/i2c/busses/i2c-s6000.c | 8 +++--- drivers/i2c/busses/i2c-sh7760.c | 8 +++--- drivers/i2c/busses/i2c-sh_mobile.c | 2 +- drivers/i2c/busses/i2c-sirf.c | 8 +++--- drivers/i2c/busses/i2c-sis5595.c | 4 +-- drivers/i2c/busses/i2c-sis630.c | 8 +++--- drivers/i2c/busses/i2c-sis96x.c | 6 ++--- drivers/i2c/busses/i2c-tegra.c | 8 +++--- drivers/i2c/busses/i2c-via.c | 6 ++--- drivers/i2c/busses/i2c-viapro.c | 2 +- drivers/i2c/busses/i2c-viperboard.c | 6 ++--- drivers/i2c/busses/i2c-xiic.c | 8 +++--- drivers/i2c/busses/i2c-xlr.c | 6 ++--- drivers/i2c/busses/scx200_acb.c | 16 ++++++------ drivers/i2c/muxes/i2c-mux-gpio.c | 14 +++++------ drivers/i2c/muxes/i2c-mux-pinctrl.c | 8 +++--- 54 files changed, 232 insertions(+), 232 deletions(-) -- 1.8.0.1 ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 05/16] i2c: i2c-cpm: remove __dev* attributes 2012-11-27 20:59 [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 1 sibling, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c; +Cc: gregkh, linuxppc-dev CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Cc: Jochen Friedrich <jochen@scram.de> Cc: linuxppc-dev@lists.ozlabs.org --- drivers/i2c/busses/i2c-cpm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index c1e1096..2e79c10 100644 --- a/drivers/i2c/busses/i2c-cpm.c +++ b/drivers/i2c/busses/i2c-cpm.c @@ -426,7 +426,7 @@ static const struct i2c_adapter cpm_ops = { .algo = &cpm_i2c_algo, }; -static int __devinit cpm_i2c_setup(struct cpm_i2c *cpm) +static int cpm_i2c_setup(struct cpm_i2c *cpm) { struct platform_device *ofdev = cpm->ofdev; const u32 *data; @@ -634,7 +634,7 @@ static void cpm_i2c_shutdown(struct cpm_i2c *cpm) cpm_muram_free(cpm->i2c_addr); } -static int __devinit cpm_i2c_probe(struct platform_device *ofdev) +static int cpm_i2c_probe(struct platform_device *ofdev) { int result, len; struct cpm_i2c *cpm; @@ -688,7 +688,7 @@ out_free: return result; } -static int __devexit cpm_i2c_remove(struct platform_device *ofdev) +static int cpm_i2c_remove(struct platform_device *ofdev) { struct cpm_i2c *cpm = dev_get_drvdata(&ofdev->dev); @@ -716,7 +716,7 @@ MODULE_DEVICE_TABLE(of, cpm_i2c_match); static struct platform_driver cpm_i2c_driver = { .probe = cpm_i2c_probe, - .remove = __devexit_p(cpm_i2c_remove), + .remove = cpm_i2c_remove, .driver = { .name = "fsl-i2c-cpm", .owner = THIS_MODULE, -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* [PATCH 01/16] i2c/busses: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 02/16] i2c: mux-gpio: " Bill Pemberton ` (14 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> --- drivers/i2c/busses/i2c-at91.c | 14 +++++------ drivers/i2c/busses/i2c-au1550.c | 6 ++--- drivers/i2c/busses/i2c-designware-pcidrv.c | 6 ++--- drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++--- drivers/i2c/busses/i2c-eg20t.c | 6 ++--- drivers/i2c/busses/i2c-elektor.c | 8 +++--- drivers/i2c/busses/i2c-highlander.c | 6 ++--- drivers/i2c/busses/i2c-hydra.c | 6 ++--- drivers/i2c/busses/i2c-ibm_iic.c | 8 +++--- drivers/i2c/busses/i2c-intel-mid.c | 6 ++--- drivers/i2c/busses/i2c-mpc.c | 38 ++++++++++++++--------------- drivers/i2c/busses/i2c-mv64xxx.c | 18 +++++++------- drivers/i2c/busses/i2c-mxs.c | 6 ++--- drivers/i2c/busses/i2c-nuc900.c | 6 ++--- drivers/i2c/busses/i2c-octeon.c | 10 ++++---- drivers/i2c/busses/i2c-pmcmsp.c | 6 ++--- drivers/i2c/busses/i2c-powermac.c | 16 ++++++------ drivers/i2c/busses/i2c-pxa-pci.c | 6 ++--- drivers/i2c/busses/i2c-rcar.c | 6 ++--- drivers/i2c/busses/i2c-s6000.c | 8 +++--- drivers/i2c/busses/i2c-sh7760.c | 8 +++--- drivers/i2c/busses/i2c-sh_mobile.c | 2 +- drivers/i2c/busses/i2c-tegra.c | 8 +++--- drivers/i2c/busses/i2c-viperboard.c | 6 ++--- drivers/i2c/busses/i2c-xiic.c | 8 +++--- drivers/i2c/busses/i2c-xlr.c | 6 ++--- drivers/i2c/muxes/i2c-mux-pinctrl.c | 8 +++--- 27 files changed, 119 insertions(+), 119 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index b4575ee..6d65d9c 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/drivers/i2c/busses/i2c-at91.c @@ -145,7 +145,7 @@ static void at91_init_twi_bus(struct at91_twi_dev *dev) * Calculate symmetric clock as stated in datasheet: * twi_clk = F_MAIN / (2 * (cdiv * (1 << ckdiv) + offset)) */ -static void __devinit at91_calc_twi_clock(struct at91_twi_dev *dev, int twi_clk) +static void at91_calc_twi_clock(struct at91_twi_dev *dev, int twi_clk) { int ckdiv, cdiv, div; struct at91_twi_pdata *pdata = dev->pdata; @@ -604,7 +604,7 @@ MODULE_DEVICE_TABLE(of, atmel_twi_dt_ids); #define atmel_twi_dt_ids NULL #endif -static bool __devinit filter(struct dma_chan *chan, void *slave) +static bool filter(struct dma_chan *chan, void *slave) { struct at_dma_slave *sl = slave; @@ -616,7 +616,7 @@ static bool __devinit filter(struct dma_chan *chan, void *slave) } } -static int __devinit at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr) +static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr) { int ret = 0; struct at_dma_slave *sdata; @@ -688,7 +688,7 @@ error: return ret; } -static struct at91_twi_pdata * __devinit at91_twi_get_driver_data( +static struct at91_twi_pdata * at91_twi_get_driver_data( struct platform_device *pdev) { if (pdev->dev.of_node) { @@ -701,7 +701,7 @@ static struct at91_twi_pdata * __devinit at91_twi_get_driver_data( return (struct at91_twi_pdata *) platform_get_device_id(pdev)->driver_data; } -static int __devinit at91_twi_probe(struct platform_device *pdev) +static int at91_twi_probe(struct platform_device *pdev) { struct at91_twi_dev *dev; struct resource *mem; @@ -779,7 +779,7 @@ static int __devinit at91_twi_probe(struct platform_device *pdev) return 0; } -static int __devexit at91_twi_remove(struct platform_device *pdev) +static int at91_twi_remove(struct platform_device *pdev) { struct at91_twi_dev *dev = platform_get_drvdata(pdev); int rc; @@ -820,7 +820,7 @@ static const struct dev_pm_ops at91_twi_pm = { static struct platform_driver at91_twi_driver = { .probe = at91_twi_probe, - .remove = __devexit_p(at91_twi_remove), + .remove = at91_twi_remove, .id_table = at91_twi_devtypes, .driver = { .name = "at91_i2c", diff --git a/drivers/i2c/busses/i2c-au1550.c b/drivers/i2c/busses/i2c-au1550.c index 582d616..b278298 100644 --- a/drivers/i2c/busses/i2c-au1550.c +++ b/drivers/i2c/busses/i2c-au1550.c @@ -313,7 +313,7 @@ static void i2c_au1550_disable(struct i2c_au1550_data *priv) * Prior to calling us, the 50MHz clock frequency and routing * must have been set up for the PSC indicated by the adapter. */ -static int __devinit +static int i2c_au1550_probe(struct platform_device *pdev) { struct i2c_au1550_data *priv; @@ -372,7 +372,7 @@ out: return ret; } -static int __devexit i2c_au1550_remove(struct platform_device *pdev) +static int i2c_au1550_remove(struct platform_device *pdev) { struct i2c_au1550_data *priv = platform_get_drvdata(pdev); @@ -423,7 +423,7 @@ static struct platform_driver au1xpsc_smbus_driver = { .pm = AU1XPSC_SMBUS_PMOPS, }, .probe = i2c_au1550_probe, - .remove = __devexit_p(i2c_au1550_remove), + .remove = i2c_au1550_remove, }; module_platform_driver(au1xpsc_smbus_driver); diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 92a1e2c..6add851 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -207,7 +207,7 @@ static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev) return dev->controller->clk_khz; } -static int __devinit i2c_dw_pci_probe(struct pci_dev *pdev, +static int i2c_dw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { struct dw_i2c_dev *dev; @@ -328,7 +328,7 @@ exit: return r; } -static void __devexit i2c_dw_pci_remove(struct pci_dev *pdev) +static void i2c_dw_pci_remove(struct pci_dev *pdev) { struct dw_i2c_dev *dev = pci_get_drvdata(pdev); @@ -368,7 +368,7 @@ static struct pci_driver dw_i2c_driver = { .name = DRIVER_NAME, .id_table = i2_designware_pci_ids, .probe = i2c_dw_pci_probe, - .remove = __devexit_p(i2c_dw_pci_remove), + .remove = i2c_dw_pci_remove, .driver = { .pm = &i2c_dw_pm_ops, }, diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 0506fef..343357a 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -50,7 +50,7 @@ static u32 i2c_dw_get_clk_rate_khz(struct dw_i2c_dev *dev) return clk_get_rate(dev->clk)/1000; } -static int __devinit dw_i2c_probe(struct platform_device *pdev) +static int dw_i2c_probe(struct platform_device *pdev) { struct dw_i2c_dev *dev; struct i2c_adapter *adap; @@ -169,7 +169,7 @@ err_release_region: return r; } -static int __devexit dw_i2c_remove(struct platform_device *pdev) +static int dw_i2c_remove(struct platform_device *pdev) { struct dw_i2c_dev *dev = platform_get_drvdata(pdev); struct resource *mem; @@ -228,7 +228,7 @@ static SIMPLE_DEV_PM_OPS(dw_i2c_dev_pm_ops, dw_i2c_suspend, dw_i2c_resume); MODULE_ALIAS("platform:i2c_designware"); static struct platform_driver dw_i2c_driver = { - .remove = __devexit_p(dw_i2c_remove), + .remove = dw_i2c_remove, .driver = { .name = "i2c_designware", .owner = THIS_MODULE, diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index 259f769..5e7886e7 100644 --- a/drivers/i2c/busses/i2c-eg20t.c +++ b/drivers/i2c/busses/i2c-eg20t.c @@ -758,7 +758,7 @@ static void pch_i2c_disbl_int(struct i2c_algo_pch_data *adap) iowrite32(BUFFER_MODE_INTR_DISBL, p + PCH_I2CBUFMSK); } -static int __devinit pch_i2c_probe(struct pci_dev *pdev, +static int pch_i2c_probe(struct pci_dev *pdev, const struct pci_device_id *id) { void __iomem *base_addr; @@ -851,7 +851,7 @@ err_pci_enable: return ret; } -static void __devexit pch_i2c_remove(struct pci_dev *pdev) +static void pch_i2c_remove(struct pci_dev *pdev) { int i; struct adapter_info *adap_info = pci_get_drvdata(pdev); @@ -948,7 +948,7 @@ static struct pci_driver pch_pcidriver = { .name = KBUILD_MODNAME, .id_table = pch_pcidev_id, .probe = pch_i2c_probe, - .remove = __devexit_p(pch_i2c_remove), + .remove = pch_i2c_remove, .suspend = pch_i2c_suspend, .resume = pch_i2c_resume }; diff --git a/drivers/i2c/busses/i2c-elektor.c b/drivers/i2c/busses/i2c-elektor.c index 37e2e82..4854970 100644 --- a/drivers/i2c/busses/i2c-elektor.c +++ b/drivers/i2c/busses/i2c-elektor.c @@ -205,7 +205,7 @@ static struct i2c_adapter pcf_isa_ops = { .name = "i2c-elektor", }; -static int __devinit elektor_match(struct device *dev, unsigned int id) +static int elektor_match(struct device *dev, unsigned int id) { #ifdef __alpha__ /* check to see we have memory mapped PCF8584 connected to the @@ -264,7 +264,7 @@ static int __devinit elektor_match(struct device *dev, unsigned int id) return 1; } -static int __devinit elektor_probe(struct device *dev, unsigned int id) +static int elektor_probe(struct device *dev, unsigned int id) { init_waitqueue_head(&pcf_wait); if (pcf_isa_init()) @@ -293,7 +293,7 @@ static int __devinit elektor_probe(struct device *dev, unsigned int id) return -ENODEV; } -static int __devexit elektor_remove(struct device *dev, unsigned int id) +static int elektor_remove(struct device *dev, unsigned int id) { i2c_del_adapter(&pcf_isa_ops); @@ -316,7 +316,7 @@ static int __devexit elektor_remove(struct device *dev, unsigned int id) static struct isa_driver i2c_elektor_driver = { .match = elektor_match, .probe = elektor_probe, - .remove = __devexit_p(elektor_remove), + .remove = elektor_remove, .driver = { .owner = THIS_MODULE, .name = "i2c-elektor", diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c index 19515df..3351cc7 100644 --- a/drivers/i2c/busses/i2c-highlander.c +++ b/drivers/i2c/busses/i2c-highlander.c @@ -356,7 +356,7 @@ static const struct i2c_algorithm highlander_i2c_algo = { .functionality = highlander_i2c_func, }; -static int __devinit highlander_i2c_probe(struct platform_device *pdev) +static int highlander_i2c_probe(struct platform_device *pdev) { struct highlander_i2c_dev *dev; struct i2c_adapter *adap; @@ -441,7 +441,7 @@ err: return ret; } -static int __devexit highlander_i2c_remove(struct platform_device *pdev) +static int highlander_i2c_remove(struct platform_device *pdev) { struct highlander_i2c_dev *dev = platform_get_drvdata(pdev); @@ -465,7 +465,7 @@ static struct platform_driver highlander_i2c_driver = { }, .probe = highlander_i2c_probe, - .remove = __devexit_p(highlander_i2c_remove), + .remove = highlander_i2c_remove, }; module_platform_driver(highlander_i2c_driver); diff --git a/drivers/i2c/busses/i2c-hydra.c b/drivers/i2c/busses/i2c-hydra.c index c9f95e1..79c3d90 100644 --- a/drivers/i2c/busses/i2c-hydra.c +++ b/drivers/i2c/busses/i2c-hydra.c @@ -112,7 +112,7 @@ static DEFINE_PCI_DEVICE_TABLE(hydra_ids) = { MODULE_DEVICE_TABLE (pci, hydra_ids); -static int __devinit hydra_probe(struct pci_dev *dev, +static int hydra_probe(struct pci_dev *dev, const struct pci_device_id *id) { unsigned long base = pci_resource_start(dev, 0); @@ -139,7 +139,7 @@ static int __devinit hydra_probe(struct pci_dev *dev, return 0; } -static void __devexit hydra_remove(struct pci_dev *dev) +static void hydra_remove(struct pci_dev *dev) { pdregw(hydra_bit_data.data, 0); /* clear SCLK_OE and SDAT_OE */ i2c_del_adapter(&hydra_adap); @@ -153,7 +153,7 @@ static struct pci_driver hydra_driver = { .name = "hydra_smbus", .id_table = hydra_ids, .probe = hydra_probe, - .remove = __devexit_p(hydra_remove), + .remove = hydra_remove, }; module_pci_driver(hydra_driver); diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c index 806e225..33a2abb 100644 --- a/drivers/i2c/busses/i2c-ibm_iic.c +++ b/drivers/i2c/busses/i2c-ibm_iic.c @@ -660,7 +660,7 @@ static inline u8 iic_clckdiv(unsigned int opb) return (u8)((opb + 9) / 10 - 1); } -static int __devinit iic_request_irq(struct platform_device *ofdev, +static int iic_request_irq(struct platform_device *ofdev, struct ibm_iic_private *dev) { struct device_node *np = ofdev->dev.of_node; @@ -691,7 +691,7 @@ static int __devinit iic_request_irq(struct platform_device *ofdev, /* * Register single IIC interface */ -static int __devinit iic_probe(struct platform_device *ofdev) +static int iic_probe(struct platform_device *ofdev) { struct device_node *np = ofdev->dev.of_node; struct ibm_iic_private *dev; @@ -781,7 +781,7 @@ error_cleanup: /* * Cleanup initialized IIC interface */ -static int __devexit iic_remove(struct platform_device *ofdev) +static int iic_remove(struct platform_device *ofdev) { struct ibm_iic_private *dev = dev_get_drvdata(&ofdev->dev); @@ -812,7 +812,7 @@ static struct platform_driver ibm_iic_driver = { .of_match_table = ibm_iic_match, }, .probe = iic_probe, - .remove = __devexit_p(iic_remove), + .remove = iic_remove, }; module_platform_driver(ibm_iic_driver); diff --git a/drivers/i2c/busses/i2c-intel-mid.c b/drivers/i2c/busses/i2c-intel-mid.c index 7c28f10..de3736b 100644 --- a/drivers/i2c/busses/i2c-intel-mid.c +++ b/drivers/i2c/busses/i2c-intel-mid.c @@ -947,7 +947,7 @@ static const struct dev_pm_ops intel_mid_i2c_pm_ops = { * 5. Call intel_mid_i2c_hwinit() for hardware initialization * 6. Register I2C adapter in i2c-core */ -static int __devinit intel_mid_i2c_probe(struct pci_dev *dev, +static int intel_mid_i2c_probe(struct pci_dev *dev, const struct pci_device_id *id) { struct intel_mid_i2c_private *mrst; @@ -1079,7 +1079,7 @@ exit: return err; } -static void __devexit intel_mid_i2c_remove(struct pci_dev *dev) +static void intel_mid_i2c_remove(struct pci_dev *dev) { struct intel_mid_i2c_private *mrst = pci_get_drvdata(dev); intel_mid_i2c_disable(&mrst->adap); @@ -1113,7 +1113,7 @@ static struct pci_driver intel_mid_i2c_driver = { .name = DRIVER_NAME, .id_table = intel_mid_i2c_ids, .probe = intel_mid_i2c_probe, - .remove = __devexit_p(intel_mid_i2c_remove), + .remove = intel_mid_i2c_remove, }; module_pci_driver(intel_mid_i2c_driver); diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index ca86430..a69459e 100644 --- a/drivers/i2c/busses/i2c-mpc.c +++ b/drivers/i2c/busses/i2c-mpc.c @@ -175,7 +175,7 @@ static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing) } #if defined(CONFIG_PPC_MPC52xx) || defined(CONFIG_PPC_MPC512x) -static const struct mpc_i2c_divider mpc_i2c_dividers_52xx[] __devinitconst = { +static const struct mpc_i2c_divider mpc_i2c_dividers_52xx[] = { {20, 0x20}, {22, 0x21}, {24, 0x22}, {26, 0x23}, {28, 0x24}, {30, 0x01}, {32, 0x25}, {34, 0x02}, {36, 0x26}, {40, 0x27}, {44, 0x04}, {48, 0x28}, @@ -196,7 +196,7 @@ static const struct mpc_i2c_divider mpc_i2c_dividers_52xx[] __devinitconst = { {10240, 0x9d}, {12288, 0x9e}, {15360, 0x9f} }; -static int __devinit mpc_i2c_get_fdr_52xx(struct device_node *node, u32 clock, +static int mpc_i2c_get_fdr_52xx(struct device_node *node, u32 clock, int prescaler, u32 *real_clk) { const struct mpc_i2c_divider *div = NULL; @@ -230,7 +230,7 @@ static int __devinit mpc_i2c_get_fdr_52xx(struct device_node *node, u32 clock, return (int)div->fdr; } -static void __devinit mpc_i2c_setup_52xx(struct device_node *node, +static void mpc_i2c_setup_52xx(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -252,7 +252,7 @@ static void __devinit mpc_i2c_setup_52xx(struct device_node *node, fdr); } #else /* !(CONFIG_PPC_MPC52xx || CONFIG_PPC_MPC512x) */ -static void __devinit mpc_i2c_setup_52xx(struct device_node *node, +static void mpc_i2c_setup_52xx(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -260,7 +260,7 @@ static void __devinit mpc_i2c_setup_52xx(struct device_node *node, #endif /* CONFIG_PPC_MPC52xx || CONFIG_PPC_MPC512x */ #ifdef CONFIG_PPC_MPC512x -static void __devinit mpc_i2c_setup_512x(struct device_node *node, +static void mpc_i2c_setup_512x(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -288,7 +288,7 @@ static void __devinit mpc_i2c_setup_512x(struct device_node *node, mpc_i2c_setup_52xx(node, i2c, clock, prescaler); } #else /* CONFIG_PPC_MPC512x */ -static void __devinit mpc_i2c_setup_512x(struct device_node *node, +static void mpc_i2c_setup_512x(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -296,7 +296,7 @@ static void __devinit mpc_i2c_setup_512x(struct device_node *node, #endif /* CONFIG_PPC_MPC512x */ #ifdef CONFIG_FSL_SOC -static const struct mpc_i2c_divider mpc_i2c_dividers_8xxx[] __devinitconst = { +static const struct mpc_i2c_divider mpc_i2c_dividers_8xxx[] = { {160, 0x0120}, {192, 0x0121}, {224, 0x0122}, {256, 0x0123}, {288, 0x0100}, {320, 0x0101}, {352, 0x0601}, {384, 0x0102}, {416, 0x0602}, {448, 0x0126}, {480, 0x0103}, {512, 0x0127}, @@ -316,7 +316,7 @@ static const struct mpc_i2c_divider mpc_i2c_dividers_8xxx[] __devinitconst = { {49152, 0x011e}, {61440, 0x011f} }; -static u32 __devinit mpc_i2c_get_sec_cfg_8xxx(void) +static u32 mpc_i2c_get_sec_cfg_8xxx(void) { struct device_node *node = NULL; u32 __iomem *reg; @@ -345,7 +345,7 @@ static u32 __devinit mpc_i2c_get_sec_cfg_8xxx(void) return val; } -static int __devinit mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock, +static int mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock, u32 prescaler, u32 *real_clk) { const struct mpc_i2c_divider *div = NULL; @@ -383,7 +383,7 @@ static int __devinit mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock, return div ? (int)div->fdr : -EINVAL; } -static void __devinit mpc_i2c_setup_8xxx(struct device_node *node, +static void mpc_i2c_setup_8xxx(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -408,7 +408,7 @@ static void __devinit mpc_i2c_setup_8xxx(struct device_node *node, } #else /* !CONFIG_FSL_SOC */ -static void __devinit mpc_i2c_setup_8xxx(struct device_node *node, +static void mpc_i2c_setup_8xxx(struct device_node *node, struct mpc_i2c *i2c, u32 clock, u32 prescaler) { @@ -615,7 +615,7 @@ static struct i2c_adapter mpc_ops = { }; static const struct of_device_id mpc_i2c_of_match[]; -static int __devinit fsl_i2c_probe(struct platform_device *op) +static int fsl_i2c_probe(struct platform_device *op) { const struct of_device_id *match; struct mpc_i2c *i2c; @@ -706,7 +706,7 @@ static int __devinit fsl_i2c_probe(struct platform_device *op) return result; }; -static int __devexit fsl_i2c_remove(struct platform_device *op) +static int fsl_i2c_remove(struct platform_device *op) { struct mpc_i2c *i2c = dev_get_drvdata(&op->dev); @@ -746,24 +746,24 @@ static int mpc_i2c_resume(struct device *dev) SIMPLE_DEV_PM_OPS(mpc_i2c_pm_ops, mpc_i2c_suspend, mpc_i2c_resume); #endif -static const struct mpc_i2c_data mpc_i2c_data_512x __devinitdata = { +static const struct mpc_i2c_data mpc_i2c_data_512x = { .setup = mpc_i2c_setup_512x, }; -static const struct mpc_i2c_data mpc_i2c_data_52xx __devinitdata = { +static const struct mpc_i2c_data mpc_i2c_data_52xx = { .setup = mpc_i2c_setup_52xx, }; -static const struct mpc_i2c_data mpc_i2c_data_8313 __devinitdata = { +static const struct mpc_i2c_data mpc_i2c_data_8313 = { .setup = mpc_i2c_setup_8xxx, }; -static const struct mpc_i2c_data mpc_i2c_data_8543 __devinitdata = { +static const struct mpc_i2c_data mpc_i2c_data_8543 = { .setup = mpc_i2c_setup_8xxx, .prescaler = 2, }; -static const struct mpc_i2c_data mpc_i2c_data_8544 __devinitdata = { +static const struct mpc_i2c_data mpc_i2c_data_8544 = { .setup = mpc_i2c_setup_8xxx, .prescaler = 3, }; @@ -785,7 +785,7 @@ MODULE_DEVICE_TABLE(of, mpc_i2c_of_match); /* Structure for a device driver */ static struct platform_driver mpc_i2c_driver = { .probe = fsl_i2c_probe, - .remove = __devexit_p(fsl_i2c_remove), + .remove = fsl_i2c_remove, .driver = { .owner = THIS_MODULE, .name = DRV_NAME, diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c index 2e9d567..8b20ef8 100644 --- a/drivers/i2c/busses/i2c-mv64xxx.c +++ b/drivers/i2c/busses/i2c-mv64xxx.c @@ -495,7 +495,7 @@ static const struct i2c_algorithm mv64xxx_i2c_algo = { * ***************************************************************************** */ -static int __devinit +static int mv64xxx_i2c_map_regs(struct platform_device *pd, struct mv64xxx_i2c_data *drv_data) { @@ -530,13 +530,13 @@ mv64xxx_i2c_unmap_regs(struct mv64xxx_i2c_data *drv_data) } #ifdef CONFIG_OF -static int __devinit +static int mv64xxx_calc_freq(const int tclk, const int n, const int m) { return tclk / (10 * (m + 1) * (2 << n)); } -static bool __devinit +static bool mv64xxx_find_baud_factors(const u32 req_freq, const u32 tclk, u32 *best_n, u32 *best_m) { @@ -560,7 +560,7 @@ mv64xxx_find_baud_factors(const u32 req_freq, const u32 tclk, u32 *best_n, return true; } -static int __devinit +static int mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data, struct device_node *np) { @@ -597,7 +597,7 @@ out: #endif } #else /* CONFIG_OF */ -static int __devinit +static int mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data, struct device_node *np) { @@ -605,7 +605,7 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data, } #endif /* CONFIG_OF */ -static int __devinit +static int mv64xxx_i2c_probe(struct platform_device *pd) { struct mv64xxx_i2c_data *drv_data; @@ -697,7 +697,7 @@ mv64xxx_i2c_probe(struct platform_device *pd) return rc; } -static int __devexit +static int mv64xxx_i2c_remove(struct platform_device *dev) { struct mv64xxx_i2c_data *drv_data = platform_get_drvdata(dev); @@ -718,7 +718,7 @@ mv64xxx_i2c_remove(struct platform_device *dev) return rc; } -static const struct of_device_id mv64xxx_i2c_of_match_table[] __devinitdata = { +static const struct of_device_id mv64xxx_i2c_of_match_table[] = { { .compatible = "marvell,mv64xxx-i2c", }, {} }; @@ -726,7 +726,7 @@ MODULE_DEVICE_TABLE(of, mv64xxx_i2c_of_match_table); static struct platform_driver mv64xxx_i2c_driver = { .probe = mv64xxx_i2c_probe, - .remove = __devexit_p(mv64xxx_i2c_remove), + .remove = mv64xxx_i2c_remove, .driver = { .owner = THIS_MODULE, .name = MV64XXX_I2C_CTLR_NAME, diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index 6ed53da..1b1a936 100644 --- a/drivers/i2c/busses/i2c-mxs.c +++ b/drivers/i2c/busses/i2c-mxs.c @@ -432,7 +432,7 @@ static int mxs_i2c_get_ofdata(struct mxs_i2c_dev *i2c) return 0; } -static int __devinit mxs_i2c_probe(struct platform_device *pdev) +static int mxs_i2c_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct mxs_i2c_dev *i2c; @@ -515,7 +515,7 @@ static int __devinit mxs_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit mxs_i2c_remove(struct platform_device *pdev) +static int mxs_i2c_remove(struct platform_device *pdev) { struct mxs_i2c_dev *i2c = platform_get_drvdata(pdev); int ret; @@ -546,7 +546,7 @@ static struct platform_driver mxs_i2c_driver = { .owner = THIS_MODULE, .of_match_table = mxs_i2c_dt_ids, }, - .remove = __devexit_p(mxs_i2c_remove), + .remove = mxs_i2c_remove, }; static int __init mxs_i2c_init(void) diff --git a/drivers/i2c/busses/i2c-nuc900.c b/drivers/i2c/busses/i2c-nuc900.c index a23b91b..865ee35 100644 --- a/drivers/i2c/busses/i2c-nuc900.c +++ b/drivers/i2c/busses/i2c-nuc900.c @@ -518,7 +518,7 @@ static const struct i2c_algorithm nuc900_i2c_algorithm = { * called by the bus driver when a suitable device is found */ -static int __devinit nuc900_i2c_probe(struct platform_device *pdev) +static int nuc900_i2c_probe(struct platform_device *pdev) { struct nuc900_i2c *i2c; struct nuc900_platform_i2c *pdata; @@ -663,7 +663,7 @@ static int __devinit nuc900_i2c_probe(struct platform_device *pdev) * called when device is removed from the bus */ -static int __devexit nuc900_i2c_remove(struct platform_device *pdev) +static int nuc900_i2c_remove(struct platform_device *pdev) { struct nuc900_i2c *i2c = platform_get_drvdata(pdev); @@ -684,7 +684,7 @@ static int __devexit nuc900_i2c_remove(struct platform_device *pdev) static struct platform_driver nuc900_i2c_driver = { .probe = nuc900_i2c_probe, - .remove = __devexit_p(nuc900_i2c_remove), + .remove = nuc900_i2c_remove, .driver = { .owner = THIS_MODULE, .name = "nuc900-i2c0", diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c index f44c835..484ca77 100644 --- a/drivers/i2c/busses/i2c-octeon.c +++ b/drivers/i2c/busses/i2c-octeon.c @@ -446,7 +446,7 @@ static struct i2c_adapter octeon_i2c_ops = { /** * octeon_i2c_setclock - Calculate and set clock divisors. */ -static int __devinit octeon_i2c_setclock(struct octeon_i2c *i2c) +static int octeon_i2c_setclock(struct octeon_i2c *i2c) { int tclk, thp_base, inc, thp_idx, mdiv_idx, ndiv_idx, foscl, diff; int thp = 0x18, mdiv = 2, ndiv = 0, delta_hz = 1000000; @@ -489,7 +489,7 @@ static int __devinit octeon_i2c_setclock(struct octeon_i2c *i2c) return 0; } -static int __devinit octeon_i2c_initlowlevel(struct octeon_i2c *i2c) +static int octeon_i2c_initlowlevel(struct octeon_i2c *i2c) { u8 status; int tries; @@ -510,7 +510,7 @@ static int __devinit octeon_i2c_initlowlevel(struct octeon_i2c *i2c) return -EIO; } -static int __devinit octeon_i2c_probe(struct platform_device *pdev) +static int octeon_i2c_probe(struct platform_device *pdev) { int irq, result = 0; struct octeon_i2c *i2c; @@ -609,7 +609,7 @@ out: return result; }; -static int __devexit octeon_i2c_remove(struct platform_device *pdev) +static int octeon_i2c_remove(struct platform_device *pdev) { struct octeon_i2c *i2c = platform_get_drvdata(pdev); @@ -628,7 +628,7 @@ MODULE_DEVICE_TABLE(of, octeon_i2c_match); static struct platform_driver octeon_i2c_driver = { .probe = octeon_i2c_probe, - .remove = __devexit_p(octeon_i2c_remove), + .remove = octeon_i2c_remove, .driver = { .owner = THIS_MODULE, .name = DRV_NAME, diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 3d71395..083d68c 100644 --- a/drivers/i2c/busses/i2c-pmcmsp.c +++ b/drivers/i2c/busses/i2c-pmcmsp.c @@ -270,7 +270,7 @@ static irqreturn_t pmcmsptwi_interrupt(int irq, void *ptr) /* * Probe for and register the device and return 0 if there is one. */ -static int __devinit pmcmsptwi_probe(struct platform_device *pldev) +static int pmcmsptwi_probe(struct platform_device *pldev) { struct resource *res; int rc = -ENODEV; @@ -368,7 +368,7 @@ ret_err: /* * Release the device and return 0 if there is one. */ -static int __devexit pmcmsptwi_remove(struct platform_device *pldev) +static int pmcmsptwi_remove(struct platform_device *pldev) { struct resource *res; @@ -628,7 +628,7 @@ static struct i2c_adapter pmcmsptwi_adapter = { static struct platform_driver pmcmsptwi_driver = { .probe = pmcmsptwi_probe, - .remove = __devexit_p(pmcmsptwi_remove), + .remove = pmcmsptwi_remove, .driver = { .name = DRV_NAME, .owner = THIS_MODULE, diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 5285f85..0dd5b33 100644 --- a/drivers/i2c/busses/i2c-powermac.c +++ b/drivers/i2c/busses/i2c-powermac.c @@ -210,7 +210,7 @@ static const struct i2c_algorithm i2c_powermac_algorithm = { }; -static int __devexit i2c_powermac_remove(struct platform_device *dev) +static int i2c_powermac_remove(struct platform_device *dev) { struct i2c_adapter *adapter = platform_get_drvdata(dev); int rc; @@ -227,7 +227,7 @@ static int __devexit i2c_powermac_remove(struct platform_device *dev) return 0; } -static u32 __devinit i2c_powermac_get_addr(struct i2c_adapter *adap, +static u32 i2c_powermac_get_addr(struct i2c_adapter *adap, struct pmac_i2c_bus *bus, struct device_node *node) { @@ -255,7 +255,7 @@ static u32 __devinit i2c_powermac_get_addr(struct i2c_adapter *adap, return 0xffffffff; } -static void __devinit i2c_powermac_create_one(struct i2c_adapter *adap, +static void i2c_powermac_create_one(struct i2c_adapter *adap, const char *type, u32 addr) { @@ -271,7 +271,7 @@ static void __devinit i2c_powermac_create_one(struct i2c_adapter *adap, type); } -static void __devinit i2c_powermac_add_missing(struct i2c_adapter *adap, +static void i2c_powermac_add_missing(struct i2c_adapter *adap, struct pmac_i2c_bus *bus, bool found_onyx) { @@ -297,7 +297,7 @@ static void __devinit i2c_powermac_add_missing(struct i2c_adapter *adap, } } -static bool __devinit i2c_powermac_get_type(struct i2c_adapter *adap, +static bool i2c_powermac_get_type(struct i2c_adapter *adap, struct device_node *node, u32 addr, char *type, int type_size) { @@ -336,7 +336,7 @@ static bool __devinit i2c_powermac_get_type(struct i2c_adapter *adap, return false; } -static void __devinit i2c_powermac_register_devices(struct i2c_adapter *adap, +static void i2c_powermac_register_devices(struct i2c_adapter *adap, struct pmac_i2c_bus *bus) { struct i2c_client *newdev; @@ -403,7 +403,7 @@ static void __devinit i2c_powermac_register_devices(struct i2c_adapter *adap, i2c_powermac_add_missing(adap, bus, found_onyx); } -static int __devinit i2c_powermac_probe(struct platform_device *dev) +static int i2c_powermac_probe(struct platform_device *dev) { struct pmac_i2c_bus *bus = dev->dev.platform_data; struct device_node *parent = NULL; @@ -467,7 +467,7 @@ static int __devinit i2c_powermac_probe(struct platform_device *dev) static struct platform_driver i2c_powermac_driver = { .probe = i2c_powermac_probe, - .remove = __devexit_p(i2c_powermac_remove), + .remove = i2c_powermac_remove, .driver = { .name = "i2c-powermac", .bus = &platform_bus_type, diff --git a/drivers/i2c/busses/i2c-pxa-pci.c b/drivers/i2c/busses/i2c-pxa-pci.c index 4dc9bef..3d49856 100644 --- a/drivers/i2c/busses/i2c-pxa-pci.c +++ b/drivers/i2c/busses/i2c-pxa-pci.c @@ -94,7 +94,7 @@ out: return ERR_PTR(ret); } -static int __devinit ce4100_i2c_probe(struct pci_dev *dev, +static int ce4100_i2c_probe(struct pci_dev *dev, const struct pci_device_id *ent) { int ret; @@ -135,7 +135,7 @@ err_mem: return ret; } -static void __devexit ce4100_i2c_remove(struct pci_dev *dev) +static void ce4100_i2c_remove(struct pci_dev *dev) { struct ce4100_devices *sds; unsigned int i; @@ -160,7 +160,7 @@ static struct pci_driver ce4100_i2c_driver = { .name = "ce4100_i2c", .id_table = ce4100_i2c_devices, .probe = ce4100_i2c_probe, - .remove = __devexit_p(ce4100_i2c_remove), + .remove = ce4100_i2c_remove, }; module_pci_driver(ce4100_i2c_driver); diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 72a8071..9bd4d73 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -613,7 +613,7 @@ static const struct i2c_algorithm rcar_i2c_algo = { .functionality = rcar_i2c_func, }; -static int __devinit rcar_i2c_probe(struct platform_device *pdev) +static int rcar_i2c_probe(struct platform_device *pdev) { struct i2c_rcar_platform_data *pdata = pdev->dev.platform_data; struct rcar_i2c_priv *priv; @@ -682,7 +682,7 @@ static int __devinit rcar_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit rcar_i2c_remove(struct platform_device *pdev) +static int rcar_i2c_remove(struct platform_device *pdev) { struct rcar_i2c_priv *priv = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; @@ -699,7 +699,7 @@ static struct platform_driver rcar_i2c_driver = { .owner = THIS_MODULE, }, .probe = rcar_i2c_probe, - .remove = __devexit_p(rcar_i2c_remove), + .remove = rcar_i2c_remove, }; module_platform_driver(rcar_i2c_driver); diff --git a/drivers/i2c/busses/i2c-s6000.c b/drivers/i2c/busses/i2c-s6000.c index b76a29d..0088364 100644 --- a/drivers/i2c/busses/i2c-s6000.c +++ b/drivers/i2c/busses/i2c-s6000.c @@ -248,7 +248,7 @@ static struct i2c_algorithm s6i2c_algorithm = { .functionality = s6i2c_functionality, }; -static u16 __devinit nanoseconds_on_clk(struct s6i2c_if *iface, u32 ns) +static u16 nanoseconds_on_clk(struct s6i2c_if *iface, u32 ns) { u32 dividend = ((clk_get_rate(iface->clk) / 1000) * ns) / 1000000; if (dividend > 0xffff) @@ -256,7 +256,7 @@ static u16 __devinit nanoseconds_on_clk(struct s6i2c_if *iface, u32 ns) return dividend; } -static int __devinit s6i2c_probe(struct platform_device *dev) +static int s6i2c_probe(struct platform_device *dev) { struct s6i2c_if *iface = &s6i2c_if; struct i2c_adapter *p_adap; @@ -361,7 +361,7 @@ err_out: return rc; } -static int __devexit s6i2c_remove(struct platform_device *pdev) +static int s6i2c_remove(struct platform_device *pdev) { struct s6i2c_if *iface = platform_get_drvdata(pdev); i2c_wr16(iface, S6_I2C_ENABLE, 0); @@ -378,7 +378,7 @@ static int __devexit s6i2c_remove(struct platform_device *pdev) static struct platform_driver s6i2c_driver = { .probe = s6i2c_probe, - .remove = __devexit_p(s6i2c_remove), + .remove = s6i2c_remove, .driver = { .name = DRV_NAME, .owner = THIS_MODULE, diff --git a/drivers/i2c/busses/i2c-sh7760.c b/drivers/i2c/busses/i2c-sh7760.c index c0c9dff..3a2253e 100644 --- a/drivers/i2c/busses/i2c-sh7760.c +++ b/drivers/i2c/busses/i2c-sh7760.c @@ -390,7 +390,7 @@ static const struct i2c_algorithm sh7760_i2c_algo = { * iclk = mclk/(CDF + 1). iclk must be < 20MHz. * scl = iclk/(SCGD*8 + 20). */ -static int __devinit calc_CCR(unsigned long scl_hz) +static int calc_CCR(unsigned long scl_hz) { struct clk *mclk; unsigned long mck, m1, dff, odff, iclk; @@ -430,7 +430,7 @@ static int __devinit calc_CCR(unsigned long scl_hz) return ((scgdm << 2) | cdfm); } -static int __devinit sh7760_i2c_probe(struct platform_device *pdev) +static int sh7760_i2c_probe(struct platform_device *pdev) { struct sh7760_i2c_platdata *pd; struct resource *res; @@ -536,7 +536,7 @@ out0: return ret; } -static int __devexit sh7760_i2c_remove(struct platform_device *pdev) +static int sh7760_i2c_remove(struct platform_device *pdev) { struct cami2c *id = platform_get_drvdata(pdev); @@ -557,7 +557,7 @@ static struct platform_driver sh7760_i2c_drv = { .owner = THIS_MODULE, }, .probe = sh7760_i2c_probe, - .remove = __devexit_p(sh7760_i2c_remove), + .remove = sh7760_i2c_remove, }; module_platform_driver(sh7760_i2c_drv); diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 9411c1b..b6e7a83 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -758,7 +758,7 @@ static const struct dev_pm_ops sh_mobile_i2c_dev_pm_ops = { .runtime_resume = sh_mobile_i2c_runtime_nop, }; -static const struct of_device_id sh_mobile_i2c_dt_ids[] __devinitconst = { +static const struct of_device_id sh_mobile_i2c_dt_ids[] = { { .compatible = "renesas,rmobile-iic", }, {}, }; diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index dcea77b..7b38877 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -642,7 +642,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_hw = { #if defined(CONFIG_OF) /* Match table for of_platform binding */ -static const struct of_device_id tegra_i2c_of_match[] __devinitconst = { +static const struct of_device_id tegra_i2c_of_match[] = { { .compatible = "nvidia,tegra30-i2c", .data = &tegra30_i2c_hw, }, { .compatible = "nvidia,tegra20-i2c", .data = &tegra20_i2c_hw, }, { .compatible = "nvidia,tegra20-i2c-dvc", .data = &tegra20_i2c_hw, }, @@ -651,7 +651,7 @@ static const struct of_device_id tegra_i2c_of_match[] __devinitconst = { MODULE_DEVICE_TABLE(of, tegra_i2c_of_match); #endif -static int __devinit tegra_i2c_probe(struct platform_device *pdev) +static int tegra_i2c_probe(struct platform_device *pdev) { struct tegra_i2c_dev *i2c_dev; struct tegra_i2c_platform_data *pdata = pdev->dev.platform_data; @@ -769,7 +769,7 @@ static int __devinit tegra_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit tegra_i2c_remove(struct platform_device *pdev) +static int tegra_i2c_remove(struct platform_device *pdev) { struct tegra_i2c_dev *i2c_dev = platform_get_drvdata(pdev); i2c_del_adapter(&i2c_dev->adapter); @@ -817,7 +817,7 @@ static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resume); static struct platform_driver tegra_i2c_driver = { .probe = tegra_i2c_probe, - .remove = __devexit_p(tegra_i2c_remove), + .remove = tegra_i2c_remove, .driver = { .name = "tegra-i2c", .owner = THIS_MODULE, diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index f5fa20d..f45c32c 100644 --- a/drivers/i2c/busses/i2c-viperboard.c +++ b/drivers/i2c/busses/i2c-viperboard.c @@ -360,7 +360,7 @@ static const struct i2c_algorithm vprbrd_algorithm = { .functionality = vprbrd_i2c_func, }; -static int __devinit vprbrd_i2c_probe(struct platform_device *pdev) +static int vprbrd_i2c_probe(struct platform_device *pdev) { struct vprbrd *vb = dev_get_drvdata(pdev->dev.parent); struct vprbrd_i2c *vb_i2c; @@ -418,7 +418,7 @@ error: return ret; } -static int __devexit vprbrd_i2c_remove(struct platform_device *pdev) +static int vprbrd_i2c_remove(struct platform_device *pdev) { struct vprbrd_i2c *vb_i2c = platform_get_drvdata(pdev); int ret; @@ -432,7 +432,7 @@ static struct platform_driver vprbrd_i2c_driver = { .driver.name = "viperboard-i2c", .driver.owner = THIS_MODULE, .probe = vprbrd_i2c_probe, - .remove = __devexit_p(vprbrd_i2c_remove), + .remove = vprbrd_i2c_remove, }; static int __init vprbrd_i2c_init(void) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 641d0e5..9aa8837 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -689,7 +689,7 @@ static struct i2c_adapter xiic_adapter = { }; -static int __devinit xiic_i2c_probe(struct platform_device *pdev) +static int xiic_i2c_probe(struct platform_device *pdev) { struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; @@ -774,7 +774,7 @@ resource_missing: return -ENOENT; } -static int __devexit xiic_i2c_remove(struct platform_device* pdev) +static int xiic_i2c_remove(struct platform_device* pdev) { struct xiic_i2c *i2c = platform_get_drvdata(pdev); struct resource *res; @@ -800,7 +800,7 @@ static int __devexit xiic_i2c_remove(struct platform_device* pdev) } #if defined(CONFIG_OF) -static const struct of_device_id xiic_of_match[] __devinitconst = { +static const struct of_device_id xiic_of_match[] = { { .compatible = "xlnx,xps-iic-2.00.a", }, {}, }; @@ -809,7 +809,7 @@ MODULE_DEVICE_TABLE(of, xiic_of_match); static struct platform_driver xiic_i2c_driver = { .probe = xiic_i2c_probe, - .remove = __devexit_p(xiic_i2c_remove), + .remove = xiic_i2c_remove, .driver = { .owner = THIS_MODULE, .name = DRIVER_NAME, diff --git a/drivers/i2c/busses/i2c-xlr.c b/drivers/i2c/busses/i2c-xlr.c index 96d3fab..a005265 100644 --- a/drivers/i2c/busses/i2c-xlr.c +++ b/drivers/i2c/busses/i2c-xlr.c @@ -214,7 +214,7 @@ static struct i2c_algorithm xlr_i2c_algo = { .functionality = xlr_func, }; -static int __devinit xlr_i2c_probe(struct platform_device *pdev) +static int xlr_i2c_probe(struct platform_device *pdev) { struct xlr_i2c_private *priv; struct resource *res; @@ -251,7 +251,7 @@ static int __devinit xlr_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit xlr_i2c_remove(struct platform_device *pdev) +static int xlr_i2c_remove(struct platform_device *pdev) { struct xlr_i2c_private *priv; @@ -263,7 +263,7 @@ static int __devexit xlr_i2c_remove(struct platform_device *pdev) static struct platform_driver xlr_i2c_driver = { .probe = xlr_i2c_probe, - .remove = __devexit_p(xlr_i2c_remove), + .remove = xlr_i2c_remove, .driver = { .name = "xlr-i2cbus", .owner = THIS_MODULE, diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c index 7fa5b24..1e44d04 100644 --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c @@ -129,7 +129,7 @@ static inline int i2c_mux_pinctrl_parse_dt(struct i2c_mux_pinctrl *mux, } #endif -static int __devinit i2c_mux_pinctrl_probe(struct platform_device *pdev) +static int i2c_mux_pinctrl_probe(struct platform_device *pdev) { struct i2c_mux_pinctrl *mux; int (*deselect)(struct i2c_adapter *, void *, u32); @@ -241,7 +241,7 @@ err: return ret; } -static int __devexit i2c_mux_pinctrl_remove(struct platform_device *pdev) +static int i2c_mux_pinctrl_remove(struct platform_device *pdev) { struct i2c_mux_pinctrl *mux = platform_get_drvdata(pdev); int i; @@ -255,7 +255,7 @@ static int __devexit i2c_mux_pinctrl_remove(struct platform_device *pdev) } #ifdef CONFIG_OF -static const struct of_device_id i2c_mux_pinctrl_of_match[] __devinitconst = { +static const struct of_device_id i2c_mux_pinctrl_of_match[] = { { .compatible = "i2c-mux-pinctrl", }, {}, }; @@ -269,7 +269,7 @@ static struct platform_driver i2c_mux_pinctrl_driver = { .of_match_table = of_match_ptr(i2c_mux_pinctrl_of_match), }, .probe = i2c_mux_pinctrl_probe, - .remove = __devexit_p(i2c_mux_pinctrl_remove), + .remove = i2c_mux_pinctrl_remove, }; module_platform_driver(i2c_mux_pinctrl_driver); -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 02/16] i2c: mux-gpio: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 01/16] i2c/busses: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-3-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 03/16] i2c: pnx: " Bill Pemberton ` (13 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Peter Korsgaard CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org> --- drivers/i2c/muxes/i2c-mux-gpio.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 3b7bc06..9f50ef0 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -53,14 +53,14 @@ static int i2c_mux_gpio_deselect(struct i2c_adapter *adap, void *data, u32 chan) return 0; } -static int __devinit match_gpio_chip_by_label(struct gpio_chip *chip, +static int match_gpio_chip_by_label(struct gpio_chip *chip, void *data) { return !strcmp(chip->label, data); } #ifdef CONFIG_OF -static int __devinit i2c_mux_gpio_probe_dt(struct gpiomux *mux, +static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, struct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -125,14 +125,14 @@ static int __devinit i2c_mux_gpio_probe_dt(struct gpiomux *mux, return 0; } #else -static int __devinit i2c_mux_gpio_probe_dt(struct gpiomux *mux, +static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, struct platform_device *pdev) { return 0; } #endif -static int __devinit i2c_mux_gpio_probe(struct platform_device *pdev) +static int i2c_mux_gpio_probe(struct platform_device *pdev) { struct gpiomux *mux; struct i2c_adapter *parent; @@ -239,7 +239,7 @@ alloc_failed: return ret; } -static int __devexit i2c_mux_gpio_remove(struct platform_device *pdev) +static int i2c_mux_gpio_remove(struct platform_device *pdev) { struct gpiomux *mux = platform_get_drvdata(pdev); int i; @@ -256,7 +256,7 @@ static int __devexit i2c_mux_gpio_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id i2c_mux_gpio_of_match[] __devinitconst = { +static const struct of_device_id i2c_mux_gpio_of_match[] = { { .compatible = "i2c-mux-gpio", }, {}, }; @@ -264,7 +264,7 @@ MODULE_DEVICE_TABLE(of, i2c_mux_gpio_of_match); static struct platform_driver i2c_mux_gpio_driver = { .probe = i2c_mux_gpio_probe, - .remove = __devexit_p(i2c_mux_gpio_remove), + .remove = i2c_mux_gpio_remove, .driver = { .owner = THIS_MODULE, .name = "i2c-mux-gpio", -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-3-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 02/16] i2c: mux-gpio: remove __dev* attributes [not found] ` <1354049993-12718-3-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-27 22:44 ` Peter Korsgaard 0 siblings, 0 replies; 33+ messages in thread From: Peter Korsgaard @ 2012-11-27 22:44 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r >>>>> "BP" == Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> writes: BP> CONFIG_HOTPLUG is going away as an option. As result the __dev* BP> markings will be going away. BP> Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, BP> and __devexit. BP> Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> BP> Cc: Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org> Acked-by: Peter Korsgaard <peter.korsgaard-ob4gmnvZ1/cAvxtiuMwx3w@public.gmane.org> -- Sorry about disclaimer - It's out of my control. Bye, Peter Korsgaard DISCLAIMER: Unless indicated otherwise, the information contained in this message is privileged and confidential, and is intended only for the use of the addressee(s) named above and others who have been specifically authorized to receive it. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this message and/or attachments is strictly prohibited. The company accepts no liability for any damage caused by any virus transmitted by this email. Furthermore, the company does not warrant a proper and complete transmission of this information, nor does it accept liability for any delays. If you have received this message in error, please contact the sender and delete the message. Thank you. ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 03/16] i2c: pnx: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 01/16] i2c/busses: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 02/16] i2c: mux-gpio: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 04/16] i2c: scx200_acb: " Bill Pemberton ` (12 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Vitaly Wool CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Vitaly Wool <vitalywool-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/i2c/busses/i2c-pnx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c index 8488bdd..ce40970 100644 --- a/drivers/i2c/busses/i2c-pnx.c +++ b/drivers/i2c/busses/i2c-pnx.c @@ -619,7 +619,7 @@ static SIMPLE_DEV_PM_OPS(i2c_pnx_pm, #define PNX_I2C_PM NULL #endif -static int __devinit i2c_pnx_probe(struct platform_device *pdev) +static int i2c_pnx_probe(struct platform_device *pdev) { unsigned long tmp; int ret = 0; @@ -765,7 +765,7 @@ err_kzalloc: return ret; } -static int __devexit i2c_pnx_remove(struct platform_device *pdev) +static int i2c_pnx_remove(struct platform_device *pdev) { struct i2c_pnx_algo_data *alg_data = platform_get_drvdata(pdev); @@ -797,7 +797,7 @@ static struct platform_driver i2c_pnx_driver = { .pm = PNX_I2C_PM, }, .probe = i2c_pnx_probe, - .remove = __devexit_p(i2c_pnx_remove), + .remove = i2c_pnx_remove, }; static int __init i2c_adap_pnx_init(void) -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 04/16] i2c: scx200_acb: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (2 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 03/16] i2c: pnx: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 06/16] i2c: i2c-gpio: " Bill Pemberton ` (11 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Jim Cromie CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Jim Cromie <jim.cromie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/i2c/busses/scx200_acb.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c index 08aab57..4486c11 100644 --- a/drivers/i2c/busses/scx200_acb.c +++ b/drivers/i2c/busses/scx200_acb.c @@ -389,7 +389,7 @@ static const struct i2c_algorithm scx200_acb_algorithm = { static struct scx200_acb_iface *scx200_acb_list; static DEFINE_MUTEX(scx200_acb_list_mutex); -static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface) +static int scx200_acb_probe(struct scx200_acb_iface *iface) { u8 val; @@ -424,7 +424,7 @@ static __devinit int scx200_acb_probe(struct scx200_acb_iface *iface) return 0; } -static __devinit struct scx200_acb_iface *scx200_create_iface(const char *text, +static struct scx200_acb_iface *scx200_create_iface(const char *text, struct device *dev, int index) { struct scx200_acb_iface *iface; @@ -449,7 +449,7 @@ static __devinit struct scx200_acb_iface *scx200_create_iface(const char *text, return iface; } -static int __devinit scx200_acb_create(struct scx200_acb_iface *iface) +static int scx200_acb_create(struct scx200_acb_iface *iface) { struct i2c_adapter *adapter; int rc; @@ -480,7 +480,7 @@ static int __devinit scx200_acb_create(struct scx200_acb_iface *iface) return 0; } -static struct scx200_acb_iface * __devinit scx200_create_dev(const char *text, +static struct scx200_acb_iface * scx200_create_dev(const char *text, unsigned long base, int index, struct device *dev) { struct scx200_acb_iface *iface; @@ -508,7 +508,7 @@ static struct scx200_acb_iface * __devinit scx200_create_dev(const char *text, return NULL; } -static int __devinit scx200_probe(struct platform_device *pdev) +static int scx200_probe(struct platform_device *pdev) { struct scx200_acb_iface *iface; struct resource *res; @@ -530,14 +530,14 @@ static int __devinit scx200_probe(struct platform_device *pdev) return 0; } -static void __devexit scx200_cleanup_iface(struct scx200_acb_iface *iface) +static void scx200_cleanup_iface(struct scx200_acb_iface *iface) { i2c_del_adapter(&iface->adapter); release_region(iface->base, 8); kfree(iface); } -static int __devexit scx200_remove(struct platform_device *pdev) +static int scx200_remove(struct platform_device *pdev) { struct scx200_acb_iface *iface; @@ -554,7 +554,7 @@ static struct platform_driver scx200_pci_driver = { .owner = THIS_MODULE, }, .probe = scx200_probe, - .remove = __devexit_p(scx200_remove), + .remove = scx200_remove, }; static DEFINE_PCI_DEVICE_TABLE(scx200_isa) = { -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 06/16] i2c: i2c-gpio: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (3 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 04/16] i2c: scx200_acb: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-7-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 07/16] i2c: i2c-parport-light: " Bill Pemberton ` (10 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Haavard Skinnemoen CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Haavard Skinnemoen <hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/i2c/busses/i2c-gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c index 257299a..f3fa433 100644 --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c-gpio.c @@ -85,7 +85,7 @@ static int i2c_gpio_getscl(void *data) return gpio_get_value(pdata->scl_pin); } -static int __devinit of_i2c_gpio_probe(struct device_node *np, +static int of_i2c_gpio_probe(struct device_node *np, struct i2c_gpio_platform_data *pdata) { u32 reg; @@ -117,7 +117,7 @@ static int __devinit of_i2c_gpio_probe(struct device_node *np, return 0; } -static int __devinit i2c_gpio_probe(struct platform_device *pdev) +static int i2c_gpio_probe(struct platform_device *pdev) { struct i2c_gpio_private_data *priv; struct i2c_gpio_platform_data *pdata; @@ -218,7 +218,7 @@ err_request_sda: return ret; } -static int __devexit i2c_gpio_remove(struct platform_device *pdev) +static int i2c_gpio_remove(struct platform_device *pdev) { struct i2c_gpio_private_data *priv; struct i2c_gpio_platform_data *pdata; @@ -251,7 +251,7 @@ static struct platform_driver i2c_gpio_driver = { .of_match_table = of_match_ptr(i2c_gpio_dt_ids), }, .probe = i2c_gpio_probe, - .remove = __devexit_p(i2c_gpio_remove), + .remove = i2c_gpio_remove, }; static int __init i2c_gpio_init(void) -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-7-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 06/16] i2c: i2c-gpio: remove __dev* attributes [not found] ` <1354049993-12718-7-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-27 22:22 ` Håvard Skinnemoen 0 siblings, 0 replies; 33+ messages in thread From: Håvard Skinnemoen @ 2012-11-27 22:22 UTC (permalink / raw) To: Bill Pemberton; +Cc: linux-i2c, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r On Tue, Nov 27, 2012 at 12:59 PM, Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> wrote: > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Haavard Skinnemoen <hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Acked-by: Havard Skinnemoen <hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 07/16] i2c: i2c-parport-light: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (4 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 06/16] i2c: i2c-gpio: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-8-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 08/16] i2c: ocores: " Bill Pemberton ` (9 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Jean Delvare CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> --- drivers/i2c/busses/i2c-parport-light.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-parport-light.c b/drivers/i2c/busses/i2c-parport-light.c index 4b95f7a..aa95778 100644 --- a/drivers/i2c/busses/i2c-parport-light.c +++ b/drivers/i2c/busses/i2c-parport-light.c @@ -135,7 +135,7 @@ static struct lineop parport_ctrl_irq = { .port = PORT_CTRL, }; -static int __devinit i2c_parport_probe(struct platform_device *pdev) +static int i2c_parport_probe(struct platform_device *pdev) { int err; @@ -169,7 +169,7 @@ static int __devinit i2c_parport_probe(struct platform_device *pdev) return 0; } -static int __devexit i2c_parport_remove(struct platform_device *pdev) +static int i2c_parport_remove(struct platform_device *pdev) { if (ara) { line_set(0, &parport_ctrl_irq); @@ -191,7 +191,7 @@ static struct platform_driver i2c_parport_driver = { .name = DRVNAME, }, .probe = i2c_parport_probe, - .remove = __devexit_p(i2c_parport_remove), + .remove = i2c_parport_remove, }; static int __init i2c_parport_device_add(u16 address) -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-8-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 07/16] i2c: i2c-parport-light: remove __dev* attributes [not found] ` <1354049993-12718-8-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-28 12:28 ` Jean Delvare 0 siblings, 0 replies; 33+ messages in thread From: Jean Delvare @ 2012-11-28 12:28 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r On Tue, 27 Nov 2012 15:59:44 -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > --- > drivers/i2c/busses/i2c-parport-light.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > (...) Reviewed-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 08/16] i2c: ocores: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (5 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 07/16] i2c: i2c-parport-light: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-9-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 09/16] i2c: omap: " Bill Pemberton ` (8 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Peter Korsgaard CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org> --- drivers/i2c/busses/i2c-ocores.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 9b35c9f..a873d0a 100644 --- a/drivers/i2c/busses/i2c-ocores.c +++ b/drivers/i2c/busses/i2c-ocores.c @@ -343,7 +343,7 @@ static int ocores_i2c_of_probe(struct platform_device *pdev, #define ocores_i2c_of_probe(pdev,i2c) -ENODEV #endif -static int __devinit ocores_i2c_probe(struct platform_device *pdev) +static int ocores_i2c_probe(struct platform_device *pdev) { struct ocores_i2c *i2c; struct ocores_i2c_platform_data *pdata; @@ -441,7 +441,7 @@ static int __devinit ocores_i2c_probe(struct platform_device *pdev) return 0; } -static int __devexit ocores_i2c_remove(struct platform_device *pdev) +static int ocores_i2c_remove(struct platform_device *pdev) { struct ocores_i2c *i2c = platform_get_drvdata(pdev); @@ -485,7 +485,7 @@ static SIMPLE_DEV_PM_OPS(ocores_i2c_pm, ocores_i2c_suspend, ocores_i2c_resume); static struct platform_driver ocores_i2c_driver = { .probe = ocores_i2c_probe, - .remove = __devexit_p(ocores_i2c_remove), + .remove = ocores_i2c_remove, .driver = { .owner = THIS_MODULE, .name = "ocores-i2c", -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-9-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 08/16] i2c: ocores: remove __dev* attributes [not found] ` <1354049993-12718-9-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-27 22:55 ` Peter Korsgaard 0 siblings, 0 replies; 33+ messages in thread From: Peter Korsgaard @ 2012-11-27 22:55 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r >>>>> "Bill" == Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> writes: Bill> CONFIG_HOTPLUG is going away as an option. As result the __dev* Bill> markings will be going away. Bill> Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, Bill> and __devexit. Acked-by: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org> -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 09/16] i2c: omap: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (6 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 08/16] i2c: ocores: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 10/16] i2c: pca: " Bill Pemberton ` (7 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Tony Lindgren CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> --- drivers/i2c/busses/i2c-omap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 2482801..47568eb 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1070,7 +1070,7 @@ MODULE_DEVICE_TABLE(of, omap_i2c_of_match); #define OMAP_I2C_SCHEME_0 0 #define OMAP_I2C_SCHEME_1 1 -static int __devinit +static int omap_i2c_probe(struct platform_device *pdev) { struct omap_i2c_dev *dev; @@ -1268,7 +1268,7 @@ err_free_mem: return r; } -static int __devexit omap_i2c_remove(struct platform_device *pdev) +static int omap_i2c_remove(struct platform_device *pdev) { struct omap_i2c_dev *dev = platform_get_drvdata(pdev); int ret; @@ -1334,7 +1334,7 @@ static struct dev_pm_ops omap_i2c_pm_ops = { static struct platform_driver omap_i2c_driver = { .probe = omap_i2c_probe, - .remove = __devexit_p(omap_i2c_remove), + .remove = omap_i2c_remove, .driver = { .name = "omap_i2c", .owner = THIS_MODULE, -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 10/16] i2c: pca: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (7 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 09/16] i2c: omap: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 11/16] i2c: puv3: " Bill Pemberton ` (6 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Wolfram Sang CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> --- drivers/i2c/busses/i2c-pca-isa.c | 8 ++++---- drivers/i2c/busses/i2c-pca-platform.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-pca-isa.c b/drivers/i2c/busses/i2c-pca-isa.c index 29933f8..323f061 100644 --- a/drivers/i2c/busses/i2c-pca-isa.c +++ b/drivers/i2c/busses/i2c-pca-isa.c @@ -119,7 +119,7 @@ static struct i2c_adapter pca_isa_ops = { .timeout = HZ, }; -static int __devinit pca_isa_match(struct device *dev, unsigned int id) +static int pca_isa_match(struct device *dev, unsigned int id) { int match = base != 0; @@ -132,7 +132,7 @@ static int __devinit pca_isa_match(struct device *dev, unsigned int id) return match; } -static int __devinit pca_isa_probe(struct device *dev, unsigned int id) +static int pca_isa_probe(struct device *dev, unsigned int id) { init_waitqueue_head(&pca_wait); @@ -174,7 +174,7 @@ static int __devinit pca_isa_probe(struct device *dev, unsigned int id) return -ENODEV; } -static int __devexit pca_isa_remove(struct device *dev, unsigned int id) +static int pca_isa_remove(struct device *dev, unsigned int id) { i2c_del_adapter(&pca_isa_ops); @@ -190,7 +190,7 @@ static int __devexit pca_isa_remove(struct device *dev, unsigned int id) static struct isa_driver pca_isa_driver = { .match = pca_isa_match, .probe = pca_isa_probe, - .remove = __devexit_p(pca_isa_remove), + .remove = pca_isa_remove, .driver = { .owner = THIS_MODULE, .name = DRIVER, diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c index 675878f..a30d2f6 100644 --- a/drivers/i2c/busses/i2c-pca-platform.c +++ b/drivers/i2c/busses/i2c-pca-platform.c @@ -131,7 +131,7 @@ static irqreturn_t i2c_pca_pf_handler(int this_irq, void *dev_id) } -static int __devinit i2c_pca_pf_probe(struct platform_device *pdev) +static int i2c_pca_pf_probe(struct platform_device *pdev) { struct i2c_pca_pf_data *i2c; struct resource *res; @@ -257,7 +257,7 @@ e_print: return ret; } -static int __devexit i2c_pca_pf_remove(struct platform_device *pdev) +static int i2c_pca_pf_remove(struct platform_device *pdev) { struct i2c_pca_pf_data *i2c = platform_get_drvdata(pdev); platform_set_drvdata(pdev, NULL); @@ -279,7 +279,7 @@ static int __devexit i2c_pca_pf_remove(struct platform_device *pdev) static struct platform_driver i2c_pca_pf_driver = { .probe = i2c_pca_pf_probe, - .remove = __devexit_p(i2c_pca_pf_remove), + .remove = i2c_pca_pf_remove, .driver = { .name = "i2c-pca-platform", .owner = THIS_MODULE, -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 11/16] i2c: puv3: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (8 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 10/16] i2c: pca: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-12-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 12/16] i2c: i2c-pasemi: " Bill Pemberton ` (5 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Guan Xuetao CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> --- drivers/i2c/busses/i2c-puv3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c index d8515be..d7c512d 100644 --- a/drivers/i2c/busses/i2c-puv3.c +++ b/drivers/i2c/busses/i2c-puv3.c @@ -184,7 +184,7 @@ static struct i2c_algorithm puv3_i2c_algorithm = { /* * Main initialization routine. */ -static int __devinit puv3_i2c_probe(struct platform_device *pdev) +static int puv3_i2c_probe(struct platform_device *pdev) { struct i2c_adapter *adapter; struct resource *mem; @@ -231,7 +231,7 @@ fail_nomem: return rc; } -static int __devexit puv3_i2c_remove(struct platform_device *pdev) +static int puv3_i2c_remove(struct platform_device *pdev) { struct i2c_adapter *adapter = platform_get_drvdata(pdev); struct resource *mem; @@ -276,7 +276,7 @@ static SIMPLE_DEV_PM_OPS(puv3_i2c_pm, puv3_i2c_suspend, NULL); static struct platform_driver puv3_i2c_driver = { .probe = puv3_i2c_probe, - .remove = __devexit_p(puv3_i2c_remove), + .remove = puv3_i2c_remove, .driver = { .name = "PKUnity-v3-I2C", .owner = THIS_MODULE, -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-12-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 11/16] i2c: puv3: remove __dev* attributes [not found] ` <1354049993-12718-12-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-29 1:22 ` guanxuetao-TG0Ac1+ktVePQbnJrJN+5g 0 siblings, 0 replies; 33+ messages in thread From: guanxuetao-TG0Ac1+ktVePQbnJrJN+5g @ 2012-11-29 1:22 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Guan Xuetao > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> Acked-by: Guan Xuetao <gxt-TG0Ac1+ktVePQbnJrJN+5g@public.gmane.org> > --- > drivers/i2c/busses/i2c-puv3.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-puv3.c b/drivers/i2c/busses/i2c-puv3.c > index d8515be..d7c512d 100644 > --- a/drivers/i2c/busses/i2c-puv3.c > +++ b/drivers/i2c/busses/i2c-puv3.c > @@ -184,7 +184,7 @@ static struct i2c_algorithm puv3_i2c_algorithm = { > /* > * Main initialization routine. > */ > -static int __devinit puv3_i2c_probe(struct platform_device *pdev) > +static int puv3_i2c_probe(struct platform_device *pdev) > { > struct i2c_adapter *adapter; > struct resource *mem; > @@ -231,7 +231,7 @@ fail_nomem: > return rc; > } > > -static int __devexit puv3_i2c_remove(struct platform_device *pdev) > +static int puv3_i2c_remove(struct platform_device *pdev) > { > struct i2c_adapter *adapter = platform_get_drvdata(pdev); > struct resource *mem; > @@ -276,7 +276,7 @@ static SIMPLE_DEV_PM_OPS(puv3_i2c_pm, > puv3_i2c_suspend, NULL); > > static struct platform_driver puv3_i2c_driver = { > .probe = puv3_i2c_probe, > - .remove = __devexit_p(puv3_i2c_remove), > + .remove = puv3_i2c_remove, > .driver = { > .name = "PKUnity-v3-I2C", > .owner = THIS_MODULE, > -- > 1.8.0.1 > ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 12/16] i2c: i2c-pasemi: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (9 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 11/16] i2c: puv3: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 13/16] i2c: sirf: " Bill Pemberton ` (4 subsequent siblings) 15 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Olof Johansson CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org> --- drivers/i2c/busses/i2c-pasemi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-pasemi.c b/drivers/i2c/busses/i2c-pasemi.c index 12edefd..615f632 100644 --- a/drivers/i2c/busses/i2c-pasemi.c +++ b/drivers/i2c/busses/i2c-pasemi.c @@ -340,7 +340,7 @@ static const struct i2c_algorithm smbus_algorithm = { .functionality = pasemi_smb_func, }; -static int __devinit pasemi_smb_probe(struct pci_dev *dev, +static int pasemi_smb_probe(struct pci_dev *dev, const struct pci_device_id *id) { struct pasemi_smbus *smbus; @@ -392,7 +392,7 @@ static int __devinit pasemi_smb_probe(struct pci_dev *dev, return error; } -static void __devexit pasemi_smb_remove(struct pci_dev *dev) +static void pasemi_smb_remove(struct pci_dev *dev) { struct pasemi_smbus *smbus = pci_get_drvdata(dev); @@ -412,7 +412,7 @@ static struct pci_driver pasemi_smb_driver = { .name = "i2c-pasemi", .id_table = pasemi_smb_ids, .probe = pasemi_smb_probe, - .remove = __devexit_p(pasemi_smb_remove), + .remove = pasemi_smb_remove, }; module_pci_driver(pasemi_smb_driver); -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
* [PATCH 13/16] i2c: sirf: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (10 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 12/16] i2c: i2c-pasemi: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-14-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 14/16] i2c-ali1563: " Bill Pemberton ` (3 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Barry Song CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Barry Song <baohua.song-kQvG35nSl+M@public.gmane.org> --- drivers/i2c/busses/i2c-sirf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c index 5574a47..3f1818b 100644 --- a/drivers/i2c/busses/i2c-sirf.c +++ b/drivers/i2c/busses/i2c-sirf.c @@ -258,7 +258,7 @@ static const struct i2c_algorithm i2c_sirfsoc_algo = { .functionality = i2c_sirfsoc_func, }; -static int __devinit i2c_sirfsoc_probe(struct platform_device *pdev) +static int i2c_sirfsoc_probe(struct platform_device *pdev) { struct sirfsoc_i2c *siic; struct i2c_adapter *adap; @@ -385,7 +385,7 @@ err_get_clk: return err; } -static int __devexit i2c_sirfsoc_remove(struct platform_device *pdev) +static int i2c_sirfsoc_remove(struct platform_device *pdev) { struct i2c_adapter *adapter = platform_get_drvdata(pdev); struct sirfsoc_i2c *siic = adapter->algo_data; @@ -433,7 +433,7 @@ static const struct dev_pm_ops i2c_sirfsoc_pm_ops = { }; #endif -static const struct of_device_id sirfsoc_i2c_of_match[] __devinitconst = { +static const struct of_device_id sirfsoc_i2c_of_match[] = { { .compatible = "sirf,prima2-i2c", }, {}, }; @@ -449,7 +449,7 @@ static struct platform_driver i2c_sirfsoc_driver = { .of_match_table = sirfsoc_i2c_of_match, }, .probe = i2c_sirfsoc_probe, - .remove = __devexit_p(i2c_sirfsoc_remove), + .remove = i2c_sirfsoc_remove, }; module_platform_driver(i2c_sirfsoc_driver); -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-14-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* RE: [PATCH 13/16] i2c: sirf: remove __dev* attributes [not found] ` <1354049993-12718-14-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-28 2:45 ` Barry Song 0 siblings, 0 replies; 33+ messages in thread From: Barry Song @ 2012-11-28 2:45 UTC (permalink / raw) To: Bill Pemberton, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, DL-SHA-WorkGroupLinux > -----Original Message----- > From: Bill Pemberton [mailto:wfp5p@virginia.edu] > Sent: Wednesday, November 28, 2012 5:00 AM > To: linux-i2c@vger.kernel.org > Cc: gregkh@linuxfoundation.org; Barry Song > Subject: [PATCH 13/16] i2c: sirf: remove __dev* attributes > > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> > Cc: Barry Song <baohua.song@csr.com> Acked-by: Barry Song <baohua.song@csr.com> > --- > drivers/i2c/busses/i2c-sirf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 14/16] i2c-ali1563: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (11 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 13/16] i2c: sirf: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-15-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 15/16] i2c-sis96x: " Bill Pemberton ` (2 subsequent siblings) 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Rudolf Marek, Jean Delvare CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Rudolf Marek <r.marek-/xGekIyIa4Ap1Coe8Ar9gA@public.gmane.org> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> --- drivers/i2c/busses/i2c-ali1563.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c index e02d9f8..5b17c9f 100644 --- a/drivers/i2c/busses/i2c-ali1563.c +++ b/drivers/i2c/busses/i2c-ali1563.c @@ -326,7 +326,7 @@ static u32 ali1563_func(struct i2c_adapter * a) } -static int __devinit ali1563_setup(struct pci_dev * dev) +static int ali1563_setup(struct pci_dev * dev) { u16 ctrl; @@ -390,7 +390,7 @@ static struct i2c_adapter ali1563_adapter = { .algo = &ali1563_algorithm, }; -static int __devinit ali1563_probe(struct pci_dev * dev, +static int ali1563_probe(struct pci_dev * dev, const struct pci_device_id * id_table) { int error; @@ -411,7 +411,7 @@ exit: return error; } -static void __devexit ali1563_remove(struct pci_dev * dev) +static void ali1563_remove(struct pci_dev * dev) { i2c_del_adapter(&ali1563_adapter); ali1563_shutdown(dev); @@ -428,7 +428,7 @@ static struct pci_driver ali1563_pci_driver = { .name = "ali1563_smbus", .id_table = ali1563_id_table, .probe = ali1563_probe, - .remove = __devexit_p(ali1563_remove), + .remove = ali1563_remove, }; module_pci_driver(ali1563_pci_driver); -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-15-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 14/16] i2c-ali1563: remove __dev* attributes [not found] ` <1354049993-12718-15-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-28 12:31 ` Jean Delvare [not found] ` <20121128133153.700e84a8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> 0 siblings, 1 reply; 33+ messages in thread From: Jean Delvare @ 2012-11-28 12:31 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Rudolf Marek Hi Bill, On Tue, 27 Nov 2012 15:59:51 -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Rudolf Marek <r.marek-/xGekIyIa4Ap1Coe8Ar9gA@public.gmane.org> > Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > --- > drivers/i2c/busses/i2c-ali1563.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c > index e02d9f8..5b17c9f 100644 > --- a/drivers/i2c/busses/i2c-ali1563.c > +++ b/drivers/i2c/busses/i2c-ali1563.c > @@ -326,7 +326,7 @@ static u32 ali1563_func(struct i2c_adapter * a) > } > > > -static int __devinit ali1563_setup(struct pci_dev * dev) > +static int ali1563_setup(struct pci_dev * dev) While you're here, it would be great if you could fix the checkpatch errors on the lines you touch: ERROR: "foo * bar" should be "foo *bar" #91: FILE: drivers/i2c/busses/i2c-ali1563.c:329: +static int ali1563_setup(struct pci_dev * dev) and same twice below. Thanks. > { > u16 ctrl; > > @@ -390,7 +390,7 @@ static struct i2c_adapter ali1563_adapter = { > .algo = &ali1563_algorithm, > }; > > -static int __devinit ali1563_probe(struct pci_dev * dev, > +static int ali1563_probe(struct pci_dev * dev, > const struct pci_device_id * id_table) > { > int error; > @@ -411,7 +411,7 @@ exit: > return error; > } > > -static void __devexit ali1563_remove(struct pci_dev * dev) > +static void ali1563_remove(struct pci_dev * dev) > { > i2c_del_adapter(&ali1563_adapter); > ali1563_shutdown(dev); > @@ -428,7 +428,7 @@ static struct pci_driver ali1563_pci_driver = { > .name = "ali1563_smbus", > .id_table = ali1563_id_table, > .probe = ali1563_probe, > - .remove = __devexit_p(ali1563_remove), > + .remove = ali1563_remove, > }; > > module_pci_driver(ali1563_pci_driver); -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <20121128133153.700e84a8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>]
* Re: [PATCH 14/16] i2c-ali1563: remove __dev* attributes [not found] ` <20121128133153.700e84a8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> @ 2012-11-28 13:48 ` Bill Pemberton 0 siblings, 0 replies; 33+ messages in thread From: Bill Pemberton @ 2012-11-28 13:48 UTC (permalink / raw) To: Jean Delvare Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Rudolf Marek Jean Delvare writes: > > Hi Bill, > > On Tue, 27 Nov 2012 15:59:51 -0500, Bill Pemberton wrote: > > CONFIG_HOTPLUG is going away as an option. As result the __dev* > > markings will be going away. > > > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > > and __devexit. > > > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > > Cc: Rudolf Marek <r.marek-/xGekIyIa4Ap1Coe8Ar9gA@public.gmane.org> > > Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > > --- > > drivers/i2c/busses/i2c-ali1563.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c > > index e02d9f8..5b17c9f 100644 > > --- a/drivers/i2c/busses/i2c-ali1563.c > > +++ b/drivers/i2c/busses/i2c-ali1563.c > > @@ -326,7 +326,7 @@ static u32 ali1563_func(struct i2c_adapter * a) > > } > > > > > > -static int __devinit ali1563_setup(struct pci_dev * dev) > > +static int ali1563_setup(struct pci_dev * dev) > > While you're here, it would be great if you could fix the checkpatch > errors on the lines you touch: > The changes are done with a script, so it doesn't know to touch anything else on the same line. But it's no problem for me to go back with checkpatch and manually fix up the this stuff. I'll fix those and resend this patch. -- Bill ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 15/16] i2c-sis96x: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (12 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 14/16] i2c-ali1563: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-16-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 16/16] i2c: SMBus: " Bill Pemberton 2012-11-28 10:47 ` [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG Wolfram Sang 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Mark M. Hoffman, Jean Delvare CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Mark M. Hoffman <mhoffman-xQSgfq/1h4JiLUuM0BA3LQ@public.gmane.org> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> --- drivers/i2c/busses/i2c-sis96x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis96x.c b/drivers/i2c/busses/i2c-sis96x.c index 7b72614..b9faf9b 100644 --- a/drivers/i2c/busses/i2c-sis96x.c +++ b/drivers/i2c/busses/i2c-sis96x.c @@ -252,7 +252,7 @@ static DEFINE_PCI_DEVICE_TABLE(sis96x_ids) = { MODULE_DEVICE_TABLE (pci, sis96x_ids); -static int __devinit sis96x_probe(struct pci_dev *dev, +static int sis96x_probe(struct pci_dev *dev, const struct pci_device_id *id) { u16 ww = 0; @@ -308,7 +308,7 @@ static int __devinit sis96x_probe(struct pci_dev *dev, return retval; } -static void __devexit sis96x_remove(struct pci_dev *dev) +static void sis96x_remove(struct pci_dev *dev) { if (sis96x_smbus_base) { i2c_del_adapter(&sis96x_adapter); @@ -321,7 +321,7 @@ static struct pci_driver sis96x_driver = { .name = "sis96x_smbus", .id_table = sis96x_ids, .probe = sis96x_probe, - .remove = __devexit_p(sis96x_remove), + .remove = sis96x_remove, }; module_pci_driver(sis96x_driver); -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-16-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 15/16] i2c-sis96x: remove __dev* attributes [not found] ` <1354049993-12718-16-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-28 12:33 ` Jean Delvare 0 siblings, 0 replies; 33+ messages in thread From: Jean Delvare @ 2012-11-28 12:33 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Mark M. Hoffman On Tue, 27 Nov 2012 15:59:52 -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Mark M. Hoffman <mhoffman-xQSgfq/1h4JiLUuM0BA3LQ@public.gmane.org> > Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > --- > drivers/i2c/busses/i2c-sis96x.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > (...) Reviewed-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
* [PATCH 16/16] i2c: SMBus: remove __dev* attributes [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (13 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 15/16] i2c-sis96x: " Bill Pemberton @ 2012-11-27 20:59 ` Bill Pemberton [not found] ` <1354049993-12718-17-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 10:47 ` [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG Wolfram Sang 15 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-27 20:59 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r, Jean Delvare CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> --- drivers/i2c/busses/i2c-ali1535.c | 8 ++++---- drivers/i2c/busses/i2c-ali15x3.c | 8 ++++---- drivers/i2c/busses/i2c-amd756.c | 6 +++--- drivers/i2c/busses/i2c-amd8111.c | 6 +++--- drivers/i2c/busses/i2c-i801.c | 24 ++++++++++++------------ drivers/i2c/busses/i2c-isch.c | 6 +++--- drivers/i2c/busses/i2c-nforce2.c | 10 +++++----- drivers/i2c/busses/i2c-piix4.c | 20 ++++++++++---------- drivers/i2c/busses/i2c-sis5595.c | 4 ++-- drivers/i2c/busses/i2c-sis630.c | 8 ++++---- drivers/i2c/busses/i2c-via.c | 6 +++--- drivers/i2c/busses/i2c-viapro.c | 2 +- 12 files changed, 54 insertions(+), 54 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c index 125cd8e..3f49181 100644 --- a/drivers/i2c/busses/i2c-ali1535.c +++ b/drivers/i2c/busses/i2c-ali1535.c @@ -139,7 +139,7 @@ static unsigned short ali1535_offset; Note the differences between kernels with the old PCI BIOS interface and newer kernels with the real PCI interface. In compat.h some things are defined to make the transition easier. */ -static int __devinit ali1535_setup(struct pci_dev *dev) +static int ali1535_setup(struct pci_dev *dev) { int retval; unsigned char temp; @@ -502,7 +502,7 @@ static DEFINE_PCI_DEVICE_TABLE(ali1535_ids) = { MODULE_DEVICE_TABLE(pci, ali1535_ids); -static int __devinit ali1535_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int ali1535_probe(struct pci_dev *dev, const struct pci_device_id *id) { if (ali1535_setup(dev)) { dev_warn(&dev->dev, @@ -518,7 +518,7 @@ static int __devinit ali1535_probe(struct pci_dev *dev, const struct pci_device_ return i2c_add_adapter(&ali1535_adapter); } -static void __devexit ali1535_remove(struct pci_dev *dev) +static void ali1535_remove(struct pci_dev *dev) { i2c_del_adapter(&ali1535_adapter); release_region(ali1535_smba, ALI1535_SMB_IOSIZE); @@ -528,7 +528,7 @@ static struct pci_driver ali1535_driver = { .name = "ali1535_smbus", .id_table = ali1535_ids, .probe = ali1535_probe, - .remove = __devexit_p(ali1535_remove), + .remove = ali1535_remove, }; module_pci_driver(ali1535_driver); diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c index ce8d26d..26bcc61 100644 --- a/drivers/i2c/busses/i2c-ali15x3.c +++ b/drivers/i2c/busses/i2c-ali15x3.c @@ -131,7 +131,7 @@ MODULE_PARM_DESC(force_addr, static struct pci_driver ali15x3_driver; static unsigned short ali15x3_smba; -static int __devinit ali15x3_setup(struct pci_dev *ALI15X3_dev) +static int ali15x3_setup(struct pci_dev *ALI15X3_dev) { u16 a; unsigned char temp; @@ -484,7 +484,7 @@ static DEFINE_PCI_DEVICE_TABLE(ali15x3_ids) = { MODULE_DEVICE_TABLE (pci, ali15x3_ids); -static int __devinit ali15x3_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int ali15x3_probe(struct pci_dev *dev, const struct pci_device_id *id) { if (ali15x3_setup(dev)) { dev_err(&dev->dev, @@ -500,7 +500,7 @@ static int __devinit ali15x3_probe(struct pci_dev *dev, const struct pci_device_ return i2c_add_adapter(&ali15x3_adapter); } -static void __devexit ali15x3_remove(struct pci_dev *dev) +static void ali15x3_remove(struct pci_dev *dev) { i2c_del_adapter(&ali15x3_adapter); release_region(ali15x3_smba, ALI15X3_SMB_IOSIZE); @@ -510,7 +510,7 @@ static struct pci_driver ali15x3_driver = { .name = "ali15x3_smbus", .id_table = ali15x3_ids, .probe = ali15x3_probe, - .remove = __devexit_p(ali15x3_remove), + .remove = ali15x3_remove, }; module_pci_driver(ali15x3_driver); diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c index 304aa03..c98af91 100644 --- a/drivers/i2c/busses/i2c-amd756.c +++ b/drivers/i2c/busses/i2c-amd756.c @@ -324,7 +324,7 @@ static DEFINE_PCI_DEVICE_TABLE(amd756_ids) = { MODULE_DEVICE_TABLE (pci, amd756_ids); -static int __devinit amd756_probe(struct pci_dev *pdev, +static int amd756_probe(struct pci_dev *pdev, const struct pci_device_id *id) { int nforce = (id->driver_data == NFORCE); @@ -397,7 +397,7 @@ static int __devinit amd756_probe(struct pci_dev *pdev, return error; } -static void __devexit amd756_remove(struct pci_dev *dev) +static void amd756_remove(struct pci_dev *dev) { i2c_del_adapter(&amd756_smbus); release_region(amd756_ioport, SMB_IOSIZE); @@ -407,7 +407,7 @@ static struct pci_driver amd756_driver = { .name = "amd756_smbus", .id_table = amd756_ids, .probe = amd756_probe, - .remove = __devexit_p(amd756_remove), + .remove = amd756_remove, }; module_pci_driver(amd756_driver); diff --git a/drivers/i2c/busses/i2c-amd8111.c b/drivers/i2c/busses/i2c-amd8111.c index 0919ac1..b5c86c0 100644 --- a/drivers/i2c/busses/i2c-amd8111.c +++ b/drivers/i2c/busses/i2c-amd8111.c @@ -422,7 +422,7 @@ static DEFINE_PCI_DEVICE_TABLE(amd8111_ids) = { MODULE_DEVICE_TABLE (pci, amd8111_ids); -static int __devinit amd8111_probe(struct pci_dev *dev, +static int amd8111_probe(struct pci_dev *dev, const struct pci_device_id *id) { struct amd_smbus *smbus; @@ -475,7 +475,7 @@ static int __devinit amd8111_probe(struct pci_dev *dev, return error; } -static void __devexit amd8111_remove(struct pci_dev *dev) +static void amd8111_remove(struct pci_dev *dev) { struct amd_smbus *smbus = pci_get_drvdata(dev); @@ -488,7 +488,7 @@ static struct pci_driver amd8111_driver = { .name = "amd8111_smbus2", .id_table = amd8111_ids, .probe = amd8111_probe, - .remove = __devexit_p(amd8111_remove), + .remove = amd8111_remove, }; module_pci_driver(amd8111_driver); diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 1e73638..6c5a732 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -841,13 +841,13 @@ struct dmi_onboard_device_info { const char *i2c_type; }; -static struct dmi_onboard_device_info __devinitdata dmi_devices[] = { +static struct dmi_onboard_device_info dmi_devices[] = { { "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" }, { "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" }, { "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" }, }; -static void __devinit dmi_check_onboard_device(u8 type, const char *name, +static void dmi_check_onboard_device(u8 type, const char *name, struct i2c_adapter *adap) { int i; @@ -871,7 +871,7 @@ static void __devinit dmi_check_onboard_device(u8 type, const char *name, /* We use our own function to check for onboard devices instead of dmi_find_device() as some buggy BIOS's have the devices we are interested in marked as disabled */ -static void __devinit dmi_check_onboard_devices(const struct dmi_header *dm, +static void dmi_check_onboard_devices(const struct dmi_header *dm, void *adap) { int i, count; @@ -901,7 +901,7 @@ static void __devinit dmi_check_onboard_devices(const struct dmi_header *dm, } /* Register optional slaves */ -static void __devinit i801_probe_optional_slaves(struct i801_priv *priv) +static void i801_probe_optional_slaves(struct i801_priv *priv) { /* Only register slaves on main SMBus channel */ if (priv->features & FEATURE_IDF) @@ -921,7 +921,7 @@ static void __devinit i801_probe_optional_slaves(struct i801_priv *priv) } #else static void __init input_apanel_init(void) {} -static void __devinit i801_probe_optional_slaves(struct i801_priv *priv) {} +static void i801_probe_optional_slaves(struct i801_priv *priv) {} #endif /* CONFIG_X86 && CONFIG_DMI */ #if (defined CONFIG_I2C_MUX_GPIO || defined CONFIG_I2C_MUX_GPIO_MODULE) && \ @@ -944,7 +944,7 @@ static struct i801_mux_config i801_mux_config_asus_z8_d18 = { .n_gpios = 2, }; -static struct dmi_system_id __devinitdata mux_dmi_table[] = { +static struct dmi_system_id mux_dmi_table[] = { { .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), @@ -1012,7 +1012,7 @@ static struct dmi_system_id __devinitdata mux_dmi_table[] = { }; /* Setup multiplexing if needed */ -static int __devinit i801_add_mux(struct i801_priv *priv) +static int i801_add_mux(struct i801_priv *priv) { struct device *dev = &priv->adapter.dev; const struct i801_mux_config *mux_config; @@ -1048,13 +1048,13 @@ static int __devinit i801_add_mux(struct i801_priv *priv) return 0; } -static void __devexit i801_del_mux(struct i801_priv *priv) +static void i801_del_mux(struct i801_priv *priv) { if (priv->mux_pdev) platform_device_unregister(priv->mux_pdev); } -static unsigned int __devinit i801_get_adapter_class(struct i801_priv *priv) +static unsigned int i801_get_adapter_class(struct i801_priv *priv) { const struct dmi_system_id *id; const struct i801_mux_config *mux_config; @@ -1084,7 +1084,7 @@ static inline unsigned int i801_get_adapter_class(struct i801_priv *priv) } #endif -static int __devinit i801_probe(struct pci_dev *dev, +static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) { unsigned char temp; @@ -1226,7 +1226,7 @@ exit: return err; } -static void __devexit i801_remove(struct pci_dev *dev) +static void i801_remove(struct pci_dev *dev) { struct i801_priv *priv = pci_get_drvdata(dev); @@ -1272,7 +1272,7 @@ static struct pci_driver i801_driver = { .name = "i801_smbus", .id_table = i801_ids, .probe = i801_probe, - .remove = __devexit_p(i801_remove), + .remove = i801_remove, .suspend = i801_suspend, .resume = i801_resume, }; diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c index f90a605..4099f79 100644 --- a/drivers/i2c/busses/i2c-isch.c +++ b/drivers/i2c/busses/i2c-isch.c @@ -249,7 +249,7 @@ static struct i2c_adapter sch_adapter = { .algo = &smbus_algorithm, }; -static int __devinit smbus_sch_probe(struct platform_device *dev) +static int smbus_sch_probe(struct platform_device *dev) { struct resource *res; int retval; @@ -284,7 +284,7 @@ static int __devinit smbus_sch_probe(struct platform_device *dev) return retval; } -static int __devexit smbus_sch_remove(struct platform_device *pdev) +static int smbus_sch_remove(struct platform_device *pdev) { struct resource *res; if (sch_smba) { @@ -303,7 +303,7 @@ static struct platform_driver smbus_sch_driver = { .owner = THIS_MODULE, }, .probe = smbus_sch_probe, - .remove = __devexit_p(smbus_sch_remove), + .remove = smbus_sch_remove, }; module_platform_driver(smbus_sch_driver); diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c index 392303b..fbea3cf 100644 --- a/drivers/i2c/busses/i2c-nforce2.c +++ b/drivers/i2c/busses/i2c-nforce2.c @@ -117,7 +117,7 @@ struct nforce2_smbus { #define MAX_TIMEOUT 100 /* We disable the second SMBus channel on these boards */ -static struct dmi_system_id __devinitdata nforce2_dmi_blacklist2[] = { +static struct dmi_system_id nforce2_dmi_blacklist2[] = { { .ident = "DFI Lanparty NF4 Expert", .matches = { @@ -330,7 +330,7 @@ static DEFINE_PCI_DEVICE_TABLE(nforce2_ids) = { MODULE_DEVICE_TABLE (pci, nforce2_ids); -static int __devinit nforce2_probe_smb (struct pci_dev *dev, int bar, +static int nforce2_probe_smb (struct pci_dev *dev, int bar, int alt_reg, struct nforce2_smbus *smbus, const char *name) { int error; @@ -382,7 +382,7 @@ static int __devinit nforce2_probe_smb (struct pci_dev *dev, int bar, } -static int __devinit nforce2_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int nforce2_probe(struct pci_dev *dev, const struct pci_device_id *id) { struct nforce2_smbus *smbuses; int res1, res2; @@ -430,7 +430,7 @@ static int __devinit nforce2_probe(struct pci_dev *dev, const struct pci_device_ } -static void __devexit nforce2_remove(struct pci_dev *dev) +static void nforce2_remove(struct pci_dev *dev) { struct nforce2_smbus *smbuses = pci_get_drvdata(dev); @@ -450,7 +450,7 @@ static struct pci_driver nforce2_driver = { .name = "nForce2_smbus", .id_table = nforce2_ids, .probe = nforce2_probe, - .remove = __devexit_p(nforce2_remove), + .remove = nforce2_remove, }; module_pci_driver(nforce2_driver); diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c index f7216ed..80c5d9e 100644 --- a/drivers/i2c/busses/i2c-piix4.c +++ b/drivers/i2c/busses/i2c-piix4.c @@ -99,7 +99,7 @@ MODULE_PARM_DESC(force_addr, static int srvrworks_csb5_delay; static struct pci_driver piix4_driver; -static struct dmi_system_id __devinitdata piix4_dmi_blacklist[] = { +static struct dmi_system_id piix4_dmi_blacklist[] = { { .ident = "Sapphire AM2RD790", .matches = { @@ -119,7 +119,7 @@ static struct dmi_system_id __devinitdata piix4_dmi_blacklist[] = { /* The IBM entry is in a separate table because we only check it on Intel-based systems */ -static struct dmi_system_id __devinitdata piix4_dmi_ibm[] = { +static struct dmi_system_id piix4_dmi_ibm[] = { { .ident = "IBM", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "IBM"), }, @@ -131,7 +131,7 @@ struct i2c_piix4_adapdata { unsigned short smba; }; -static int __devinit piix4_setup(struct pci_dev *PIIX4_dev, +static int piix4_setup(struct pci_dev *PIIX4_dev, const struct pci_device_id *id) { unsigned char temp; @@ -230,7 +230,7 @@ static int __devinit piix4_setup(struct pci_dev *PIIX4_dev, return piix4_smba; } -static int __devinit piix4_setup_sb800(struct pci_dev *PIIX4_dev, +static int piix4_setup_sb800(struct pci_dev *PIIX4_dev, const struct pci_device_id *id) { unsigned short piix4_smba; @@ -294,7 +294,7 @@ static int __devinit piix4_setup_sb800(struct pci_dev *PIIX4_dev, return piix4_smba; } -static int __devinit piix4_setup_aux(struct pci_dev *PIIX4_dev, +static int piix4_setup_aux(struct pci_dev *PIIX4_dev, const struct pci_device_id *id, unsigned short base_reg_addr) { @@ -540,7 +540,7 @@ MODULE_DEVICE_TABLE (pci, piix4_ids); static struct i2c_adapter *piix4_main_adapter; static struct i2c_adapter *piix4_aux_adapter; -static int __devinit piix4_add_adapter(struct pci_dev *dev, +static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba, struct i2c_adapter **padap) { @@ -588,7 +588,7 @@ static int __devinit piix4_add_adapter(struct pci_dev *dev, return 0; } -static int __devinit piix4_probe(struct pci_dev *dev, +static int piix4_probe(struct pci_dev *dev, const struct pci_device_id *id) { int retval; @@ -626,7 +626,7 @@ static int __devinit piix4_probe(struct pci_dev *dev, return 0; } -static void __devexit piix4_adap_remove(struct i2c_adapter *adap) +static void piix4_adap_remove(struct i2c_adapter *adap) { struct i2c_piix4_adapdata *adapdata = i2c_get_adapdata(adap); @@ -638,7 +638,7 @@ static void __devexit piix4_adap_remove(struct i2c_adapter *adap) } } -static void __devexit piix4_remove(struct pci_dev *dev) +static void piix4_remove(struct pci_dev *dev) { if (piix4_main_adapter) { piix4_adap_remove(piix4_main_adapter); @@ -655,7 +655,7 @@ static struct pci_driver piix4_driver = { .name = "piix4_smbus", .id_table = piix4_ids, .probe = piix4_probe, - .remove = __devexit_p(piix4_remove), + .remove = piix4_remove, }; module_pci_driver(piix4_driver); diff --git a/drivers/i2c/busses/i2c-sis5595.c b/drivers/i2c/busses/i2c-sis5595.c index 87e5126..79fd96a 100644 --- a/drivers/i2c/busses/i2c-sis5595.c +++ b/drivers/i2c/busses/i2c-sis5595.c @@ -142,7 +142,7 @@ static void sis5595_write(u8 reg, u8 data) outb(data, sis5595_base + SMB_DAT); } -static int __devinit sis5595_setup(struct pci_dev *SIS5595_dev) +static int sis5595_setup(struct pci_dev *SIS5595_dev) { u16 a; u8 val; @@ -376,7 +376,7 @@ static DEFINE_PCI_DEVICE_TABLE(sis5595_ids) = { MODULE_DEVICE_TABLE (pci, sis5595_ids); -static int __devinit sis5595_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int sis5595_probe(struct pci_dev *dev, const struct pci_device_id *id) { int err; diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c index 5d6723b..de6dddb 100644 --- a/drivers/i2c/busses/i2c-sis630.c +++ b/drivers/i2c/busses/i2c-sis630.c @@ -389,7 +389,7 @@ static u32 sis630_func(struct i2c_adapter *adapter) I2C_FUNC_SMBUS_BLOCK_DATA; } -static int __devinit sis630_setup(struct pci_dev *sis630_dev) +static int sis630_setup(struct pci_dev *sis630_dev) { unsigned char b; struct pci_dev *dummy = NULL; @@ -480,7 +480,7 @@ static DEFINE_PCI_DEVICE_TABLE(sis630_ids) = { MODULE_DEVICE_TABLE (pci, sis630_ids); -static int __devinit sis630_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int sis630_probe(struct pci_dev *dev, const struct pci_device_id *id) { if (sis630_setup(dev)) { dev_err(&dev->dev, "SIS630 comp. bus not detected, module not inserted.\n"); @@ -496,7 +496,7 @@ static int __devinit sis630_probe(struct pci_dev *dev, const struct pci_device_i return i2c_add_adapter(&sis630_adapter); } -static void __devexit sis630_remove(struct pci_dev *dev) +static void sis630_remove(struct pci_dev *dev) { if (acpi_base) { i2c_del_adapter(&sis630_adapter); @@ -510,7 +510,7 @@ static struct pci_driver sis630_driver = { .name = "sis630_smbus", .id_table = sis630_ids, .probe = sis630_probe, - .remove = __devexit_p(sis630_remove), + .remove = sis630_remove, }; module_pci_driver(sis630_driver); diff --git a/drivers/i2c/busses/i2c-via.c b/drivers/i2c/busses/i2c-via.c index 7ffee71..be66251 100644 --- a/drivers/i2c/busses/i2c-via.c +++ b/drivers/i2c/busses/i2c-via.c @@ -96,7 +96,7 @@ static DEFINE_PCI_DEVICE_TABLE(vt586b_ids) = { MODULE_DEVICE_TABLE (pci, vt586b_ids); -static int __devinit vt586b_probe(struct pci_dev *dev, const struct pci_device_id *id) +static int vt586b_probe(struct pci_dev *dev, const struct pci_device_id *id) { u16 base; u8 rev; @@ -146,7 +146,7 @@ static int __devinit vt586b_probe(struct pci_dev *dev, const struct pci_device_i return 0; } -static void __devexit vt586b_remove(struct pci_dev *dev) +static void vt586b_remove(struct pci_dev *dev) { i2c_del_adapter(&vt586b_adapter); release_region(I2C_DIR, IOSPACE); @@ -158,7 +158,7 @@ static struct pci_driver vt586b_driver = { .name = "vt586b_smbus", .id_table = vt586b_ids, .probe = vt586b_probe, - .remove = __devexit_p(vt586b_remove), + .remove = vt586b_remove, }; module_pci_driver(vt586b_driver); diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c index 271c9a2..3426196 100644 --- a/drivers/i2c/busses/i2c-viapro.c +++ b/drivers/i2c/busses/i2c-viapro.c @@ -320,7 +320,7 @@ static struct i2c_adapter vt596_adapter = { .algo = &smbus_algorithm, }; -static int __devinit vt596_probe(struct pci_dev *pdev, +static int vt596_probe(struct pci_dev *pdev, const struct pci_device_id *id) { unsigned char temp; -- 1.8.0.1 ^ permalink raw reply related [flat|nested] 33+ messages in thread
[parent not found: <1354049993-12718-17-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>]
* Re: [PATCH 16/16] i2c: SMBus: remove __dev* attributes [not found] ` <1354049993-12718-17-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> @ 2012-11-28 13:23 ` Jean Delvare [not found] ` <20121128142349.629db0c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> 2012-11-28 13:32 ` Jean Delvare 1 sibling, 1 reply; 33+ messages in thread From: Jean Delvare @ 2012-11-28 13:23 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Hi Bill, On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option. As result the __dev* > markings will be going away. > > Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit. > > Signed-off-by: Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> > Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> > --- > drivers/i2c/busses/i2c-ali1535.c | 8 ++++---- > drivers/i2c/busses/i2c-ali15x3.c | 8 ++++---- > drivers/i2c/busses/i2c-amd756.c | 6 +++--- > drivers/i2c/busses/i2c-amd8111.c | 6 +++--- > drivers/i2c/busses/i2c-i801.c | 24 ++++++++++++------------ > drivers/i2c/busses/i2c-isch.c | 6 +++--- > drivers/i2c/busses/i2c-nforce2.c | 10 +++++----- > drivers/i2c/busses/i2c-piix4.c | 20 ++++++++++---------- > drivers/i2c/busses/i2c-sis5595.c | 4 ++-- > drivers/i2c/busses/i2c-sis630.c | 8 ++++---- > drivers/i2c/busses/i2c-via.c | 6 +++--- > drivers/i2c/busses/i2c-viapro.c | 2 +- > 12 files changed, 54 insertions(+), 54 deletions(-) Looks mostly OK, just two suggestions: > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index 1e73638..6c5a732 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -841,13 +841,13 @@ struct dmi_onboard_device_info { > const char *i2c_type; > }; > > -static struct dmi_onboard_device_info __devinitdata dmi_devices[] = { > +static struct dmi_onboard_device_info dmi_devices[] = { > { "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" }, > { "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" }, > { "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" }, > }; If I remember correctly, the only reason why this wasn't declared const was because this was not compatible with __devinitdata. Now that __devinitdata is gone, the leading "static" should become "static const". Same goes for the 4 other occurrences in this patch, and I suppose, many other cases in other subsystems. > diff --git a/drivers/i2c/busses/i2c-viapro.c b/drivers/i2c/busses/i2c-viapro.c > index 271c9a2..3426196 100644 > --- a/drivers/i2c/busses/i2c-viapro.c > +++ b/drivers/i2c/busses/i2c-viapro.c > @@ -320,7 +320,7 @@ static struct i2c_adapter vt596_adapter = { > .algo = &smbus_algorithm, > }; > > -static int __devinit vt596_probe(struct pci_dev *pdev, > +static int vt596_probe(struct pci_dev *pdev, > const struct pci_device_id *id) > { > unsigned char temp; Now this would fit on a single line. There are many other occurrences of this. I know this can't be easily automated, but it would be great if your patches could put the code back on the previous line when this is possible. -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <20121128142349.629db0c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>]
* Re: [PATCH 16/16] i2c: SMBus: remove __dev* attributes [not found] ` <20121128142349.629db0c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> @ 2012-11-28 13:54 ` Bill Pemberton [not found] ` <20121128135448.5319580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> 0 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-28 13:54 UTC (permalink / raw) To: Jean Delvare Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Jean Delvare writes: > > Hi Bill, > > On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote: > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > > index 1e73638..6c5a732 100644 > > --- a/drivers/i2c/busses/i2c-i801.c > > +++ b/drivers/i2c/busses/i2c-i801.c > > @@ -841,13 +841,13 @@ struct dmi_onboard_device_info { > > const char *i2c_type; > > }; > > > > -static struct dmi_onboard_device_info __devinitdata dmi_devices[] = { > > +static struct dmi_onboard_device_info dmi_devices[] = { > > { "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" }, > > { "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" }, > > { "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" }, > > }; > > If I remember correctly, the only reason why this wasn't declared const > was because this was not compatible with __devinitdata. Now that > __devinitdata is gone, the leading "static" should become "static > const". Same goes for the 4 other occurrences in this patch, and I > suppose, many other cases in other subsystems. > Ok, do you want it resent with that change included? (along with the checkpatch changes, of course). -- Bill ^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <20121128135448.5319580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org>]
* Re: [PATCH 16/16] i2c: SMBus: remove __dev* attributes [not found] ` <20121128135448.5319580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> @ 2012-11-28 14:07 ` Jean Delvare 0 siblings, 0 replies; 33+ messages in thread From: Jean Delvare @ 2012-11-28 14:07 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r On Wed, 28 Nov 2012 08:54:48 -0500, Bill Pemberton wrote: > Jean Delvare writes: > > > > Hi Bill, > > > > On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote: > > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > > > index 1e73638..6c5a732 100644 > > > --- a/drivers/i2c/busses/i2c-i801.c > > > +++ b/drivers/i2c/busses/i2c-i801.c > > > @@ -841,13 +841,13 @@ struct dmi_onboard_device_info { > > > const char *i2c_type; > > > }; > > > > > > -static struct dmi_onboard_device_info __devinitdata dmi_devices[] = { > > > +static struct dmi_onboard_device_info dmi_devices[] = { > > > { "Syleus", DMI_DEV_TYPE_OTHER, 0x73, "fscsyl" }, > > > { "Hermes", DMI_DEV_TYPE_OTHER, 0x73, "fscher" }, > > > { "Hades", DMI_DEV_TYPE_OTHER, 0x73, "fschds" }, > > > }; > > > > If I remember correctly, the only reason why this wasn't declared const > > was because this was not compatible with __devinitdata. Now that > > __devinitdata is gone, the leading "static" should become "static > > const". Same goes for the 4 other occurrences in this patch, and I > > suppose, many other cases in other subsystems. > > > > Ok, do you want it resent with that change included? (along with the > checkpatch changes, of course). Yes please. Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 16/16] i2c: SMBus: remove __dev* attributes [not found] ` <1354049993-12718-17-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 13:23 ` Jean Delvare @ 2012-11-28 13:32 ` Jean Delvare 1 sibling, 0 replies; 33+ messages in thread From: Jean Delvare @ 2012-11-28 13:32 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Oh, BTW... On Tue, 27 Nov 2012 15:59:53 -0500, Bill Pemberton wrote: > diff --git a/drivers/i2c/busses/i2c-nforce2.c b/drivers/i2c/busses/i2c-nforce2.c > index 392303b..fbea3cf 100644 > --- a/drivers/i2c/busses/i2c-nforce2.c > +++ b/drivers/i2c/busses/i2c-nforce2.c > @@ -117,7 +117,7 @@ struct nforce2_smbus { > #define MAX_TIMEOUT 100 > > /* We disable the second SMBus channel on these boards */ > -static struct dmi_system_id __devinitdata nforce2_dmi_blacklist2[] = { > +static struct dmi_system_id nforce2_dmi_blacklist2[] = { > { > .ident = "DFI Lanparty NF4 Expert", > .matches = { > @@ -330,7 +330,7 @@ static DEFINE_PCI_DEVICE_TABLE(nforce2_ids) = { > MODULE_DEVICE_TABLE (pci, nforce2_ids); > > > -static int __devinit nforce2_probe_smb (struct pci_dev *dev, int bar, > +static int nforce2_probe_smb (struct pci_dev *dev, int bar, > int alt_reg, struct nforce2_smbus *smbus, const char *name) > { > int error; There is a checkpatch warning reported here: WARNING: space prohibited between function name and open parenthesis '(' #390: FILE: drivers/i2c/busses/i2c-nforce2.c:333: +static int nforce2_probe_smb (struct pci_dev *dev, int bar, Please fix while you're here. Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 33+ messages in thread
* Re: [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> ` (14 preceding siblings ...) 2012-11-27 20:59 ` [PATCH 16/16] i2c: SMBus: " Bill Pemberton @ 2012-11-28 10:47 ` Wolfram Sang [not found] ` <20121128104716.GC14238-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 15 siblings, 1 reply; 33+ messages in thread From: Wolfram Sang @ 2012-11-28 10:47 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 655 bytes --] On Tue, Nov 27, 2012 at 03:59:37PM -0500, Bill Pemberton wrote: > This is a respin of the patches to remove the __dev* attributes in the > i2c subsystem. > > The attributes __devinit, __devexit_p, __devinitdata, __devinitconst, > and __devexit are no longer needed since CONFIG_HOTPLUG is being > removed as an option. Thanks. Will wait one more day for acks, then probably squash them into one and make this the last commit for 3.8. Is that okay with you? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <20121128104716.GC14238-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH 00/16] i2c: remove __dev* attributes for retirement of [not found] ` <20121128104716.GC14238-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2012-11-28 13:51 ` Bill Pemberton [not found] ` <20121128135146.74D0580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> 0 siblings, 1 reply; 33+ messages in thread From: Bill Pemberton @ 2012-11-28 13:51 UTC (permalink / raw) To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r Wolfram Sang writes: > > > --iFRdW5/EC4oqxDHL > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Tue, Nov 27, 2012 at 03:59:37PM -0500, Bill Pemberton wrote: > > This is a respin of the patches to remove the __dev* attributes in the > > i2c subsystem. > >=20 > > The attributes __devinit, __devexit_p, __devinitdata, __devinitconst, > > and __devexit are no longer needed since CONFIG_HOTPLUG is being > > removed as an option. > > Thanks. Will wait one more day for acks, then probably squash them into > one and make this the last commit for 3.8. Is that okay with you? > There are two where a little manual checkpatch cleanup were requested. I'll clean those up and resend those two (unless you want the whole series resent). -- Bill ^ permalink raw reply [flat|nested] 33+ messages in thread
[parent not found: <20121128135146.74D0580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org>]
* Re: [PATCH 00/16] i2c: remove __dev* attributes for retirement of [not found] ` <20121128135146.74D0580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> @ 2012-11-28 13:52 ` Wolfram Sang 0 siblings, 0 replies; 33+ messages in thread From: Wolfram Sang @ 2012-11-28 13:52 UTC (permalink / raw) To: Bill Pemberton Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 1131 bytes --] On Wed, Nov 28, 2012 at 08:51:46AM -0500, Bill Pemberton wrote: > Wolfram Sang writes: > > > > > > --iFRdW5/EC4oqxDHL > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Tue, Nov 27, 2012 at 03:59:37PM -0500, Bill Pemberton wrote: > > > This is a respin of the patches to remove the __dev* attributes in the > > > i2c subsystem. > > >=20 > > > The attributes __devinit, __devexit_p, __devinitdata, __devinitconst, > > > and __devexit are no longer needed since CONFIG_HOTPLUG is being > > > removed as an option. > > > > Thanks. Will wait one more day for acks, then probably squash them into > > one and make this the last commit for 3.8. Is that okay with you? > > > > There are two where a little manual checkpatch cleanup were requested. > I'll clean those up and resend those two (unless you want the whole > series resent). Not necessary, thanks! -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 33+ messages in thread
end of thread, other threads:[~2012-11-29 1:22 UTC | newest] Thread overview: 33+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-11-27 20:59 [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG Bill Pemberton 2012-11-27 20:59 ` [PATCH 05/16] i2c: i2c-cpm: remove __dev* attributes Bill Pemberton [not found] ` <1354049993-12718-1-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 20:59 ` [PATCH 01/16] i2c/busses: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 02/16] i2c: mux-gpio: " Bill Pemberton [not found] ` <1354049993-12718-3-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 22:44 ` Peter Korsgaard 2012-11-27 20:59 ` [PATCH 03/16] i2c: pnx: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 04/16] i2c: scx200_acb: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 06/16] i2c: i2c-gpio: " Bill Pemberton [not found] ` <1354049993-12718-7-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 22:22 ` Håvard Skinnemoen 2012-11-27 20:59 ` [PATCH 07/16] i2c: i2c-parport-light: " Bill Pemberton [not found] ` <1354049993-12718-8-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 12:28 ` Jean Delvare 2012-11-27 20:59 ` [PATCH 08/16] i2c: ocores: " Bill Pemberton [not found] ` <1354049993-12718-9-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-27 22:55 ` Peter Korsgaard 2012-11-27 20:59 ` [PATCH 09/16] i2c: omap: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 10/16] i2c: pca: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 11/16] i2c: puv3: " Bill Pemberton [not found] ` <1354049993-12718-12-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-29 1:22 ` guanxuetao-TG0Ac1+ktVePQbnJrJN+5g 2012-11-27 20:59 ` [PATCH 12/16] i2c: i2c-pasemi: " Bill Pemberton 2012-11-27 20:59 ` [PATCH 13/16] i2c: sirf: " Bill Pemberton [not found] ` <1354049993-12718-14-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 2:45 ` Barry Song 2012-11-27 20:59 ` [PATCH 14/16] i2c-ali1563: " Bill Pemberton [not found] ` <1354049993-12718-15-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 12:31 ` Jean Delvare [not found] ` <20121128133153.700e84a8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> 2012-11-28 13:48 ` Bill Pemberton 2012-11-27 20:59 ` [PATCH 15/16] i2c-sis96x: " Bill Pemberton [not found] ` <1354049993-12718-16-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 12:33 ` Jean Delvare 2012-11-27 20:59 ` [PATCH 16/16] i2c: SMBus: " Bill Pemberton [not found] ` <1354049993-12718-17-git-send-email-wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org> 2012-11-28 13:23 ` Jean Delvare [not found] ` <20121128142349.629db0c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> 2012-11-28 13:54 ` Bill Pemberton [not found] ` <20121128135448.5319580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> 2012-11-28 14:07 ` Jean Delvare 2012-11-28 13:32 ` Jean Delvare 2012-11-28 10:47 ` [PATCH 00/16] i2c: remove __dev* attributes for retirement of HOTPLUG Wolfram Sang [not found] ` <20121128104716.GC14238-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2012-11-28 13:51 ` [PATCH 00/16] i2c: remove __dev* attributes for retirement of Bill Pemberton [not found] ` <20121128135146.74D0580134-A/mCt7huS1Rvw44tLj6iNJvpjmsXDcsSh13vi7wywA4@public.gmane.org> 2012-11-28 13:52 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).