From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation Date: Sat, 1 Dec 2012 13:26:34 +0000 Message-ID: <20121201132632.GA17981@opensource.wolfsonmicro.com> References: <1354165536-18529-1-git-send-email-ch.naveen@samsung.com> <1354165536-18529-3-git-send-email-ch.naveen@samsung.com> <20121129163448.GA3761@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Olof Johansson Cc: Simon Glass , Naveen Krishna Chatradhi , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, grundler@chromium.org, naveen@chromium.org, w.sang@pengutronix.de, linux-kernel@vger.kernel.org List-Id: linux-i2c@vger.kernel.org --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: > On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > > It was originally done separately but I think it was felt that this > > was overly complex. Olof can you please comment on this? > it is indeed not controller specific per se, but we are unaware of any > other platform/driver using it. So, it seemed reasonable to implement > it in the driver as long as we have only one user; if another one > comes along it's of course better to move it to the common i2c code. > At least that was my opinion at the time. I could be convinced > otherwise if someone else has strong opinions on the matter. This sort of approach is half the reason SPI ended up being so fun... I suspect if you look hard enough you'll find that this is just the first time someone tried to upstream such a scheme. This is all especially true for the DT bindings, even if the implementation is driver local for now it'd be better to define generic bindings. --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQugVFAAoJELSic+t+oim9ehkP/R2mcq/f9+07jA+ZiI7JdiDA FCWvfBFkb0zwCncKCC4qZhnIE9Iz/wBMxghCoJRuXM162Bpom+tswp5Uqu0jxQDD XF5HUwPdSEd3iFJUv/s+VXGJ2jLLU9Y15SfOT+NJhxTUtp7rUc63boJA4tzVNVoa xTmVKlPqH7CiBiFSkyvmAp9Be2La5S+9k9bPoRMKjFk9rnfDTIgdOV9WPdWltCD/ mAwmsjBdFK47l+t5xOmAMA207xc9TkIzMuaNuFAj67D3rcJ05RDfkzSjhPBScGxN 52/dV47fqhOdATB2oAbiCJ0dnMkPxKuYVpRdWpM3TInyNu+Ehl1lKG0T0QYMXXUE xiDITevkhxF7SWyMZK6E6M9mUwJi9axSyDYQDmC4y8NegsTO9QQVkhSn3RWU9ZKa 94cTONEvRiAOHd1wuQORmEqvS8mDM7YyMNThKxhVYe/4D+D001Yl2ZPHu7Ldw0rW ADIFyonv4IyCiq92YiymMJBRRCRJHXu9nXWChocJOKSe0gz9AFGSodsrzX8obpvz fxKi3hN6Z0tdEzJUA0nG4EICAUct9Z2mZ0mcFJtvlw7JRcaP16PA3nHZ3hFDW/Lq /yptAQDCxeM1B8bqiUg6xraXexmb+ke30fjsig89TMMw3yl44obAAyFTh0VAlcaY 7JFoUyqMtz+nxldhmh6N =83z5 -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI--