From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] HID: i2c-hid: add mutex protecting open/close race Date: Wed, 12 Dec 2012 17:34:44 +0100 Message-ID: <20121212173444.471d5cc6@endymion.delvare> References: <1355328736-31418-1-git-send-email-benjamin.tissoires@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1355328736-31418-1-git-send-email-benjamin.tissoires@gmail.com> Sender: linux-input-owner@vger.kernel.org To: Benjamin Tissoires Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-i2c@vger.kernel.org Hi Benjamin, On Wed, 12 Dec 2012 17:12:16 +0100, Benjamin Tissoires wrote: > We should not enter close function while someone else is in open. > This mutex prevents this race. > > There is also no need to override the ret value with -EIO in case of > a failure of i2c_hid_set_power. > > Signed-off-by: Benjamin Tissoires > --- Looks good to me except that you forgot to include and this could cause build failures on some architectures/configs. Once this is fixed, you can add: Reviewed-by: Jean Delvare -- Jean Delvare