linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2] i2c-i801: Enable interrupts for all post-ICH5 chips
Date: Sat, 15 Dec 2012 14:41:44 +0100	[thread overview]
Message-ID: <20121215144144.0922e012@endymion.delvare> (raw)
In-Reply-To: <CAGS+omCzK2mj6EsCQo1q4MRFHghMzWNfHZmn3DjZuPLfDkoZXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Daniel,

On Thu, 13 Dec 2012 09:53:10 +0800, Daniel Kurtz wrote:
> Hi Jean,
> 
> On Wed, Nov 7, 2012 at 3:38 AM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> > I did not receive a single bug report after interrupt support was
> > added for a limited number of chips. So I'd say the code is good and
> > should be enabled for all supported chips, that is: ICH5 and later.
> >
> > Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > Cc: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > ---
> > I was able to test on Patsburg IDF channels and although I couldn't
> > test all transaction types, interrupts seem to work the same as on the
> > main SMBus channel so let's enable interrupts there too.
> 
> 
> I can confirm that the IRQ works on PantherPoint at least, if enabled
> (by this patch, for example).  However, I don't know anything about
> IDF, so I can't help there.
> Here's an R-B, if you need it:
> 
> Reviewed-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Thanks for the testing and review.

> Are you targeting this for 3.8?

Yes I am. I'll send the remaining patches in my i2c queue to Linus
later today.

-- 
Jean Delvare

      parent reply	other threads:[~2012-12-15 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 11:03 [PATCH] i2c-i801: Enable interrupts for all post-ICH5 chips Jean Delvare
     [not found] ` <20121031120336.3229e1a2-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-11-06 19:38   ` [PATCH v2] " Jean Delvare
     [not found]     ` <20121106203803.6af84fc8-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-12-13  1:53       ` Daniel Kurtz
     [not found]         ` <CAGS+omCzK2mj6EsCQo1q4MRFHghMzWNfHZmn3DjZuPLfDkoZXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-15 13:41           ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121215144144.0922e012@endymion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).