linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Joachim Eastwood <manabian@gmail.com>
Cc: ludovic.desroches@atmel.com, nicolas.ferre@atmel.com,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: at91: add of_device_id entry for at91rm9200
Date: Tue, 18 Dec 2012 07:02:32 +0100	[thread overview]
Message-ID: <20121218060232.GL23971@game.jcrosoft.org> (raw)
In-Reply-To: <1354743732-11581-1-git-send-email-manabian@gmail.com>

On 22:42 Wed 05 Dec     , Joachim Eastwood wrote:
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> Hi,
> 
> AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
> 
> Tested on custom RM9200 board. Since the driver doesn't support pinctrl
> muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it
> to work.

IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45

it not recommended to use it instead use i2c-gpio

Best Regards,
J.
> 
> regards
> Joachim Eastwood
> 
>  drivers/i2c/busses/i2c-at91.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index b4575ee..c504aa8 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = {
>  #if defined(CONFIG_OF)
>  static const struct of_device_id atmel_twi_dt_ids[] = {
>  	{
> +		.compatible = "atmel,at91rm9200-i2c",
> +		.data = &at91rm9200_config,
> +	} , {
>  		.compatible = "atmel,at91sam9260-i2c",
>  		.data = &at91sam9260_config,
>  	} , {
> -- 
> 1.8.0
> 

  reply	other threads:[~2012-12-18  6:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-05 21:42 [PATCH] i2c: at91: add of_device_id entry for at91rm9200 Joachim Eastwood
2012-12-18  6:02 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
     [not found]   ` <20121218060232.GL23971-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
2013-01-24  7:27     ` Wolfram Sang
2013-01-24  7:58       ` ludovic.desroches
     [not found]         ` <5100E9A4.9020804-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-01-24  8:43           ` Joachim Eastwood
2013-01-24  9:09             ` ludovic.desroches
2013-01-24 10:13           ` Wolfram Sang
2013-01-24 10:44             ` ludovic.desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121218060232.GL23971@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=ludovic.desroches@atmel.com \
    --cc=manabian@gmail.com \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).