From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Cc: w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt
Date: Sun, 20 Jan 2013 11:19:17 +0200 [thread overview]
Message-ID: <20130120091917.GA16066@arwen.pp.htv.fi> (raw)
In-Reply-To: <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
Hi,
On Sun, Jan 20, 2013 at 02:32:58AM +0200, Aaro Koskinen wrote:
> The errata handling function acks wrong interrupt in case of "Arbitration
> lost". Fix it.
>
> Discovered during code review, the real impact of the bug is unknown.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
thanks for sending this
Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 20d41bf..832f16e 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -803,7 +803,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *dev)
> if (stat & OMAP_I2C_STAT_AL) {
> dev_err(dev->dev, "Arbitration lost\n");
> dev->cmd_err |= OMAP_I2C_STAT_AL;
> - omap_i2c_ack_stat(dev, OMAP_I2C_STAT_NACK);
> + omap_i2c_ack_stat(dev, OMAP_I2C_STAT_AL);
> }
>
> return -EIO;
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-20 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 0:32 [PATCH] i2c: omap: errata i462: fix incorrect ack for arbitration lost interrupt Aaro Koskinen
[not found] ` <1358641978-9316-1-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2013-01-20 9:19 ` Felipe Balbi [this message]
2013-01-23 9:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120091917.GA16066@arwen.pp.htv.fi \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox