[PATCH] i2c: i2c-mxs: Fix type of error code

[PATCH] i2c: i2c-mxs: Fix type of error code

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

cmd_err is used to handle error code, so it should not be unsigned.

This fixes the following warning when building with W=1 option:

drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 drivers/i2c/busses/i2c-mxs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 1b1a936..621153a 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -127,7 +127,7 @@ struct mxs_i2c_dev {
 	struct device *dev;
 	void __iomem *regs;
 	struct completion cmd_complete;
-	u32 cmd_err;
+	int cmd_err;
 	struct i2c_adapter adapter;
 	const struct mxs_i2c_speed_config *speed;
 
-- 
1.7.9.5

Re: [PATCH] i2c: i2c-mxs: Fix type of error code

[Marek Vasut]

Dear Fabio Estevam,

> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> cmd_err is used to handle error code, so it should not be unsigned.
> 
> This fixes the following warning when building with W=1 option:
> 
> drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
> drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Amazing catch

Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>

Can this also go to -stable 3.7 ?

> ---
>  drivers/i2c/busses/i2c-mxs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
> index 1b1a936..621153a 100644
> --- a/drivers/i2c/busses/i2c-mxs.c
> +++ b/drivers/i2c/busses/i2c-mxs.c
> @@ -127,7 +127,7 @@ struct mxs_i2c_dev {
>  	struct device *dev;
>  	void __iomem *regs;
>  	struct completion cmd_complete;
> -	u32 cmd_err;
> +	int cmd_err;
>  	struct i2c_adapter adapter;
>  	const struct mxs_i2c_speed_config *speed;

Best regards,
Marek Vasut

Re: [PATCH] i2c: i2c-mxs: Fix type of error code

[Wolfram Sang]

On Mon, Jan 07, 2013 at 10:32:06PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> cmd_err is used to handle error code, so it should not be unsigned.
> 
> This fixes the following warning when building with W=1 option:
> 
> drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
> drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Thanks! Applied to current and added stable.

Re: [PATCH] i2c: i2c-mxs: Fix type of error code

[Marek Vasut]

Dear Wolfram Sang,

> On Mon, Jan 07, 2013 at 10:32:06PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > 
> > cmd_err is used to handle error code, so it should not be unsigned.
> > 
> > This fixes the following warning when building with W=1 option:
> > 
> > drivers/i2c/busses/i2c-mxs.c: In function 'mxs_i2c_xfer_msg':
> > drivers/i2c/busses/i2c-mxs.c:331:19: warning: comparison between signed
> > and unsigned integer expressions [-Wsign-compare]
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> 
> Thanks! Applied to current and added stable.

I dont wanna be nagging, but you polling the linux-i2c stuff every 3 months or 
so doesn't make the development all that smooth. Btw. there are other patches 
(like the speed patch, like the pio/dma patch) which still keep hanging. I'd 
like to see them in 3.8, since they were submitted nearly three months ago.

I even bumped you about them every so often. Can you go through your mailbox 
please?

Best regards,
Marek Vasut

Re: [PATCH] i2c: i2c-mxs: Fix type of error code

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]


> I dont wanna be nagging, but you polling the linux-i2c stuff every 3 months or 
> so doesn't make the development all that smooth.

I surely know that, but I can't help it at the moment. I have reasonable
hopes that things will improve in a few weeks.

> (like the speed patch, like the pio/dma patch) which still keep hanging. I'd 
> like to see them in 3.8, since they were submitted nearly three months ago.

As I said, -next branch probably this weekend. I am already at it.

> I even bumped you about them every so often. Can you go through your mailbox 
> please?

I get all the mails, I don't necessarily answer them (costs time) if I
only can say "no time currently". If you want to help improving the
situation, feel free to review patches.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] i2c: i2c-mxs: Fix type of error code

[Marek Vasut]

Dear Wolfram Sang,

> > I dont wanna be nagging, but you polling the linux-i2c stuff every 3
> > months or so doesn't make the development all that smooth.
> 
> I surely know that, but I can't help it at the moment. I have reasonable
> hopes that things will improve in a few weeks.

Good.

> > (like the speed patch, like the pio/dma patch) which still keep hanging.
> > I'd like to see them in 3.8, since they were submitted nearly three
> > months ago.
> 
> As I said, -next branch probably this weekend. I am already at it.

Thanks

> > I even bumped you about them every so often. Can you go through your
> > mailbox please?
> 
> I get all the mails, I don't necessarily answer them (costs time) if I
> only can say "no time currently". If you want to help improving the
> situation, feel free to review patches.

Certainly, give me two weeks (until 6th), I'll be out of the gutter by then.

Best regards,
Marek Vasut