From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 1/2] misc/at24: Add at24c512b eeprom support Date: Wed, 23 Jan 2013 14:49:36 +0100 Message-ID: <20130123134936.GH16264@pengutronix.de> References: <1358922764-31654-1-git-send-email-Ying.Liu@freescale.com> <20130123125001.GG16264@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jHkwA2TBA/ec6v+" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Liu Ying Cc: Linus Walleij , Liu Ying , Arnd Bergmann , grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --9jHkwA2TBA/ec6v+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, > There are some difference between 24c512 and 24c512b about the system > reset procedure, according to the two devices' spec: > 24c512b:(a) Create a start bit condition, (b)clock 9 cycles, (c) > create another start bit followed by stop bit condition. > 24c512:(a) Clock up to 9 cycles, (b) look for SDA high in each cycle > while SCL is high and then, (c) create a start condition as SDA is > high. > Could this be a reason to add an entry for 24c512b? Since the entries in at24_ids[] are the same, no. If they would differ, that is a reason. > Now, I think the correct vendor name should be "at" or "atmel". "atmel" would be better, but the MX28EVK doesn't even have an I2C eeprom by default IIRC? But that is unrelated to your patch. --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --9jHkwA2TBA/ec6v+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlD/6nAACgkQD27XaX1/VRujjQCgizk93ZbdUIY58bq10r1v0fcX JJEAoIlX9fg77YanNxsIIQSzC7Fk0UWJ =u40C -----END PGP SIGNATURE----- --9jHkwA2TBA/ec6v+--