Re: [PATCH v2 6/6] Cleanup

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Fri,  4 Jan 2013 14:13:35 +0100, Amaury Decrême wrote:
> This patch corrects checkpatch errors.
> Some "80 columns" warnings have been expressly omitted to keep reading
> easy.

You can get rid of these too by splitting the affected lines. You do
not have to split the strings themselves, but the other parameters can
be on different lines. checkpatch.pl will be silent once you get this
right.

> The changes has also been removed as it has less meaning with version
> control tools.
> 
> Signed-off-by: Amaury Decrême <amaury.decreme-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-sis630.c |  175 ++++++++++++++++++---------------------
>  1 files changed, 82 insertions(+), 93 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
> index 4bc970d..ff08dde 100644
> --- a/drivers/i2c/busses/i2c-sis630.c
> +++ b/drivers/i2c/busses/i2c-sis630.c
> @@ -16,24 +16,6 @@
>      Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>  */
>  
> -/*
> -   Changes:
> -   24.08.2002
> -   	Fixed the typo in sis630_access (Thanks to Mark M. Hoffman)
> -	Changed sis630_transaction.(Thanks to Mark M. Hoffman)
> -   18.09.2002
> -	Added SIS730 as supported.
> -   21.09.2002
> -	Added high_clock module option.If this option is set
> -	used Host Master Clock 56KHz (default 14KHz).For now we save old Host
> -	Master Clock and after transaction completed restore (otherwise
> -	it's confuse BIOS and hung Machine).
> -   24.09.2002
> -	Fixed typo in sis630_access
> -	Fixed logical error by restoring of Host Master Clock
> -   31.07.2003
> -   	Added block data read/write support.
> -*/
>  

You can delete one more blank line.

>  /*
>     Status: beta
> @@ -150,9 +132,10 @@ static inline void sis630_write(u8 reg, u8 data)
>  	outb(data, smbus_base + reg);
>  }
>  
> -static int sis630_transaction_start(struct i2c_adapter *adap, int size, u8 *oldclock)
> +static int sis630_transaction_start(struct i2c_adapter *adap, int size,
> +								u8 *oldclock)
>  {
> -        u8 temp;
> +	u8 temp;

This doesn't apply as the change is already present in a previous patch.

>  
>  	/* Make sure the SMBus host is ready to start transmitting. */
>  	temp = sis630_read(SMB_CNT);
> (...)

All the rest looks good, thanks for doing that.

-- 
Jean Delvare