From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bill Brown <bill.e.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Seth Heasley
<seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v5] i2c: Adding support for Intel iSMT SMBus 2.0 host controller
Date: Wed, 30 Jan 2013 22:55:57 +0100 [thread overview]
Message-ID: <20130130225557.55b8eeee@endymion.delvare> (raw)
In-Reply-To: <20130130141504.GA2968-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
On Wed, 30 Jan 2013 09:15:04 -0500, Neil Horman wrote:
> On Tue, Jan 29, 2013 at 11:10:28PM +0100, Jean Delvare wrote:
> > This won't fix it, unless the hardware happens to update dma_size when
> > receiving a block from a slave. If not then dma_size will always be
> > I2C_SMBUS_BLOCK_MAX, while what we need is the number of bytes actually
> > received.
>
> I'm sorry, I misspoke. Its the rxbytes field in the descriptor that we need to use. I
> believe that field gets updated by the firmware on dmas from the device to the
> cpu.
I couldn't find a description of the hardware descriptor in the
datasheets, so I'm afraid I can't help here. If it is really there then
I'd be grateful if you can point me to the right file and page.
> (...)
> I'll have some tomorrow. I've got all your trivial changes fixed up, and will
> hopefully be able to sort out the convoluted stuff with you and Seth in the next
> few days
Great. I'll be happy to test whatever you have then.
--
Jean Delvare
next prev parent reply other threads:[~2013-01-30 21:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 0:36 [PATCH v4] i2c: Adding support for Intel iSMT SMBus 2.0 host controller Bill E Brown
[not found] ` <1354840604-8160-1-git-send-email-bill.e.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-12-07 0:34 ` Brown, Bill E
2012-12-18 14:03 ` Jean Delvare
[not found] ` <20121218150337.5b861ae3-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-01-28 19:43 ` [PATCH v5] " Neil Horman
[not found] ` <1359402232-21369-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2013-01-29 14:05 ` Jean Delvare
[not found] ` <20130129150551.498b2a9b-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-01-29 15:32 ` Neil Horman
[not found] ` <20130129153253.GA14044-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2013-01-29 22:10 ` Jean Delvare
[not found] ` <20130129231028.41b04fc9-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-01-30 14:15 ` Neil Horman
[not found] ` <20130130141504.GA2968-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org>
2013-01-30 21:55 ` Jean Delvare [this message]
2013-01-29 16:57 ` Heasley, Seth
[not found] ` <DEC3922D1904474A8862C7BFF516EA9A59B47EB2-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-01-29 18:52 ` Jean Delvare
2013-01-29 14:29 ` Jean Delvare
2013-02-01 19:48 ` [PATCH v6] " Neil Horman
[not found] ` <1359748083-24423-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2013-02-04 9:47 ` Jean Delvare
[not found] ` <20130204104744.5f83541e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-02-04 17:19 ` Jean Delvare
[not found] ` <20130204181902.06c247ad-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-02-04 17:28 ` Neil Horman
[not found] ` <20130204172851.GA24749-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2013-02-05 7:21 ` Jean Delvare
2013-02-04 19:54 ` [PATCH v7] " Neil Horman
[not found] ` <1360007650-26272-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2013-02-05 1:13 ` Heasley, Seth
[not found] ` <DEC3922D1904474A8862C7BFF516EA9A59B4A8B8-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-02-05 7:16 ` Jean Delvare
[not found] ` <20130205081642.5349bd1a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-02-05 14:52 ` Neil Horman
[not found] ` <20130205145230.GA4511-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2013-02-05 16:41 ` Jean Delvare
2013-02-05 16:41 ` Jean Delvare
2013-02-10 15:02 ` Wolfram Sang
[not found] ` <20130210150205.GB6282-8EAEigeeuNG034pCzgS/Qg7AFbiQbgqx@public.gmane.org>
2013-03-05 14:22 ` Neil Horman
[not found] ` <20130305142225.GA23095-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2013-03-05 14:42 ` Jean Delvare
[not found] ` <20130305154253.317bd23a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-03-05 16:09 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130225557.55b8eeee@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=bill.e.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).