linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
Cc: Wolfram Sang <wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: vt8500: Add support for Wondermedia I2C master-mode
Date: Thu, 14 Feb 2013 11:01:15 +0100	[thread overview]
Message-ID: <20130214100115.GA12290@nekote.pengutronix.de> (raw)
In-Reply-To: <1360798864.18078.21.camel@gitbox>

Hi Tony,

> 1) I am working on pinmux at the moment - will hold off on this driver
> until pinmux is completed.

Cool, great work!

> 2)
> > +	i2c_dev->clk = of_clk_get(np, 0);
> > 
> > There is also devm_clk_get.
> devm_clk_get requires a 'clock name'.
> Since vt8500 is DT-only, and clock-names is an optional property in the
> clocks binding I preferred not to *require* an optional property.

OK then. Just wanted to mention it.

Thanks,

   Wolfram

  reply	other threads:[~2013-02-14 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16  5:52 [GIT PULL] i2c: vt8500: Add support for Wondermedia I2C master-mode Tony Prisk
     [not found] ` <1358315546-2201-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2013-01-16  5:52   ` [PATCH] " Tony Prisk
     [not found]     ` <1358315546-2201-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2013-02-13 20:13       ` Wolfram Sang
     [not found]         ` <20130213201307.GA8795-8EAEigeeuNG034pCzgS/Qg7AFbiQbgqx@public.gmane.org>
2013-02-13 23:41           ` Tony Prisk
2013-02-14 10:01             ` Wolfram Sang [this message]
2013-02-11 23:02   ` [GIT PULL] " Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2012-12-28  1:29 [PATCH] " Tony Prisk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214100115.GA12290@nekote.pengutronix.de \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).