* [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration
[not found] <1360849767-1463135-1-git-send-email-arnd@arndb.de>
@ 2013-02-14 13:49 ` Arnd Bergmann
[not found] ` <1360849767-1463135-11-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2013-02-14 13:49 UTC (permalink / raw)
To: arm
Cc: linux-kernel, linux-arm-kernel, Russell King, Arnd Bergmann,
linux-i2c, Wolfram Sang, Ben Dooks, Kukjin Kim
A recent cleanup to the mach-osiris.c file is causing build errors
because the i2c-s3c2410.h header file is included before we see
the definition for platform_device. The fix is to make the header file
more robust against inclusion from other places. While this should
normally go through the i2c tree, the bug only exists in arm-soc
at the moment, so it's easier to fix it there before it goes upstream.
Without this patch, building s3c2410_defconfig results in:
arch/arm/mach-s3c24xx/mach-osiris.c:34:0:
include/linux/platform_data/i2c-s3c2410.h:37:26: warning: 'struct platform_device' declared inside parameter list [enabled by default]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
---
include/linux/platform_data/i2c-s3c2410.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/platform_data/i2c-s3c2410.h b/include/linux/platform_data/i2c-s3c2410.h
index 51d52e7..2a50048 100644
--- a/include/linux/platform_data/i2c-s3c2410.h
+++ b/include/linux/platform_data/i2c-s3c2410.h
@@ -15,6 +15,8 @@
#define S3C_IICFLG_FILTER (1<<0) /* enable s3c2440 filter */
+struct platform_device;
+
/**
* struct s3c2410_platform_i2c - Platform data for s3c I2C.
* @bus_num: The bus number to use (if possible).
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration
[not found] ` <1360849767-1463135-11-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
@ 2013-02-15 11:54 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-02-15 11:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Ben Dooks, Kukjin Kim
On Thu, Feb 14, 2013 at 02:49:26PM +0100, Arnd Bergmann wrote:
> A recent cleanup to the mach-osiris.c file is causing build errors
> because the i2c-s3c2410.h header file is included before we see
> the definition for platform_device. The fix is to make the header file
> more robust against inclusion from other places. While this should
> normally go through the i2c tree, the bug only exists in arm-soc
> at the moment, so it's easier to fix it there before it goes upstream.
>
> Without this patch, building s3c2410_defconfig results in:
>
> arch/arm/mach-s3c24xx/mach-osiris.c:34:0:
> include/linux/platform_data/i2c-s3c2410.h:37:26: warning: 'struct platform_device' declared inside parameter list [enabled by default]
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Fine with me:
Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-15 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1360849767-1463135-1-git-send-email-arnd@arndb.de>
2013-02-14 13:49 ` [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration Arnd Bergmann
[not found] ` <1360849767-1463135-11-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2013-02-15 11:54 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).