linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org,
	kgene.kim@samsung.com, ben-linux@fluff.org, heiko@sntech.de,
	t.figa@samsung.com
Subject: Re: [PATCH] i2c: s3c24xx: allow device core to setup default pin configuration
Date: Thu, 21 Mar 2013 11:00:32 +0100	[thread overview]
Message-ID: <20130321100032.GC19297@the-dreams.de> (raw)
In-Reply-To: <1362404573-30406-1-git-send-email-thomas.abraham@linaro.org>

On Mon, Mar 04, 2013 at 07:12:53PM +0530, Thomas Abraham wrote:
> With device core now able to setup the default pin configuration,
> the call to devm_pinctrl_get_select_default can be removed. And
> the pin configuration code based on the deprecated Samsung specific
> gpio bindings is also removed.
> 
> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
> 
> Hi Heiko, Tomasz,
> 
> We have to make a choice on the path forward for pinctrl support
> on Samsung platforms. We have three cases to deal with.
> 
> A. Samsung platforms without DT support.
> B. Samsung platforms with DT support using old Samsung specific
>    gpio bindings for pin-configuration (s3c24xx and s3x64xx).
> C. Samsung platforms with DT support using using pinctrl based
>    pin-configurations (Exynos4 and Exynos5).
> 
> For [A], we just let the platform specific callbacks handle the
> pin setup. For [B] and [C], based on Linus Walleij's pin grab
> by device core patch and subsequent discussions with him on the
> mailing list, would it be acceptable that we discontinue support
> for [B] in Samsung SoC device drivers. This will impact your
> current DT work on s3c24xx and s3c64xx platforms. Pinctrl is
> inevitable and we have to migrate to it. Instead of workarounds
> to maintain support for [B], it might be better that we migrate
> s3c24xx and s3c64xx platforms to pinctrl.
> 
> Please do let us know your opinion on this.

Dropping [B] sounds good, but I think it makes sense to wait with this
patch until pinctrl support for s3c24xx is in place?

  parent reply	other threads:[~2013-03-21 10:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 13:42 [PATCH] i2c: s3c24xx: allow device core to setup default pin configuration Thomas Abraham
2013-03-04 14:03 ` Heiko Stübner
2013-03-04 14:12   ` Thomas Abraham
2013-03-07  6:16 ` Linus Walleij
2013-03-21 10:00 ` Wolfram Sang [this message]
     [not found]   ` <20130321100032.GC19297-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-03-21 10:50     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130321100032.GC19297@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=ben-linux@fluff.org \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).