Re: [PATCH V10 1/2] i2c/adapter: Add bus recovery infrastructure

[Shiraz Hashim <shiraz.hashim-qxv4g6HH51o@public.gmane.org>]

On Thu, Mar 21, 2013 at 03:45:29PM +0530, Viresh Kumar wrote:
> On 21 March 2013 15:06, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> > I applied V11 of the core changes with minor modifications.
> 
> Wow!! Thanks.
> 
> > I do wonder
> > about the hook in the designware driver. You apply the recovery on
> > transfer timeout. I think this should go into the timeout of
> > i2c_dw_wait_bus_not_busy()?
> 
> Hmm.. Rajeev/Shiraz were the guys who tested this code earlier and i am
> sure we were failing in this piece of code, which i just fixed and so
> i2c_dw_wait_bus_not_busy() didn't fail for us.
> 
> Below is a conversation that we had with Uwe some time back on the exact
> problem we faced and it was a bit different from the traditional problem.
> 
> So, maybe we need bus recovery at both places: i2c_dw_wait_bus_not_busy()
> (for the traditional hang) and during transfer (for our case).

DW_IC_STATUS_ACTIVITY check in i2c_dw_wait_bus_not_busy actually
only represents controller activity status and has nothing to do
with real bus status.

--
regards
Shiraz