From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 3/3] i2c: mxs: do error checking and handling in PIO mode Date: Tue, 2 Apr 2013 00:59:22 +0200 Message-ID: <201304020059.22550.marex@denx.de> References: <1363261750-26645-1-git-send-email-l.stach@pengutronix.de> <1363261750-26645-3-git-send-email-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1363261750-26645-3-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wolfram Sang , "Ben Dooks (embedded platforms)" List-Id: linux-i2c@vger.kernel.org Dear Lucas Stach, > In PIO mode we can end up with the same errors as in DMA mode, but as IRQs > are disabled there we have to check for them manually after each command. > > Also don't use the big controller reset hammer when receiving a NAK from a > slave. It's sufficient to tell the controller to continue at a clean state. > > Signed-off-by: Lucas Stach Stamp it with: Tested-by: Marek Vasut Good job, thanks! Best regards, Marek Vasut