From: Guenter Roeck <linux@roeck-us.net>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, linux-i2c@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver
Date: Wed, 3 Apr 2013 08:30:00 -0700 [thread overview]
Message-ID: <20130403153000.GA30641@roeck-us.net> (raw)
In-Reply-To: <20130403150952.GX1906@pengutronix.de>
On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote:
[ ... ]
> >
> > On a side note, if the driver supports devicetree, it might make sense to call
> > watchdog_init_timeout, since it initializes the timeout from devicetree data.
>
> The driver does not support devicetree.
>
I should have said "the system". Calling watchdog_init_timeout is the only thing
a watchdog driver has to do to support devicetree.
Thanks,
Guenter
next prev parent reply other threads:[~2013-04-03 15:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 10:02 [PATCH] Congatec CGEB base, i2c and watchdog driver support Sascha Hauer
[not found] ` <1360663374-30951-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-02-12 10:02 ` [PATCH 1/3] x86: Add basic support for the Congatec CGEB BIOS interface Sascha Hauer
[not found] ` <1360663374-30951-2-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-25 8:31 ` Christian Gmeiner
2013-03-26 8:54 ` Sascha Hauer
[not found] ` <20130326085454.GK1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-26 9:24 ` Wolfram Sang
[not found] ` <20130326092435.GB8553-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2013-03-26 9:31 ` Sascha Hauer
[not found] ` <20130326093139.GL1906-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-26 9:38 ` Christian Gmeiner
[not found] ` <CAH9NwWdUqH8gF8Vz7K_2UW1X==LWbYEd5dhSTPqqYwEnDuRVuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-11 7:14 ` Christian Gmeiner
[not found] ` <CAH9NwWd-UAYG0y2R379hPvntnfPhNEwvXm-f2uO3o1AZZ+OSMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-11 11:20 ` Wolfram Sang
2013-02-12 10:02 ` [PATCH 2/3] i2c: Add Congatec CGEB I2C driver Sascha Hauer
[not found] ` <1360663374-30951-3-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-02-14 10:11 ` Wolfram Sang
[not found] ` <20130214101130.GB12290-8EAEigeeuNG034pCzgS/Qg7AFbiQbgqx@public.gmane.org>
2013-03-26 9:55 ` Christian Gmeiner
2013-02-13 14:57 ` [PATCH] Congatec CGEB base, i2c and watchdog driver support Christian Gmeiner
[not found] ` <CAH9NwWfSQKW2c1LvLQkojPiKA_r7+_6OmgoVHrBNRHUEFNYvJg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-14 8:35 ` Sascha Hauer
2013-02-12 10:02 ` [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver Sascha Hauer
[not found] ` <1360663374-30951-4-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-03-26 10:16 ` Christian Gmeiner
2013-03-26 14:33 ` Guenter Roeck
[not found] ` <20130326143331.GA5529-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-03 15:09 ` Sascha Hauer
2013-04-03 15:30 ` Guenter Roeck [this message]
[not found] ` <20130403153000.GA30641-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-03 17:06 ` Sascha Hauer
2013-04-03 15:16 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2012-02-01 13:26 [RESEND] Congatec CGEB base, i2c and watchdog driver support Sascha Hauer
[not found] ` <1328102793-4313-1-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-02-01 13:26 ` [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver Sascha Hauer
[not found] ` <1328102793-4313-4-git-send-email-s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-02-07 15:08 ` Wolfram Sang
[not found] ` <20120207150856.GI2539-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-02-15 13:41 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403153000.GA30641@roeck-us.net \
--to=linux@roeck-us.net \
--cc=christian.gmeiner@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).