Re: I2C_M_RECV_LEN for i2c-mxs

["Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Fri, Apr 12, 2013 at 05:37:57PM +0200, Wolfram Sang wrote:
> please prefer wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org for kernel stuff.
The reason I used wolfram@... is probably:

	$ for addr in sa olfram; do printf "%s: " $addr; git log --oneline --grep=w$addr-z923LK4zBo2bacvFa/9K2g@public.gmane.org v3.9-rc6 | wc -l; done
	sa: 7
	olfram: 35

But I see the recent commits use "sa" so probably I will do that next
time, too.

> >  - Is it correct to have I2C_FUNC_SMBUS_EMUL in .functionality without
> >    supporting I2C_M_RECV_LEN?
> 
> Yes. Check the #define and you'll see that it does not contain
> BLOCK_READ and BLOCK_PROC_CALL.
Ah, ok. But then there is a different problem: Even though "my" driver
only advertises I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL calling
i2c_smbus_read_block_data in userspace results in .master_xfer being
called with I2C_M_RECV_LEN set.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |