From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Kevin Strasser
<kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Brunner
<michael.brunner-2UyDCMiLNfhBDgjK7y7TUQ@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Michael Brunner <mibru-Mmb7MZpHnFY@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 2/4] i2c: Kontron PLD i2c bus driver
Date: Tue, 16 Apr 2013 11:53:09 +0200 [thread overview]
Message-ID: <20130416095309.GD16978@the-dreams.de> (raw)
In-Reply-To: <20130410170212.GB19533-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Wed, Apr 10, 2013 at 10:02:12AM -0700, Guenter Roeck wrote:
> On Mon, Apr 08, 2013 at 10:15:19AM -0700, Kevin Strasser wrote:
> > From: Michael Brunner <michael.brunner-2UyDCMiLNfhBDgjK7y7TUQ@public.gmane.org>
> >
> > Add i2c support for the on-board PLD found on some Kontron embedded
> > modules.
> >
> > Signed-off-by: Michael Brunner <michael.brunner-2UyDCMiLNfhBDgjK7y7TUQ@public.gmane.org>
> > Signed-off-by: Kevin Strasser <kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> Overall well written, though I have a couple of nitpicks.
>
> I would prefer two separate drivers, one for the mux and one for the i2c bus.
> If that is possible, it would help getting rid of the #ifdef in the code, which
> is frowned upon in the kernel.
>
> I dislike unnecessary ( ). Maintainer's call, though.
>
> Couple of places have missing spaces around operators (checkpatch doesn't catch
> all those).
>
> As far as I know, devm_ functions are supposed to print an error message on
> failure, so it should be unnecessary to print another one if that happens (this
> might need some confirmation).
Haven't done a full review due to tglx NACK. I agree to the points
mentioned here by Guenter, though.
next prev parent reply other threads:[~2013-04-16 9:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 17:15 [PATCH 1/4] mfd: Kontron PLD mfd driver Kevin Strasser
2013-04-13 20:38 ` Thomas Gleixner
2013-04-18 4:19 ` Guenter Roeck
[not found] ` <20130418041940.GB7535-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-18 4:40 ` Joe Perches
2013-04-18 13:35 ` Guenter Roeck
2013-04-18 16:42 ` Joe Perches
2013-04-18 18:40 ` Guenter Roeck
[not found] ` <1365441321-21952-1-git-send-email-kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-04-08 17:15 ` [PATCH 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
[not found] ` <1365441321-21952-2-git-send-email-kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-04-10 17:02 ` Guenter Roeck
[not found] ` <20130410170212.GB19533-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-16 9:53 ` Wolfram Sang [this message]
2013-04-08 17:15 ` [PATCH 3/4] gpio: Kontron PLD gpio driver Kevin Strasser
2013-04-09 8:46 ` Linus Walleij
[not found] ` <CACRpkdYrGK_SPbiRssFUrg2vMvWbYO_iXsy+aZr99tyFtk88Uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-09 16:41 ` Guenter Roeck
2013-04-10 20:06 ` Linus Walleij
2013-04-10 20:45 ` Linus Walleij
[not found] ` <CACRpkdaU-QT-VBiG8i5XreEP-DvTosHeptUo+5vdmSyi0=uWTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-04-12 11:09 ` Michael Brunner
2013-04-12 22:05 ` Linus Walleij
2013-04-08 17:15 ` [PATCH 4/4] watchdog: Kontron PLD watchdog timer Kevin Strasser
2013-04-10 16:47 ` Guenter Roeck
[not found] ` <20130410164717.GA19533-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-04-10 16:57 ` Kevin Strasser
2013-05-26 14:38 ` Wim Van Sebroeck
2013-06-18 21:04 ` [PATCH v2 0/4] Kontron PLD drivers Kevin Strasser
2013-06-18 21:04 ` [PATCH v2 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 0/4] Kontron PLD drivers Kevin Strasser
2013-06-24 4:00 ` [PATCH v3 2/4] i2c: Kontron PLD i2c bus driver Kevin Strasser
[not found] ` <1372046406-3127-3-git-send-email-kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-07-01 6:40 ` Wolfram Sang
[not found] ` <1372046406-3127-1-git-send-email-kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-06-24 12:06 ` [PATCH v3 0/4] Kontron PLD drivers Samuel Ortiz
2013-06-24 16:09 ` Wolfram Sang
2013-06-27 20:34 ` Wim Van Sebroeck
[not found] ` <20130627203436.GB30950-1F/o1hAF34+bEvaWgpTR7kEOCMrvLtNR@public.gmane.org>
2013-06-27 21:48 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416095309.GD16978@the-dreams.de \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dvhart-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kevin.strasser-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mibru-Mmb7MZpHnFY@public.gmane.org \
--cc=michael.brunner-2UyDCMiLNfhBDgjK7y7TUQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).