From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver Date: Wed, 17 Apr 2013 21:19:40 -0700 Message-ID: <20130418041940.GB7535@roeck-us.net> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Kevin Strasser , linux-kernel@vger.kernel.org, Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , linux-i2c@vger.kernel.org, Grant Likely , Linus Walleij , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman , Joe Perches List-Id: linux-i2c@vger.kernel.org On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: [ ... ] > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8; > > index + 1) > Please > Wondering .... why does checkpatch not report those ? I just reviewed another driver with the same kind of problem, and checkpatch is just as silent. There seems to be a whole class of expressions where it does not complain about missing spaces. Joe, any idea ? Thanks, Guenter