* [PATCH] I2C: Change the value of octeon i2c adapter timeout value
@ 2013-04-19 0:01 EUNBONG SONG
2013-04-19 7:58 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: EUNBONG SONG @ 2013-04-19 0:01 UTC (permalink / raw)
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
I think HZ/50 is better than 2 for adapter timeout.
Signed-off-by: Eunbong Song <eunb.song@samsung.com>
---
drivers/i2c/busses/i2c-octeon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
index 935585e..ca489f3 100644
--- a/drivers/i2c/busses/i2c-octeon.c
+++ b/drivers/i2c/busses/i2c-octeon.c
@@ -440,7 +440,7 @@ static struct i2c_adapter octeon_i2c_ops = {
.owner = THIS_MODULE,
.name = "OCTEON adapter",
.algo = &octeon_i2c_algo,
- .timeout = 2,
+ .timeout = HZ/50,
};
/**
--
1.7.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] I2C: Change the value of octeon i2c adapter timeout value
2013-04-19 0:01 [PATCH] I2C: Change the value of octeon i2c adapter timeout value EUNBONG SONG
@ 2013-04-19 7:58 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-04-19 7:58 UTC (permalink / raw)
To: EUNBONG SONG
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Fri, Apr 19, 2013 at 12:01:04AM +0000, EUNBONG SONG wrote:
>
> I think HZ/50 is better than 2 for adapter timeout.
Basically OK. But why HZ/50? Most drivers use HZ.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-19 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 0:01 [PATCH] I2C: Change the value of octeon i2c adapter timeout value EUNBONG SONG
2013-04-19 7:58 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).