From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jingoo Han <jg1.han@samsung.com>,
linux-pm@vger.kernel.org, 'Len Brown' <len.brown@intel.com>,
'Andrew Morton' <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] PM: Add pm_ops_ptr() macro
Date: Fri, 3 May 2013 11:23:11 +0200 [thread overview]
Message-ID: <20130503092311.GA13832@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1474315.q4folvZv3e@vostro.rjw.lan>
Hi!
> > Add pm_ops_ptr() macro that allows the .pm entry in the driver structures
> > to be assigned without having an #define xxx NULL for the case that PM is
> > not enabled.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> I've queued this up as v3.11 material.
> > --- a/drivers/i2c/busses/i2c-s3c2410.c
> > +++ b/drivers/i2c/busses/i2c-s3c2410.c
> > @@ -1218,7 +1218,6 @@ static int s3c24xx_i2c_resume(struct device *dev)
> > }
> > #endif
> >
> > -#ifdef CONFIG_PM
> > static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
> > #ifdef CONFIG_PM_SLEEP
> > .suspend_noirq = s3c24xx_i2c_suspend_noirq,
> > @@ -1226,11 +1225,6 @@ static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
> > #endif
> > };
> >
> > -#define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)
> > -#else
> > -#define S3C24XX_DEV_PM_OPS NULL
> > -#endif
> > -
> > /* device driver for platform bus bits */
Will not this enlarge .data by sizeof(struct dev_pm_ops)?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-05-03 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 1:09 [PATCH] PM: Add pm_ops_ptr() macro Jingoo Han
2013-05-02 21:18 ` Rafael J. Wysocki
2013-05-03 9:23 ` Pavel Machek [this message]
[not found] ` <20130503092311.GA13832-tWAi6jLit6GreWDznjuHag@public.gmane.org>
2013-05-30 10:56 ` Wolfram Sang
2013-05-30 13:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503092311.GA13832@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox