From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] i2c-designware: always clear interrupts before enabling them
Date: Fri, 17 May 2013 10:31:42 +0200 [thread overview]
Message-ID: <20130517083139.GC17056@katana> (raw)
In-Reply-To: <1368442471-7582-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Mon, May 13, 2013 at 01:54:30PM +0300, Mika Westerberg wrote:
> If the I2C bus is put to a low power state by an ACPI method it might pull
> the SDA line low (as its power is removed). Once the bus is put to full
> power state again, the SDA line is pulled back to high. This transition
> looks like a STOP condition from the controller point-of-view which sets
> STOP detected bit in its status register causing the driver to fail
> subsequent transfers.
>
> Fix this by always clearing all interrupts before we start a transfer.
>
> Signed-off-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Applied to for-current, thanks! Added stable, too.
prev parent reply other threads:[~2013-05-17 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 10:54 [PATCH 1/2] i2c-designware: always clear interrupts before enabling them Mika Westerberg
2013-05-13 10:54 ` [PATCH 2/2] i2c-designware: add Intel BayTrail ACPI ID Mika Westerberg
2013-05-17 8:31 ` Wolfram Sang
[not found] ` <1368442471-7582-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-05-17 8:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517083139.GC17056@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).