From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID Date: Fri, 31 May 2013 16:38:32 +0900 Message-ID: <20130531073832.GB16809@mtj.dyndns.org> References: <1369999333-2073-1-git-send-email-shane.huang@amd.com> <20130531080336.04481330@endymion.delvare> <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8CC5@SCYBEXDAG04.amd.com> <20130531092846.51f2e202@endymion.delvare> <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8D06@SCYBEXDAG04.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8D06@SCYBEXDAG04.amd.com> Sender: linux-ide-owner@vger.kernel.org To: "Huang, Shane" Cc: Jean Delvare , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-i2c@vger.kernel.org" List-Id: linux-i2c@vger.kernel.org On Fri, May 31, 2013 at 07:33:51AM +0000, Huang, Shane wrote: > > Can you show the exact message? checkpatch doesn't complain here, and I > > can't think of any reason why it would care about that. > > $ ./scripts/checkpatch.pl 0003-i2c-piix4-add-AMD-CZ-SMBus-device-ID.patch > WARNING: Avoid CamelCase: > #52: FILE: drivers/i2c/busses/i2c-piix4.c:25: > + AMD Hudson-2, CZ > > total: 0 errors, 1 warnings, 39 lines checked Even if checkpatch complains, there's no point in following it religiously. If addressing the complaint doesn't make the code better, there's no point in doing so. Thanks. -- tejun