From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: "Huang, Shane" <Shane.Huang-5C7GfCeVMHo@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID
Date: Fri, 31 May 2013 09:28:46 +0200 [thread overview]
Message-ID: <20130531092846.51f2e202@endymion.delvare> (raw)
In-Reply-To: <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8CC5-7mPiUsE5EJ9oz6IQsZflRkEOCMrvLtNR@public.gmane.org>
On Fri, 31 May 2013 06:42:54 +0000, Huang, Shane wrote:
> Hi Jean,
>
> > Please don't change the case. This makes your patch larger and
> > increases the risk of conflict with other patches, for no good reason.
> >
> > Other than that, the patch looks OK.
>
> I didn't want to change it but checkpatch.pl warns due to
> "Hudson-2" in i2c-piix4.c
Can you show the exact message? checkpatch doesn't complain here, and I
can't think of any reason why it would care about that.
--
Jean Delvare
next prev parent reply other threads:[~2013-05-31 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 11:22 [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID Shane Huang
2013-05-31 6:03 ` Jean Delvare
2013-05-31 6:42 ` Huang, Shane
[not found] ` <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8CC5-7mPiUsE5EJ9oz6IQsZflRkEOCMrvLtNR@public.gmane.org>
2013-05-31 7:28 ` Jean Delvare [this message]
2013-05-31 7:33 ` Huang, Shane
2013-05-31 7:38 ` Tejun Heo
2013-05-31 7:46 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531092846.51f2e202@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=Shane.Huang-5C7GfCeVMHo@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox