From: Jean Delvare <khali@linux-fr.org>
To: "Huang, Shane" <Shane.Huang@amd.com>
Cc: Tejun Heo <tj@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-ide@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID
Date: Fri, 31 May 2013 09:46:43 +0200 [thread overview]
Message-ID: <20130531094643.5b256d2d@endymion.delvare> (raw)
In-Reply-To: <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8D06@SCYBEXDAG04.amd.com>
On Fri, 31 May 2013 07:33:51 +0000, Huang, Shane wrote:
> > Can you show the exact message? checkpatch doesn't complain here, and I
> > can't think of any reason why it would care about that.
>
> $ ./scripts/checkpatch.pl 0003-i2c-piix4-add-AMD-CZ-SMBus-device-ID.patch
> WARNING: Avoid CamelCase: <Hudson>
> #52: FILE: drivers/i2c/busses/i2c-piix4.c:25:
> + AMD Hudson-2, CZ
>
> total: 0 errors, 1 warnings, 39 lines checked
checkpatch is twice wrong here, firstly because there is no CamelCase
and secondly because this is a comment and not code (ideally middle
comment lines would start with "*" to avoid this false positive, but
that style wasn't yet in use when the i2c-piix4 driver was written.)
So, just ignore it.
--
Jean Delvare
prev parent reply other threads:[~2013-05-31 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 11:22 [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID Shane Huang
2013-05-31 6:03 ` Jean Delvare
2013-05-31 6:42 ` Huang, Shane
[not found] ` <43EB3AB3EEFE8D43B525F4D2EAF507E1085B8CC5-7mPiUsE5EJ9oz6IQsZflRkEOCMrvLtNR@public.gmane.org>
2013-05-31 7:28 ` Jean Delvare
2013-05-31 7:33 ` Huang, Shane
2013-05-31 7:38 ` Tejun Heo
2013-05-31 7:46 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531094643.5b256d2d@endymion.delvare \
--to=khali@linux-fr.org \
--cc=Shane.Huang@amd.com \
--cc=bhelgaas@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).