From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v3 4/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c Date: Fri, 21 Jun 2013 11:06:29 -0400 Message-ID: <20130621150629.GR31667@titan.lakedaemon.net> References: <1371821529-13791-1-git-send-email-gregory.clement@free-electrons.com> <1371821529-13791-5-git-send-email-gregory.clement@free-electrons.com> <20130621140707.GO31667@titan.lakedaemon.net> <51C46001.30500@gmail.com> <20130621145629.GQ31667@titan.lakedaemon.net> <20130621150323.GA3450@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130621150323.GA3450@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: Sebastian Hesselbarth , Thomas Petazzoni , Andrew Lunn , Yehuda Yitschak , Ike Pan , Tawfik Bayouk , Dan Frazier , Nicolas Pitre , David Marlin , Eran Ben-Avi , Nadav Haklai , Maen Suleiman , Lior Amsalem , Shadi Ammouri , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ezequiel Garcia , Jon Masters , Gregory CLEMENT , Chris Van Hoof , Leif Lindholm , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, Jun 21, 2013 at 05:03:23PM +0200, Wolfram Sang wrote: > > > > from a quick check of the patch set (which you forgot to send to LKML) > > > I am wondering why you didn't update the of matches struct with the new > > > compatible for "marvell,mv78230-i2c"? This will save you from still > > > having "marvell,mv64xxx-i2c" as additional compatible to match device > > > and driver. With that the above should also be s/and/or/. > > > > agreed, good point. > > > > Gregory, > > > > I'm sending the last PRs for mvebu today. I'll include this one with my > > suggestion and Sebastian's if you're ok with it. That means you'll have > > to respin the series for the i2c folks. Does that work for you? > > No hurry, please. Most of the patches are 3.12 material anyhow, so we > can as well just wait until the I2C patches are okay and then update the > dts later. Ok, thanks for the heads up. I'll put this in my v3.12 stack. thx, Jason.