diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index df8ff5a..b125183 100644 --- a/drivers/i2c/busses/i2c-mxs.c +++ b/drivers/i2c/busses/i2c-mxs.c @@ -35,6 +35,7 @@ #define MXS_I2C_CTRL0 (0x00) #define MXS_I2C_CTRL0_SET (0x04) +#define MXS_I2C_CTRL0_CLR (0x08) #define MXS_I2C_CTRL0_SFTRST 0x80000000 #define MXS_I2C_CTRL0_RUN 0x20000000 @@ -123,6 +124,32 @@ struct mxs_i2c_dev { bool dma_read; }; +static void mxs_i2c_dump(struct mxs_i2c_dev *i2c, int rd) +{ + pr_err("=====================================\n"); + + pr_err("0x000: %08x %08x %08x %08x\n", + readl(i2c->regs + 0x00), + readl(i2c->regs + 0x10), + readl(i2c->regs + 0x20), + readl(i2c->regs + 0x30)); + pr_err("0x040: %08x %08x %08x %08x\n", + readl(i2c->regs + 0x40), + readl(i2c->regs + 0x50), + readl(i2c->regs + 0x60), + readl(i2c->regs + 0x70)); + pr_err("0x080: %08x %08x %08x %08x\n", + readl(i2c->regs + 0x80), + rd ? readl(i2c->regs + 0x90) : 0, + rd ? readl(i2c->regs + 0xa0) : 0, + readl(i2c->regs + 0xb0)); + pr_err("0x0c0: %08x %08x\n", + readl(i2c->regs + 0xc0), + readl(i2c->regs + 0xd0)); + + pr_err("=====================================\n"); +} + static void mxs_i2c_reset(struct mxs_i2c_dev *i2c) { stmp_reset_block(i2c->regs); @@ -366,6 +393,7 @@ static void mxs_i2c_pio_trigger_cmd(struct mxs_i2c_dev *i2c, u32 cmd) writel(reg, i2c->regs + MXS_I2C_CTRL0); } +#include static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, uint32_t flags) { @@ -401,6 +429,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap, mxs_i2c_pio_trigger_cmd(i2c, MXS_CMD_I2C_READ | flags | MXS_I2C_CTRL0_XFER_COUNT(msg->len)); +// mxs_i2c_dump(i2c, 0); for (i = 0; i < msg->len; i++) { if ((i & 3) == 0) { @@ -418,38 +447,66 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap, addr_data |= I2C_SMBUS_WRITE; /* WRITE command. */ - mxs_i2c_pio_trigger_cmd(i2c, - MXS_CMD_I2C_WRITE | flags | - MXS_I2C_CTRL0_XFER_COUNT(msg->len + 1)); +// mxs_i2c_pio_trigger_cmd(i2c, +// MXS_CMD_I2C_WRITE | flags | +// MXS_I2C_CTRL0_XFER_COUNT(msg->len + 1)); /* * The LSB of data buffer is the first byte blasted across * the bus. Higher order bytes follow. Thus the following * filling schematic. */ + data = addr_data << 24; for (i = 0; i < msg->len; i++) { data >>= 8; data |= (msg->buf[i] << 24); if ((i & 3) == 2) { - ret = mxs_i2c_pio_wait_dmareq(i2c); - if (ret) - return ret; + mxs_i2c_pio_trigger_cmd(i2c, + MXS_CMD_I2C_WRITE /*| flags*/ | (1 << 21) | + MXS_I2C_CTRL0_XFER_COUNT(4)); + + // ret = mxs_i2c_pio_wait_dmareq(i2c); + // if (ret) + // return ret; + +// mxs_i2c_dump(i2c, 0); +// pr_err("writing %08x\n", data); + writel(data, i2c->regs + MXS_I2C_DATA); - writel(MXS_I2C_DEBUG0_DMAREQ, - i2c->regs + MXS_I2C_DEBUG0_CLR); +// writel(1 << 21, i2c->regs + MXS_I2C_CTRL0_SET); + + // writel(MXS_I2C_DEBUG0_DMAREQ, + // i2c->regs + MXS_I2C_DEBUG0_CLR); +// mdelay(20); +// mxs_i2c_dump(i2c, 0); + } } shifts_left = 24 - (i & 3) * 8; if (shifts_left) { data >>= shifts_left; - ret = mxs_i2c_pio_wait_dmareq(i2c); - if (ret) - return ret; + if (msg->len <= 3) + flags |= MXS_CMD_I2C_WRITE; + mxs_i2c_pio_trigger_cmd(i2c, + MXS_I2C_CTRL0_MASTER_MODE | MXS_I2C_CTRL0_DIRECTION | flags | + MXS_I2C_CTRL0_XFER_COUNT((i & 3) + 1)); + + // ret = mxs_i2c_pio_wait_dmareq(i2c); + // if (ret) + // return ret; + writel(data, i2c->regs + MXS_I2C_DATA); - writel(MXS_I2C_DEBUG0_DMAREQ, - i2c->regs + MXS_I2C_DEBUG0_CLR); + +// mxs_i2c_dump(i2c, 0); +// pr_err("writing %08x %i\n", data, (i & 3) + 1); + + // writel(MXS_I2C_DEBUG0_DMAREQ, + // i2c->regs + MXS_I2C_DEBUG0_CLR); +// mdelay(20); +// mxs_i2c_dump(i2c, 0); + } } @@ -480,8 +537,10 @@ static int mxs_i2c_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, flags = stop ? MXS_I2C_CTRL0_POST_SEND_STOP : 0; - dev_dbg(i2c->dev, "addr: 0x%04x, len: %d, flags: 0x%x, stop: %d\n", - msg->addr, msg->len, msg->flags, stop); + dev_dbg(i2c->dev, "addr: 0x%04x, len: %d, flags: 0x%x [%c], stop: %d\n", + msg->addr, msg->len, msg->flags, msg->flags & I2C_M_RD ? 'R':'W', stop); +// if (msg->len) +// print_hex_dump(KERN_ERR, "", DUMP_PREFIX_NONE, 16, 1, msg->buf, msg->len, false); if (msg->len == 0) return -EINVAL; @@ -497,6 +556,7 @@ static int mxs_i2c_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, ret = mxs_i2c_pio_setup_xfer(adap, msg, flags); if (ret) mxs_i2c_reset(i2c); + i2c->cmd_err = ret; } else { INIT_COMPLETION(i2c->cmd_complete); ret = mxs_i2c_dma_setup_xfer(adap, msg, flags);