From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Chris Pattenden <chris-XAaQGU7qChDQT0dZR+AlfA@public.gmane.org>,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [lm-sensors] Bug Report: Bus substitution causing a problem
Date: Tue, 9 Jul 2013 07:51:30 +0200 [thread overview]
Message-ID: <20130709075130.775cd0fe@endymion.delvare> (raw)
In-Reply-To: <20130708222732.GA10676-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Mon, 8 Jul 2013 15:27:32 -0700, Guenter Roeck wrote:
> On Tue, Jul 09, 2013 at 12:00:13AM +0200, Jean Delvare wrote:
> > The problem here is that your i2c bus driver is evil and attributes the
> > same name to two different buses. It should not do that. This is a bug
> > in the i2c-omap driver. It should give each bus a distinct name, for
> > example by including the base I/O address in it.
>
> Unfortunately it is not the only such driver.
>
> Same output on P2020:
>
> i2c-0 i2c MPC adapter I2C adapter
> i2c-1 i2c MPC adapter I2C adapter
>
> And on P5040:
>
> i2c-0 i2c MPC adapter I2C adapter
> i2c-1 i2c MPC adapter I2C adapter
> i2c-2 i2c MPC adapter I2C adapter
> i2c-3 i2c MPC adapter I2C adapter
>
> Question is ... would a patch to fix that be accepted by the i2c maintainers ?
I think it would, yes, as long as you explain why it is needed.
--
Jean Delvare
prev parent reply other threads:[~2013-07-09 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51DAC98E.3090203@aeryon.com>
[not found] ` <51DB2CB6.4060303@aeryon.com>
[not found] ` <20130709000013.1ca77b1d@endymion.delvare>
[not found] ` <20130709000013.1ca77b1d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-07-08 22:27 ` [lm-sensors] Bug Report: Bus substitution causing a problem Guenter Roeck
[not found] ` <20130708222732.GA10676-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-07-09 5:51 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130709075130.775cd0fe@endymion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=chris-XAaQGU7qChDQT0dZR+AlfA@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).