From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH v2] i2c: i2c-mxs: Check the return value from stmp_reset_block()
Date: Thu, 11 Jul 2013 04:27:01 +0200 [thread overview]
Message-ID: <201307110427.01651.marex@denx.de> (raw)
In-Reply-To: <1373505568-21477-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> stmp_reset_block() may fail, so let's check its return value and propagate
> it in the case of error.
>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> Changes since v1:
> - Check the return value of all occurences of mxs_i2c_reset()
>
> drivers/i2c/busses/i2c-mxs.c | 26 +++++++++++++++++++-------
> 1 file changed, 19 insertions(+), 7 deletions(-)
The error handling in mxs_i2c_xfer_msg() is ugly and will need to be reworked,
but this is not for this patch.
Acked-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-07-11 2:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 1:19 [PATCH v2] i2c: i2c-mxs: Check the return value from stmp_reset_block() Fabio Estevam
[not found] ` <1373505568-21477-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-11 2:27 ` Marek Vasut [this message]
2013-08-15 10:00 ` Wolfram Sang
2013-08-15 21:31 ` Marek Vasut
[not found] ` <201308152331.23742.marex-ynQEQJNshbs@public.gmane.org>
2013-08-16 16:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307110427.01651.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).