From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH v2] i2c: i2c-mxs: Check the return value from stmp_reset_block() Date: Thu, 11 Jul 2013 04:27:01 +0200 Message-ID: <201307110427.01651.marex@denx.de> References: <1373505568-21477-1-git-send-email-festevam@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1373505568-21477-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabio Estevam List-Id: linux-i2c@vger.kernel.org Dear Fabio Estevam, > From: Fabio Estevam > > stmp_reset_block() may fail, so let's check its return value and propagate > it in the case of error. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Check the return value of all occurences of mxs_i2c_reset() > > drivers/i2c/busses/i2c-mxs.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) The error handling in mxs_i2c_xfer_msg() is ugly and will need to be reworked, but this is not for this patch. Acked-by: Marek Vasut Best regards, Marek Vasut