linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	to-fleischer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org,
	Fabio Estevam
	<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] i2c: i2c-mxs: Use DMA mode even for small transfers
Date: Mon, 15 Jul 2013 16:12:08 +0200	[thread overview]
Message-ID: <201307151612.09198.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5Dyk_5CzcXvG7eJ3h07i=So0DS7MjtMQVHfpfx9Se_Teg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Dear Fabio Estevam,

> Hi Wolfram,
> 
> On Mon, Jul 1, 2013 at 11:23 PM, Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > On Mon, Jul 01, 2013 at 06:14:21PM -0300, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >> 
> >> Recently we have been seing some reports about PIO mode not working
> >> properly.
> >> 
> >> - http://www.spinics.net/lists/linux-i2c/msg11985.html
> >> - http://marc.info/?l=linux-i2c&m=137235593101385&w=2
> >> - https://lkml.org/lkml/2013/6/24/430
> > 
> > It also causes sgtl5000 register write failure [1].  Changing it back to
> > DMA mode fixes the failure.  So,
> > 
> > Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > 
> > [1] http://thread.gmane.org/gmane.linux.alsa.devel/109715/focus=109747
> 
> Any comment about this patch, please?
> 
> If you are happy with it, could we please have it applied into stable?
> 
> 3.10 is currently broken without this patch.

Hi, either this or the PIO fix, but that's a RFC and quite a big slab of change 
which still needs some work. So please apply this and let's try the PIOfix for 
3.11 or 3.12.

Best regards,
Marek Vasut

  parent reply	other threads:[~2013-07-15 14:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-01 21:14 [PATCH v2] i2c: i2c-mxs: Use DMA mode even for small transfers Fabio Estevam
2013-07-02  2:23 ` Shawn Guo
2013-07-15 13:30   ` Fabio Estevam
     [not found]     ` <CAOMZO5Dyk_5CzcXvG7eJ3h07i=So0DS7MjtMQVHfpfx9Se_Teg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-15 14:12       ` Marek Vasut [this message]
2013-07-23 18:15     ` Fabio Estevam
2013-07-24  3:02       ` Marek Vasut
2013-07-24  3:09         ` Fabio Estevam
2013-07-26  0:46           ` Ben Hutchings
2013-07-26  4:20             ` Marek Vasut
     [not found] ` <1372713261-20551-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-02  8:16   ` Lucas Stach
2013-07-03  2:38     ` Marek Vasut
     [not found]       ` <201307030438.50069.marex-ynQEQJNshbs@public.gmane.org>
2013-07-03  4:37         ` Marek Vasut
2013-07-03  8:33           ` Alexandre Belloni
     [not found]             ` <51D3E1D2.4070706-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-07-03 11:41               ` Marek Vasut
     [not found]           ` <201307030637.05324.marex-ynQEQJNshbs@public.gmane.org>
2013-07-03  9:11             ` Lucas Stach
     [not found]               ` <1372842695.4440.3.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-07-03 11:39                 ` Marek Vasut
2013-08-05  8:11 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201307151612.09198.marex@denx.de \
    --to=marex-ynqeqjnshbs@public.gmane.org \
    --cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=to-fleischer-zqRNUXuvxA0b1SvskN2V4Q@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).