From: Marek Vasut <marex@denx.de>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>,
wsa@the-dreams.de, kernel@pengutronix.de,
linux-i2c@vger.kernel.org, alexandre.belloni@free-electrons.com,
to-fleischer@t-online.de,
Fabio Estevam <fabio.estevam@freescale.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i2c-mxs: Use DMA mode even for small transfers
Date: Fri, 26 Jul 2013 06:20:17 +0200 [thread overview]
Message-ID: <201307260620.17711.marex@denx.de> (raw)
In-Reply-To: <1374799579.2480.1.camel@deadeye.wl.decadent.org.uk>
Dear Ben Hutchings,
> On Wed, 2013-07-24 at 00:09 -0300, Fabio Estevam wrote:
> > Hi Marek,
> >
> > On Wed, Jul 24, 2013 at 12:02 AM, Marek Vasut <marex@denx.de> wrote:
> > > Yes, the big question is if we want to use this patch or fix the PIO. I
> > > think this one is much less intrusive, so I'd vouch for yours for 3.10
> > > .
> >
> > Correct. Also according to Documentation/stable_kernel_rules.txt :
> >
> > "Rules on what kind of patches are accepted, and which ones are not, into
> > the "-stable" tree:
> >
> > ....
> >
> > - It cannot be bigger than 100 lines, with context."
> >
> > Your PIO fix is really appreciated, but it surpasses 100 lines, so it
> > would be better if we go with this one first so that it can reach
> > 3.10, and then we can use your PIO fix later.
>
> That one is not a hard and fast rule, but small localised fixes are
> preferred if possible.
Full agreement on this one, let's apply this patch.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-07-26 4:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 21:14 [PATCH v2] i2c: i2c-mxs: Use DMA mode even for small transfers Fabio Estevam
2013-07-02 2:23 ` Shawn Guo
2013-07-15 13:30 ` Fabio Estevam
[not found] ` <CAOMZO5Dyk_5CzcXvG7eJ3h07i=So0DS7MjtMQVHfpfx9Se_Teg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-15 14:12 ` Marek Vasut
2013-07-23 18:15 ` Fabio Estevam
2013-07-24 3:02 ` Marek Vasut
2013-07-24 3:09 ` Fabio Estevam
2013-07-26 0:46 ` Ben Hutchings
2013-07-26 4:20 ` Marek Vasut [this message]
[not found] ` <1372713261-20551-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-02 8:16 ` Lucas Stach
2013-07-03 2:38 ` Marek Vasut
[not found] ` <201307030438.50069.marex-ynQEQJNshbs@public.gmane.org>
2013-07-03 4:37 ` Marek Vasut
2013-07-03 8:33 ` Alexandre Belloni
[not found] ` <51D3E1D2.4070706-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-07-03 11:41 ` Marek Vasut
[not found] ` <201307030637.05324.marex-ynQEQJNshbs@public.gmane.org>
2013-07-03 9:11 ` Lucas Stach
[not found] ` <1372842695.4440.3.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-07-03 11:39 ` Marek Vasut
2013-08-05 8:11 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307260620.17711.marex@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=ben@decadent.org.uk \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stable@vger.kernel.org \
--cc=to-fleischer@t-online.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).