Re: [PATCH V2 2/3] i2c: mxs: Rework the PIO mode operation

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]


> I agree, but I still don't like squashing the two patches together. I forgot to 
> mention it last time, but please, look at the patches one more time. Jurgens' 
> does the DT change and mine fixes the PIO on MX23, I'd like to keep these 
> changes separate.

Ok, as said, I am not pushing hard on this.

> > Then, add the comment to the check so ppl will notice there?
> 
> If I could add a big red flashing sign into the code stating "If you go over 4 
> bytes here, a kitten will die", then by all means, I would add it. 
> Unfortunatelly, there is no such thing possible.

I'd say if somebody changes the code with that comment on top of it, it
is really deserved...


> Maybe WARN_ONCE and return with error might just work?

... but if you insist, I can accept this.

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]