From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Lu Jingchang-B35083
<B35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Estevam Fabio-R49496
<r49496-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Li Xiaochun-B41219
<B41219-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jin Zhengxiong-R64188
<R64188-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: 答复: [PATCH v3 2/2] i2c: imx: Add Vybrid VF610 I2C controller support
Date: Thu, 15 Aug 2013 11:48:52 +0200 [thread overview]
Message-ID: <20130815094850.GB2987@katana> (raw)
In-Reply-To: <20130813161214.GV26614-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
> I vote for having the exact SoC revision in the binding documentation
> rather than wildcards or references to the list of i.MX SoCs. Otherwise
> only the driver code gives a clue that the i2c driver matches imx1-i2c,
> imx21-i2c and vf610-i2c, but not imx31-i2c.
Dunno if I got all right, so adding my 2 cents:
Yes to adding each SoC to the binding docs. No to adding each SoC to the
driver as a seperate 'compatible' entry if not really needed to
distinguish IP versions. I mean imx31 should have two compatible entries
anyhow, one for imx31 and one for imx21 as fallback, no?
That all being said: Unless somebody objects, I'll pick the most recent
VF610 series today and leave the doc fixup for later.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-15 9:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 4:44 [PATCH RESEND 1/2] ARM: dts: vf610-twr: enable i2c0 device Jingchang Lu
[not found] ` <1375418648-22760-1-git-send-email-b35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-08-02 4:44 ` [PATCH v3 2/2] i2c: imx: Add Vybrid VF610 I2C controller support Jingchang Lu
[not found] ` <1375418648-22760-2-git-send-email-b35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-08-05 8:30 ` Sascha Hauer
[not found] ` <20130805083050.GN26614-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-08-05 9:32 ` Lu Jingchang-B35083
[not found] ` <B56CDBE15CE27145A4B77D2D24263E851FC075-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-08-05 9:53 ` Sascha Hauer
[not found] ` <20130805095322.GP26614-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-08-05 15:51 ` 答复: " Lu Jingchang-B35083
2013-08-10 14:08 ` Mark Rutland
2013-08-12 12:56 ` 答复: " Lu Jingchang-B35083
[not found] ` <B56CDBE15CE27145A4B77D2D24263E851FE7AC-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-08-12 16:43 ` Mark Rutland
[not found] ` <20130812164354.GF27165-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2013-08-12 16:59 ` Tomasz Figa
2013-08-12 17:04 ` Kumar Gala
2013-08-12 23:23 ` 答复: " Stephen Warren
[not found] ` <52096E77.4040003-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-13 7:46 ` s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ
[not found] ` <20130813074620.GR26614-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-08-13 15:48 ` Stephen Warren
[not found] ` <520A5558.708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-13 16:12 ` s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ
2013-08-14 3:29 ` Shawn Guo
[not found] ` <20130813161214.GV26614-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-08-15 9:48 ` Wolfram Sang [this message]
2013-08-04 13:30 ` [PATCH RESEND 1/2] ARM: dts: vf610-twr: enable i2c0 device Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815094850.GB2987@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=B35083-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=B41219-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=R64188-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=r49496-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).