From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Lothar Waßmann" <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Cc: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: mxs: fix broken timing calculation
Date: Fri, 16 Aug 2013 18:10:45 +0200 [thread overview]
Message-ID: <20130816161045.GC3046@katana> (raw)
In-Reply-To: <1373041680-26939-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 780 bytes --]
On Fri, Jul 05, 2013 at 06:28:00PM +0200, Lothar Waßmann wrote:
> The timing calculation is rather bogus and gives extremely wrong
> results for higher frequencies (on an i.MX28). E.g. instead of 400 kHz
> I measured 770 kHz.
>
> Implement a calculation that adheres to the I2C spec and gives exact
> results for I2C frequencies from 12.56 kHz to 960 kHz.
>
> Also the bus_free and leadin parameters are programmed according to
> the I2C spec for standard and fast mode.
>
> This was tested on a Ka-Ro TX28 module with a DS1339, TSC2007, PCA9554
> and SGTL5000 client.
>
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Applied to for-next, thanks! Please mention stuff like the whitespace
fix in the changelog, too.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-16 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 16:28 [PATCH] i2c: mxs: fix broken timing calculation Lothar Waßmann
[not found] ` <1373041680-26939-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2013-07-05 16:53 ` Marek Vasut
[not found] ` <201307051853.45786.marex-ynQEQJNshbs@public.gmane.org>
2013-07-05 17:28 ` Lothar Waßmann
[not found] ` <20951.550.818976.677404-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2013-07-05 17:37 ` Marek Vasut
[not found] ` <201307051937.10975.marex-ynQEQJNshbs@public.gmane.org>
2013-07-15 10:22 ` Lothar Waßmann
[not found] ` <20963.52588.898163.953695-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2013-07-15 12:24 ` Marek Vasut
[not found] ` <201307151424.32248.marex-ynQEQJNshbs@public.gmane.org>
2013-07-16 8:10 ` Lothar Waßmann
[not found] ` <20965.3.293494.346855-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2013-07-17 17:54 ` Marek Vasut
[not found] ` <201307171954.59556.marex-ynQEQJNshbs@public.gmane.org>
2013-07-18 11:18 ` Lothar Waßmann
[not found] ` <20967.53016.902909.282346-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2013-08-15 10:12 ` Wolfram Sang
2013-08-15 10:13 ` Wolfram Sang
2013-08-15 21:30 ` Marek Vasut
2013-08-16 16:10 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816161045.GC3046@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \
--cc=fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).